[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

nickdesaulniers added a comment. The same failing assertion is tripping up Linaro's TCWG Linux kernel builds: - https://ci.linaro.org/job/tcwg_kernel-bisect-llvm-master-arm-mainline-allmodconfig/33/artifact/artifacts/build-2dd17ff08165e6118e70f00e22b2c36d2d4e0a9a/03-build_linux/console.log - ht

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

nickdesaulniers added inline comments. Comment at: clang/test/Sema/implicit-int-float-conversion.c:3 +// RUN: %clang_cc1 %s -verify -Wimplicit-const-int-float-conversion +// RUN: %clang_cc1 %s -DNONCONST=1 -verify -Wimplicit-int-float-conversion If I understand

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the helping get the patch upstreamed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/ https://reviews.llvm

[PATCH] D76452: Use LLD by default for Android.

nickdesaulniers added a comment. Can we use `-DCLANG_DEFAULT_LINKER=lld` to configure AOSP's distribution of LLD, then require the use of `-fuse-ld=` when targeting OSX host tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76452/new/ https://r

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 282307. nickdesaulniers marked 4 inline comments as done. nickdesaulniers added a comment. - rebase, add captures to tests, simplify NODBG-NOT cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/ne

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked an inline comment as not done. nickdesaulniers added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3842-3846 + if (EmitDwarf && + Args.hasFlag(options::OPT_fno_eliminate_unused_debug_types, + options::OPT_felimin

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added subscribers: Nathan-Huckleberry, nickdesaulniers. nickdesaulniers added a comment. Hi @craig.topper , @Nathan-Huckleberry and I are seeing `getImpliedEnabledFeatures` at the top of our profiles now. It seems that `llvm::X86::getImpliedFeatures` is repeatedly queried for th

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a comment. I just collected a perf profile for an entire build. `getImpliedDisabledFeatures` is at the top with 9.15% of time spent in self. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a subscriber: nikic. nickdesaulniers added a comment. cc @nikic http://llvm-compile-time-tracker.com/compare.php?from=094e99d264c937cad33796b8c92fe123cb544c9e&to=16f3d698f2afbbea43e0c3df81df6f2a640ce806&stat=instructions gives me an error, am I holding it wrong? Repositor

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a comment. In D83273#2194832 , @craig.topper wrote: > It's a pretty nasty revert in our downstream tree where we have prototyped > future ISAs. So I'd like a little time to take a look. > > @nickdesaulniers what cpu and fetaures are

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

nickdesaulniers added a comment. In D83273#2194869 , @echristo wrote: > That said, it's a 10% compile time regression for compiling something like > the linux kernel or anything that's very explicit what flags they set. Digging into the profile a little

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284011. nickdesaulniers added a comment. - rebase, centralize DebugInfoKind update as per @dblaikie Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: cla

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284048. nickdesaulniers added a comment. - git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe486921fd6cf: [Clang] implement -fno-eliminate-unused-debug-types (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. build failure on windows: http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/1886/steps/test-check-clang/logs/FAIL%3A%20Clang%3A%3Adebug-info-unused-types.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. fix pushed in cbd8ec93709376fbf404c99f4eee399790e26db7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Looks like another related failure for http://green.lab.llvm.org/green/job/clang-stage1-RA/13460/consoleFull#-42777206a1ca8a51-895e-46c6-af87-ce24fa4cd561 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers created this revision. nickdesaulniers added reviewers: dblaikie, mschifer. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers requested review of this revision. Tests added in https://reviews.llvm.org/D80242 https://reviews.llvm.org/rGcbd8ec9370

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers added a comment. I'm just going to revert cbd8ec93709376fbf404c99f4eee399790e26db7 and e486921fd6cf96ae9114adac455f7c0b5c1088a7 and sort t

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. So it looks like `%clang++` should be `%clangxx` for windows, then for OSX the default value of `debug-info-kind` is different, while the tests also seem to fail there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284476. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase, move Codegen tests to _cc1, move -g1 test to driver test, use more regex for ![0-9]+, manually test --target=x86_64-apple-macosx10.15.0 which has a di

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 284477. nickdesaulniers added a comment. - squash and reupload Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Hi @dblaikie , sorry for messing up the upload, I think it's good now, but to see the latest change, you'll need to look at the diff between the 2 prior versions (https://reviews.llvm.org/D80242?vs=284053&id=284477#toc). I reverted this on Friday. It looks like

[PATCH] D85565: [Clang][Test] add specific targets for OSX failures

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. refixing in https://reviews.llvm.org/D80242 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85565/new/ https://reviews.llvm.org/D85565

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %s +// NO_DEBUG_UNUSED_TYPES: "-debug-info-kind={{

[PATCH] D85596: [Docs] Link to --print-supported-cpus option

nickdesaulniers added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:346 - Aliases of --print-supported-cpus + Aliases of :option:`--print-supported-cpus` Would you mind adding a `.` for punctuation while you're here? Repository: rG LLVM

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added inline comments. Comment at: clang/test/Driver/debug-options.c:371-373 +// RUN: %clang -### -fno-eliminate-unused-debug-types -g1 -c %s 2>&1 \ +// RUN:| FileCheck -check-prefix=NO_DEBUG_UNUSED_TYPES %

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

This revision was automatically updated to reflect the committed changes. nickdesaulniers marked an inline comment as done. Closed by commit rG4f2ad15db535: [Clang] implement -fno-eliminate-unused-debug-types (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D85692: python bindings: fix DeprecationWarning

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, echristo, srhines. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. nickdesaulniers requested review of this revision. Fixes observed warning running `ninja check-all`: llvm-project/clan

[PATCH] D85692: python bindings: fix DeprecationWarning

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d74dbc3bb1: python bindings: fix DeprecationWarning (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; comparing the report at the bottom of https://reviews.llvm.org/D85257#2197114, repasted (before this patch): +3.59% clang-12 [.] llvm::X86::get

[PATCH] D85807: [Target] Cache the command line derived feature map in TargetOptions.

nickdesaulniers added a comment. Thanks @craig.topper ! `++beers_owed;` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85807/new/ https://reviews.llvm.org/D85807 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D79495: [Sema] Allow function attribute patchable_function_entry on aarch64_be

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. oh! Thanks for the patch, I'll have to keep an eye out for this pattern in `TargetArch` in the future so we don't miss it. Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D79495: [Sema] Allow function attribute patchable_function_entry on aarch64_be

nickdesaulniers added a subscriber: tstellar. nickdesaulniers added a comment. @MaskRay can you please cherry pick this to release-10? cc @tstellar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79495/new/ https://reviews.llvm.org/D79495

[PATCH] D79525: [Sema] require -fcf-runtime-abi= for __NSConstantString

nickdesaulniers created this revision. nickdesaulniers added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. commit 81a650ee87eb ("Driver,CodeGen: introduce support for Swift CFString layout") r345222 added support for implicit typedefs for __NSConsta

[PATCH] D79804: [x86] prevent 64b operands to "r" constrained inline asm for -m32

nickdesaulniers created this revision. nickdesaulniers added reviewers: ahatanak, craig.topper. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. nickdesaulniers added a subscriber: dwmw2. As pointed out by David Woodhouse and Akira Hatanaka in https://bugs.llvm.org

[PATCH] D79525: [Sema] require -fcf-runtime-abi= for __NSConstantString

nickdesaulniers added a comment. clang::Codegen::DeferredDecls might be of interest here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79525/new/ https://reviews.llvm.org/D79525 ___ cfe-commits mailin

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. @aaron.ballman should review+accept this before you land it, but I'm satisfied with the result. Thank you @inclyc for working on this! Repository: rG LLVM Github Monorepo

[PATCH] D133109: [LLVM][ARM] Remove options for armv2, 2A, 3 and 3M

nickdesaulniers accepted this revision. nickdesaulniers added a comment. For the Linux kernel, we're only building v5+ continuously. It looks like the Linux kernel supports v4+ and v3m (for Acorn Risc-PC (Intel StrongARM(R) SA-110)). We've never been able to build that target, and it's not high

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

nickdesaulniers added a comment. @rsmith can we get some guidance here? Has your opinion changed in the time since GCC has been shipping this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___

[PATCH] D119296: KCFI sanitizer

nickdesaulniers accepted this revision. nickdesaulniers added a comment. I see you modified the mir parser & printer; consider adding a .mir test. Still LGTM. Might be nice to document the generated asm more for other compiler vendors to better understand the implementation, rather than having t

[PATCH] D122325: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The generated arm_neon.h header isn't -Wdeclaration-after-statemen

[PATCH] D122325: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. D122189 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122325/new/ https://reviews.llvm.org/D122325 ___

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417661. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - fix incorrect REQUIRES Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https://reviews.llvm.org/D12

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a2e56b70e2f: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement (authored by nickdesaulniers). Repository: rG LLVM Github

[PATCH] D118052: [X86] Fix CodeGen Module Flag for -mibt-seal

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/X86/x86-cf-protection.c:5-16 +// RUN: %clang -target i386-unknown-unknown -o - -emit-llvm -S -fcf-protection=branch -flto %s | FileCheck %s --check-prefix=NOIBTSEAL +// RUN: %clang -target i386-unknown-unknown

[PATCH] D121556: [randstruct] Add randomize structure layout support

nickdesaulniers added a comment. In D121556#3427620 , @void wrote: > In D121556#3419184 , @aaron.ballman > wrote: > >> Generally I think things are looking pretty good, but there's still an open >> question and

[PATCH] D130754: [X86] Support ``-mindirect-branch-cs-prefix`` for call and jmp to indirect thunk

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130754/new/ https://reviews.llvm.org/D130754 __

[PATCH] D129954: [CodeGen][inlineasm] assume the flag output of inline asm is boolean value

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Thanks for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129954/new/ https://reviews.llvm.org/D129954 ___ cfe-commits m

[PATCH] D131012: No longer place const volatile global variables in a read only section

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch. I've asked some of my colleagues who work on libabigail their thoughts on the implications of this change. Due to timezones, it may take some time to h

[PATCH] D131416: [Clang][BinaryOperator] cache ICEKind

nickdesaulniers added inline comments. Comment at: clang/include/clang/AST/Expr.h:30 #include "clang/Basic/TypeTraits.h" +#include "llvm/ADT/Optional.h" #include "llvm/ADT/APFloat.h" Please keep the list of `#include`s alphabetically sorted.

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers created this revision. nickdesaulniers added reviewers: rsmith, aaron.ballman, craig.topper, efriedma, lebedev.ri, jdoerfert, arsenm. Herald added subscribers: dexonsmith, hiraditya. nickdesaulniers requested review of this revision. Herald added subscribers: llvm-commits, cfe-comm

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 358814. nickdesaulniers added a comment. - remove accidentally committed logging statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106030/new/ https://reviews.llvm.org/D106030 Files: clang/docs

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added a comment. In D106030#2878897 , @arsenm wrote: > Adding something to the IR for the sole purpose of producing a diagnostic > feels really weird. I'm not sure I see why the frontend can't see this > attribute and directly warn I in

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added a comment. In D104058#2878083 , @samitolvanen wrote: > In D104058#2877631 , > @nickdesaulniers wrote: > >> Change LGTM, but I don't understand why the following tests are modified: >> >> -

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers accepted this revision. nickdesaulniers added a comment. Sorry, I always forget when these are necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 __

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 359912. nickdesaulniers marked 5 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. Herald added a subscriber: pengfei. - change IR Attr to dontcall - check during ISel(s) - rename td diag - h

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3816 + +def Error : Attr { + let Spellings = [GCC<"error">]; aaron.ballman wrote: > I think this should be an inheritable attribute (same below) so that > redeclarations get th

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp:77 + // references from inline assembly. + std::string Alias = ".set \"" + OldName + "\",\"" + NewName + "\"\n"; + ExportM.appendModuleInlineAsm(Alias);

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers updated this revision to Diff 360324. nickdesaulniers marked 4 inline comments as done. nickdesaulniers edited the summary of this revision. nickdesaulniers added a comment. - merge ErrorAttr with WarningAttr - fix dumb short circuit bug - rename diag group - handle multiple instan

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3823 + +def Warning : Attr { + let Spellings = [GCC<"warning">]; aaron.ballman wrote: > nickdesaulniers wrote: > > aaron.ballman wrote: > > > Given that the only functional diff

[PATCH] D106030: [Clang] add support for error+warning fn attrs

nickdesaulniers added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning.c:29 + duplicate_errors(); // expected-error {{call to 'duplicate_errors' declared with attribute error: two}} + // TODO: why is this a warning not an error + duplicate_

[PATCH] D93182: [clang-tidy] Add linux kernel log functions checker

nickdesaulniers added a comment. In D93182#2451509 , @lebedev.ri wrote: > Out of curiocity, are all checkpatch diagnostics (and something else)? > are planned to be ported into being clang-tidy checks? Not at this time, no. > How many will checks will th

[PATCH] D122188: [Clang] update_cc_test_checks on 2 ARM NEON tests. NFC

nickdesaulniers created this revision. nickdesaulniers added a reviewer: DavidSpickett. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I'm planning to u

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers created this revision. nickdesaulniers added a reviewer: DavidSpickett. Herald added a subscriber: kristof.beyls. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The generated arm

[PATCH] D122188: [Clang] update_cc_test_checks on 2 ARM NEON tests. NFC

nickdesaulniers added a comment. Now that I can more easily see the actual diff (https://reviews.llvm.org/D122189), let me see if I can simply rebase https://reviews.llvm.org/D122189 on main so that we can drop this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417116. nickdesaulniers added a comment. - rebase on main, don't mass refomat tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https://reviews.llvm.org/D122189 Files: clang/test/CodeGe

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers updated this revision to Diff 417328. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - add comments, remove test requirement on 64b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122189/new/ https:

[PATCH] D122189: [Clang][NeonEmitter] emit ret decl first for -Wdeclaration-after-statement

nickdesaulniers added a comment. In D122189#3399836 , @DavidSpickett wrote: > Can you post a bit of the header diff before/after? I think I know what it > looks like but just to be sure. Before: #define __noswap_splat_lane_f16(__p0,__p1) __extension__

[PATCH] D122224: Allow -Wno-gnu to silence GNU extensions related to pointer arithmetic

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. TIL about `Extension<>` and `-verify=`. Thanks @aaron.ballman ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14/new/ http

[PATCH] D123308: Handle a subtle hole in inline builtin handling

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the quick fix! Comment at: clang/lib/CodeGen/CGExpr.cpp:4968-4969 // name to make it clear it's not the actual builtin. -if (FD->isInlin

[PATCH] D123308: Handle a subtle hole in inline builtin handling

nickdesaulniers added a comment. Also, for the initial lines of commit messages, please try to make them less ambiguous about which parts of the project they touch. For example `[Clang][Fortify] drop inline decls when redeclared` is more descriptive should this get bucketed with other commits

[PATCH] D123544: [randstruct] Automatically randomize a structure of function pointers

nickdesaulniers added a comment. > if the developer uses default initialization for a randomized structure. Yeah, I suspect that @aaron.ballman @lebedev.ri @xbolva00 missed that this just extends the newly added opt-in `-frandomize-layout-seed=` (https://reviews.llvm.org/D121556). Why a develop

[PATCH] D123649: Allow flexible array initialization in C++.

nickdesaulniers added a comment. For posterity, posting the link to the failure this caused in Linaro's TCWG's CI of kernel builds w/ clang: https://lore.kernel.org/llvm/906914372.14298.1650022522881@jenkins.jenkins/. I'm guessing D123826 fixes this? Reposit

[PATCH] D123874: [Clang][IA] support -generate-unused-section-symbols={yes|no}

nickdesaulniers created this revision. nickdesaulniers added a reviewer: MaskRay. Herald added subscribers: StephenFan, dexonsmith, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits,

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added a comment. Please add a test where calls to `@llvm.kcfi.check` produce `KCFI_CHECK` during instruction selection. (You can use `-stop-before=finalize-isel` to dump the IR prior to isel; this can stay a .ll test, I think, rather than .mir). Comment at: cl

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: llvm/lib/MC/MCObjectFileInfo.cpp: + + const MCSectionELF &ElfSec = static_cast(TextSec); + unsigned Flags = ELF::SHF_LINK_ORDER; nickdesaulniers wrote: > or just `cast`. > https://llvm.org/docs/ProgrammersM

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:553-554 + if (LangOpts.Sanitize.has(SanitizerKind::KCFI)) { +EmitKCFIConstants(); +ClearUnusedKCFIPrefixes(); + } This is the only call site for these two methods, an

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:2255-2260 + for (const char &C : Name) { +if (llvm::isAlnum(C) || C == '_' || C == '.') + continue; +return false; + } + return true; samitolvanen wrote: > nick

[PATCH] D119296: KCFI sanitizer

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. LGTM; it would be good if you could provide steps to test this on the Linux kernel. (i.e. what kernel patches are needed). Consider waiting for at least one additional review

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added a comment. In D110869#3295559 , @void wrote: > Weird. We generate similar code to GCC: > > Clang: > _paravirt_ident_64: # @_paravirt_ident_64 > movq%rdi, %rax > xorq%rdi, %rdi >

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. I tested the following linux-next configs with CONFIG_ZERO_CALL_USED_REGS enabled: - x86_64 defconfig - x86_64 defconfig + thin LTO - x86_64 defconfig + full LTO - i386 defco

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added inline comments. Comment at: llvm/test/CodeGen/X86/zero-call-used-regs.ll:287 +entry: + store volatile i32 2, i32* @result, align 4 + ret i32 0 void wrote: > nickdesaulniers wrote: > > necessary? > It's main. Of course it's necessary. :-)

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/X86/X86FrameLowering.cpp:595 +continue; + XorOp = X86::PXORrr; +} else if (X86::VR256RegClass.contains(Reg)) { void wrote: > nickdesaulniers wrote: > > Is there any way to figure

[PATCH] D119296: KCFI sanitizer

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:5419 + typedef typeof(f1) * __attribute__((kcfi_unchecked) unchecked_t; + ((unchecked_t)p2)(); // unchecked + `p2` is already unchecked. Would it be more demonstrative to

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added a comment. Can you link to the lore thread on discussions around the builtin? Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null(BuiltinCall->getArg(0)); + `auto *Call =` https://llvm.org/docs/CodingStandards

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null(BuiltinCall->getArg(0)); + nickdesaulniers wrote: > `auto *Call =` > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with

[PATCH] D124211: Add __builtin_call_kcfi_unchecked

nickdesaulniers added a comment. In D124211#3480709 , @samitolvanen wrote: > In D124211#3480652 , > @nickdesaulniers wrote: > >> Can you link to the lore thread on discussions around the builtin? > > There's no

[PATCH] D119296: KCFI sanitizer

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. (tentatively removing my +1 since this patch has changed quite a bit since my initial review) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D119296: KCFI sanitizer

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. In D119296#3481573 , @joaomoreira wrote: > I'm not an expert on LLVM's pipeline, but it just feels a little awkward and > redundant

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:682 +// The called routine is expected to preserve r19-r28 +// r29 and r30 are used as frame pointer and link register resp. +return 0; What happens if

[PATCH] D124836: [AArch64] Add support for -fzero-call-used-regs

nickdesaulniers added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:776-778 + // For GPRs, we only care to clear out the 64-bit register. + if (MCRegister XReg = getRegisterOrZero(Reg)) +GPRsToZero.set(XReg); nick

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers created this revision. Herald added subscribers: jsji, jdoerfert, pengfei, hiraditya, mgorny. Herald added a reviewer: aaron.ballman. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers updated this revision to Diff 443986. nickdesaulniers added a comment. - add more links to commit message as they come in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129572/new/ https://reviews.llvm.org/D129572 Files: clang/doc

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2240d72f15f3: [X86] initial -mfunction-return=thunk-extern support (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645660 , @nickdesaulniers wrote: > - add more links to commit message as they come in Oh, right, updating the commit message doesn't update the description in phab. Oops! Repository: rG LLVM Github Monor

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645895 , @erichkeane wrote: > Did a post-commit review on the CFE changes, and all look OK to me. Thanks for the review! > That FIXME is a shame, we should see if we can fix that ASAP. We should AT > LEAST

[PATCH] D129572: [X86] initial -mfunction-return=thunk-extern support

nickdesaulniers added a comment. In D129572#3645934 , @erichkeane wrote: > Our typical rule is to keep the 1st one I think, and reject the 2nd. But then the _codegen_ will differ from GCC. And we _want_ clang to be a drop in replacement, so differing

<    1   2   3   4   5   6   7   8   9   10   >