nickdesaulniers added a comment.

In D124211#3480709 <https://reviews.llvm.org/D124211#3480709>, @samitolvanen 
wrote:

> In D124211#3480652 <https://reviews.llvm.org/D124211#3480652>, 
> @nickdesaulniers wrote:
>
>> Can you link to the lore thread on discussions around the builtin?
>
> There's no LKML discussion about the built-in, but there were earlier 
> proposals of using an attribute to accomplish the same thing. @pcc suggested 
> using a built-in instead, and the reviewers in D122673 
> <https://reviews.llvm.org/D122673> agreed that it's a more appropriate 
> solution. In the kernel, the indirect `static_call` trampoline calls that are 
> patched into direct calls at boot are the primary reason we need a 
> finer-grained method of disabling CFI checks.

Perhaps it's time to start a discussion on LKML then, before landing this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124211/new/

https://reviews.llvm.org/D124211

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to