nickdesaulniers added inline comments.
================ Comment at: clang/lib/Sema/SemaChecking.cpp:436 + + auto Call = dyn_cast_or_null<CallExpr>(BuiltinCall->getArg(0)); + ---------------- nickdesaulniers wrote: > `auto *Call =` > https://llvm.org/docs/CodingStandards.html#beware-unnecessary-copies-with-auto Also, can this simply be a `dyn_cast` rather than `dyn_cast_or_null`? Don't you already check the arg count above? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124211/new/ https://reviews.llvm.org/D124211 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
