[PATCH] D115647: [clang-format] FixNamespaceComments does not understand namespace aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6482383e50a4: [clang-format] FixNamespaceComments does not understand namespace aliases (authored by MyDeveloperDay). Repository: rG LLVM Github M

[PATCH] D115625: [clang-format] add support for cppm files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcea81e95b05f: [clang-format] add support for cppm files (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D115738: [clang-format] Code following C# Lambda Expressions has wrong formatting

MyDeveloperDay added a comment. I tested this on the original code that made me make the original change, and I like your fix much better ;-) Thank you for this patch, interested on working on other C# clang-format issues? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ http

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. Thank you for the patch, this looks good but we do need a unit test in `clang/unittest/Format/FormatTestJson.cpp` you can then build them with `ninja FormatTests`, if you need help let me know Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. The following will show the issue TEST_F(FormatTestJson, DisableJsonFormat) { FormatStyle Style = getLLVMStyle(FormatStyle::LK_Json); verifyFormat("{}", Style); verifyFormat("{\n" " \"name\": 1\n" "}",

[PATCH] D115794: [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: Sam0523, HazardyKnusperkeks, owenpan, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/52715 Fixes #52715 `AllowShortBl

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1872 // calling `addUnwrappedLine()` here causes odd parsing errors. FormatTok->MustBreakBefore = true; } part of me thinks the MustBre

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:766 + + verifyFormat(R"(// +public class Sample { Nit: (only my preference) but I don't like the use of RawStrings in these tests (I know others have let them creep in

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. I think your previous change is dropped from the review, but the test in combination with your original change were good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769 _

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay added a comment. looks like you reverted the change https://reviews.llvm.org/D115769?vs=394414&id=394582#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769 ___

[PATCH] D115803: [clang-format] Fix tabs when using BreakBeforeTernaryOperators=false.

MyDeveloperDay added a comment. So am I right in thinking the got replaced out because C.Spaces was > C.StartOfTokenColumn? (i.e. appendIndentText was given a negative number as the 4th argument) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, thank you for the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https://reviews.llvm.org/D115769 __

[PATCH] D115673: [clang-format] C# switch expression formatting differs from normal switch formatting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebed0ca71561: [clang-format] C# switch expression formatting differs from normal switch… (authored by MyDeveloperDay). Repository: rG LLVM Github

[PATCH] D115794: [clang-format] put non-empty catch block on one line with AllowShortBlocksOnASingleLine: Empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa94aab12a4e0: [clang-format] put non-empty catch block on one line with… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63a565768e8f: [clang-format] Remove spurious JSON binding when DisableFormat = true (authored by Andrew-William-Smith, committed by MyDeveloperDay).

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. Ping! Could we see this previously approved patch over the line I’d like to use it to build a regression suit of code and format files without the need for every test to be in its own directory CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ ht

[PATCH] D115865: [clang-format] add support for branch attribute macros

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49184 clang-format doesn't handle the use

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan, MarcusJohnson91. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49804 Interaction betwee

[PATCH] D115865: [clang-format] add support for branch attribute macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2b671c3fe0d6: [clang-format] add support for branch attribute macros (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan, lichray. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/43196 Fixes #43196 -> is incorre

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) {

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay updated this revision to Diff 395088. MyDeveloperDay added a comment. As always you are both correct - tidy up the unit tests to follow our pattern - reduce unnecessary style setting - try and tidy up the indent selection a little CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay marked 7 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1282-1300 if (FormatTok->Tok.is(tok::string_literal)) { nextToken(); if (FormatTok->Tok.is(tok::l_brace)) { +if (

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1682 Current.NestingLevel == 0 && - !Current.Previous->is(tok::kw_operator)) { + !Current.Previous->isOneOf(tok::kw_operator, tok::identifier)) {

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius, owenpan. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/27740 Ensure #define _u(str) u#str #defin

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

MyDeveloperDay added a comment. In D115938#3199832 , @curdeius wrote: > When at it, should we also take care of `LR"(string)"`, `R`, `uR`, `u8R` and > `UR`? Cf. https://en.cppreference.com/w/cpp/language/string_literal > From MS doc: > > // Raw string

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

MyDeveloperDay added a comment. In D115738#3199879 , @peterstys wrote: > This is my first PR into this repo. I'd like to learn more about the process > of submitting patches, specifically about: > > - Do I need to get LGTM from all the reviewers before I

[PATCH] D115738: [clang-format] Fix formatting of the code that follows C# Lambda Expressions

MyDeveloperDay added a comment. Thank you for the patch We'll need your name and email address for that, but yes we'll be happy to commit it for you. If you think you'd like to play some more, then you can apply for commit access. (not sure of the process for that now, but its probably in the

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

MyDeveloperDay updated this revision to Diff 395135. MyDeveloperDay added a comment. Add the raw string literal cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115938/new/ https://reviews.llvm.org/D115938 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatT

[PATCH] D115938: [clang-format] Formatter does not handle c++11 string literal prefix with stringize #

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG62ead3654795: [clang-format] Formatter does not handle c++11 string literal prefix with… (authored by MyDeveloperDay). Repository: rG LLVM Github

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

MyDeveloperDay updated this revision to Diff 395165. MyDeveloperDay added a comment. Add additional test to show lambda's should be ok CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115903/new/ https://reviews.llvm.org/D115903 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittes

[PATCH] D115879: [clang-format] extern with new line brace without indentation

MyDeveloperDay updated this revision to Diff 395166. MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Address nits and review comments (remove unnecessary lines) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115879/new/ https://reviews.llvm.org/D115879 F

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 __

[PATCH] D115968: [clang-format] Refactor common handling of attributes. NFC.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115968/new/ https://reviews.llvm.org/D115968 ___

[PATCH] D115972: [clang-format] Fix AlignConsecutiveAssignments breaking lambda formatting.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115972/new/ https://reviews.llvm.org/D115972 ___

[PATCH] D115903: [clang-format] Extra spaces surrounding arrow in templated member call in variable decl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG936a67f089ef: [clang-format] Extra spaces surrounding arrow in templated member call in… (authored by MyDeveloperDay). Repository: rG LLVM Github

[PATCH] D114583: [clang-format] Adjust braced list detection

MyDeveloperDay added a comment. This is having an impact on code in flang, I don't deny it might be better, but it may not be what is wanted. - explicit Expr(const Scalar &x) : u{Constant{x}} {} - explicit Expr(Scalar &&x) : u{Constant{std::move(x)}} {} + explicit Expr(const Scalar &x)

[PATCH] D115879: [clang-format] extern with new line brace without indentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3362fa59ec40: [clang-format] extern with new line brace without indentation (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHA

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: krasimir, owenpan, HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/49846 Fixes #49846 Repository:

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay updated this revision to Diff 395291. MyDeveloperDay added a comment. Double check the interaction with the AlignConsecutiveAssignments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115990/new/ https://reviews.llvm.org/D115990 Files: clang/include/clang/Format/Format.h

[PATCH] D116001: [clang-format] add regression tests for braced lists

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116001/new/ https://reviews.llvm.org/D116001 ___

[PATCH] D116001: [clang-format] add regression tests for braced lists

MyDeveloperDay added a comment. thanks for picking this one up (and finding it in the first place) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116001/new/ https://reviews.llvm.org/D116001 ___ cfe-commi

[PATCH] D116000: Revert "[clang-format] Adjust braced list detection"

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I think we have to do this as the fix broke more than it fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116000/new/ https:

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay updated this revision to Diff 395329. MyDeveloperDay added a comment. clang-format the file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115990/new/ https://reviews.llvm.org/D115990 Files: clang/include/clang/Format/Format.h clang/lib/Format/TokenAnnotator.cpp cla

[PATCH] D116008: [clang-format] Fix wrong indentation of namespace identifiers after a concept declaration.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116008/new/ https://reviews.llvm.org/D116008 ___

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2005 - } - break; case tok::l_square: Is this case not covered by this? I presume not as you didn't remove any unit tests https://github.com/llvm/llvm-proj

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, (the original code had a unit test so we should be good). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 ___

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1875 +// const a = in JavaScript. +if (Style.isJavaScript() && PreviousNotConst->is(tok::kw_const)) + return true; owenpan wrote: > curdeius wrote: > > Nit. > +1 I

[PATCH] D115967: [clang-format][NFC] Handle wrapping after => in mustBreakBefore()

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115967/new/ https://reviews.llvm.org/D115967 ___ cfe-commits mailing li

[PATCH] D116049: [clang-format] Fix SplitEmptyRecord affecting SplitEmptyFunction.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, less the clang-format oddities Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116049/new/ https://reviews.llvm.org/D116049

[PATCH] D115990: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e28b86cc629: AlignConsecutiveDeclarations not working for 'const' keyword in JavsScript (authored by MyDeveloperDay). Changed prior to commit: ht

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added a comment. You need some unit tests to show it working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-co

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

MyDeveloperDay added a comment. Can you test the typedef case you added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 ___ cfe-commits mailing list cfe-commit

[PATCH] D116189: [clang-format][NFC] Correct comment about checking merging of blocks

MyDeveloperDay added a comment. We need your name and email address to be able to commit as you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116189/new/ https://reviews.llvm.org/D116189 ___ cfe-commits

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay marked 4 inline comments as done. MyDeveloperDay added a comment. Please go ahead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

MyDeveloperDay added a comment. you need to add a unit test int clang/unittest/Format/FormatTest.cpp (we tend to not use lit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 ___

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/Format.cpp:1197 LLVMStyle.ReferenceAlignment = FormatStyle::RAS_Pointer; + LLVMStyle.SeparateDefinitionBlocks =

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); There should be a PARSE unit test too

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

MyDeveloperDay added a comment. See D95168: [clang-format] Add Insert/Remove Braces option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116316/new/ https://reviews.llvm.org/D116316 __

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18515 +TEST_F(FormatTest, BreakPenaltyAfterLParen) { + FormatStyle Style = getLLVMStyle(); 1) fix the formatting 2) add a default case which shows how the bracket will

[PATCH] D116314: [Clangfmt] Add style to separate definition blocks

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3404 + + * ``SDS_Leave`` (in configuration: ``Leave``) +Leave definition blocks separated as they are. This enumeration surely needs 3 settings ``` Leave, // don't

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3755 + * ``bool AfterOperatorOverloading`` If ``true``, put a space between operator overloading and opening parentheses. + curdeius wrote: > I'm not fond of the current

[PATCH] D116316: [clang-format] Add an experimental option to remove optional control statement braces in LLVM C++ code

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3398 +**RemoveBracesLLVM** (``Boolean``) :versionbadge:`clang-format 14` + Remove optional braces of control statements (``if``, ``else``, ``for``, Can we agree on one set

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18519 + Style.PenaltyExcessCharacter = 15; + EXPECT_EQ("int foo(\n" +"int );", any reason you are not using verifyFormat here? Repo

[PATCH] D72326: [clang-format] Add option to explicitly specify a config file

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:9212 + StyleWithLine.EmptyLinesAfterAccessModifier = 1u; + EXPECT_EQ(test2NL, format(test0NL, StyleWithLine)); + EXPECT_EQ(test2NL, format(test1NL, StyleWithLine)); Max_S w

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:9392 + "};\n"; + EXPECT_EQ(NL_B_3_A_1_I_3, format(NL_B_3_

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. could you please mark your comments done when they are done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 ___ cfe-commits maili

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:2132 +**EmptyLineAfterAccessModifier** (``EmptyLineAfterAccessModifierStyle``) + Defines in which cases to put empty line after access modifiers. + Comme

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. enum { A, B, C, } ShortEnum1, ShortEnum2; I've seen this before maybe with regard to something else, but can't quite recall. (maybe a bug in the bug tracker) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. If you follow people tweeting about clang-format (as I do) and you look through the bug tracking system, one major criticism of clang-format is that the second clang-format can be different from the first, sometimes an equilibrium can be found sometimes not. Whe

[PATCH] D99031: [clang-format] Fix CompactNamespaces corner case when AllowShortLambdasOnASingleLine/BraceWrapping.BeforeLambdaBody are set

MyDeveloperDay added a comment. In D99031#2640654 , @HazardyKnusperkeks wrote: > In D99031#2640425 , @aybassiouny > wrote: > >>> How about verifyFormat? Would that fail without your patch? >> >> @HazardyKnusperkek

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

MyDeveloperDay added a comment. A quick search of github shows over 1 billion hits to the word struct, in a variety of flavours, I'm just not convinced we want a separate option for each and every case, Could we not look for a sequence of "tok::kw_struct,tok::identifier,tok::lbrace" or kw_strc

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay added a comment. I'd be quite interested to understand what the impact (if any) would be on javascript and C# formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 _

[PATCH] D99458: [clang-format] Fix east const pointer alignment of operators

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99458/new/ https://reviews.llvm.org/D99458 ___ cfe-commits maili

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM thank you for trying where you could to use verifyFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98237/new/ https://reviews.llvm.org/D98237 _

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

MyDeveloperDay added a comment. can you clang-format so it passes the pre-merge checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99503/new/ https://reviews.llvm.org/D99503 ___ cfe-commits mailing lis

[PATCH] D99503: [clang-format] Inconsistent behavior regarding line break before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8977 + "};\n", + NoEmptyLines); verifyFormat("struct foo {\n" if you left a line between this test or added your test at the end it wouldn't ha

[PATCH] D100778: [clang-format] Prevent extraneous space insertion in bitshift operators

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:125 + CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( +

[PATCH] D100727: [clang-format] Correctly apply AllowShortIfStatementsOnASingleLine: Always to else branch.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100727/new/ https://reviews.llvm.org/D100727 ___ cfe-commits mailing list cf

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

MyDeveloperDay added a comment. > I don't think we should change the LLVM style I'm not 100% convinced we are changing the LLVM style per say. LLVM always "cuddles" the "{" and Allow short Enums on a single line is true, this means if the "{" is on a new line then I think its actually a bug.

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, krasimir, klimek. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48594 Empty or small templates were not being treated the s

[PATCH] D93846: Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added a comment. Thank you for this patch, a few process issues. Comment at: clang/include/clang/Format/Format.h:58 + /// If true, the empty line is inserted before access modifiers + /// \code you need to run clang/doc/tools/dump_style.py so

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

MyDeveloperDay added a comment. I'm a little confused why this is needed as clang-format always read up the directory tree until it see a .clang-format file, perhaps I don't quite understand the use case. Can't you just have a different .clang-format in the subdirectory? Repository: rG LLVM

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay updated this revision to Diff 313853. MyDeveloperDay added a comment. Addressing additional usecase found issues in C# tests too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93839/new/ https://reviews.llvm.org/D93839 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:68 + /// \endcode + bool InsertEmptyLineBeforeAccessModifier; + HazardyKnusperkeks wrote: > MyDeveloperDay wrote: > > quite a mouthful... maybe just `NewLineBeforeAccessModifi

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:252 + + if (Tok && Tok->is(tok::kw_template) && + Style.BraceWrapping.SplitEmptyRecord && EmptyBlock) { HazardyKnusperkeks wrote: > Why is this not just al

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544-8556 + EXPECT_EQ("struct foo {\n" +" int i;\n" +"\n" +"private:\n" +" int j;\n" +"}\n", +format("struct foo {\n"

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

MyDeveloperDay added a comment. I like what you are suggesting, do you think `BasedOnStyle: File` is the best terminology as the term `File` is used elsewhere to mean read from the .clang_format file, how about `BasedOnStyle: Inherit` `BasedOnStyle: InheritFromParent` `BasedOnStyle: InheritFrom

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544-8556 + EXPECT_EQ("struct foo {\n" +" int i;\n" +"\n" +"private:\n" +" int j;\n" +"}\n", +format("struct foo {\n"

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:1351 + /// If true, the empty line is inserted before access modifiers + /// \code The full stop will go here then regenerate. CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D93839: [clang-format] PR48594 BraceWrapping: SplitEmptyRecord ignored for templates

MyDeveloperDay updated this revision to Diff 314089. MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93839/new/ https://reviews.llvm.org/D93839 Files: clang/lib/Format/UnwrappedLine

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. I think if you think you have a bug that you log it in the bug tracker and we track it with this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 _

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. Take the following example: enum { A, B, C, D, E, F, G, H, I } Short; And the following minimal .clang-format --- ColumnLimit: 10 BreakBeforeBraces: Custom BraceWrapping: AfterEnum: true To use AfterEnum you must be using "Custom" for BreakBef

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added a comment. ok so this looks ok, but before we commit can we have a discussion about why you think it fails for the comment case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 __

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:8544 +TEST_F(FormatTest, FormatsAccessModifiers) { + EXPECT_EQ("struct foo {\n" +" int i;\n" any reason this can't be verifyFormat? Comment at

[PATCH] D93846: [clang-format] PR16518 Add flag to suppress empty line insertion before access modifier

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1221 +if (Style.EmptyLineBeforeAccessModifier && +PreviousLine->Last->isOneOf(tok::semi, tok::r_brace) && +RootToken.NewlinesBefore == 1) maybe I don

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. I think we are missing some clarity in this bug as to what the actual problem is, I do agree the test looks wrong, This seems to be that in "Attach" mode, then AllowShortEnumsOnASingleLine=false doesn't attach the brace. I'm somewhat struggling to understand how

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

MyDeveloperDay added a comment. You need to have these conversations by adding new unit tests that prove your point, I highly doubt I'll personally be willing to accept any revision without more unit tests than this one line change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

<    18   19   20   21   22   23   24   25   >