MyDeveloperDay added a comment. In D115738#3199879 <https://reviews.llvm.org/D115738#3199879>, @peterstys wrote:
> This is my first PR into this repo. I'd like to learn more about the process > of submitting patches, specifically about: > > - Do I need to get LGTM from all the reviewers before I can submit it? No, one is likely enough, but employ some level of respect for others if they are commenting (they may not explicitly say LGTM but may accept) > - There are some build failures on the CI, but look unrelated, do I force > submit passed them? They CI doesn't block commit. just check to ensure its not you, (there is some odd Go issue ATM which I've seen reported elsewhere) > Could someone help me with these questions or point me to the relevant > documentation. Thanks. https://llvm.org/docs/Contributing.html https://llvm.org/docs/Phabricator.html CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115738/new/ https://reviews.llvm.org/D115738 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
