MyDeveloperDay added a comment.

A quick search of github shows over 1 billion hits to the word struct, in a 
variety of flavours, I'm just not convinced we want a separate option for each 
and every case,

Could we not look for a sequence of 
"tok::kw_struct,tok::identifier,tok::lbrace" or kw_strcut,tok::lbrace? rather 
than using the rather fragile Line->StartsWith which is only going to capture 
some of the cases.

  typedef struct  Foo{
     ..
  }
  
  static struct Foo {
     ..
  }
  
  static constexpr struct Foo {
     ..
  }
  
  template <> struct  Foo{
    ...
  }
  
  struct {
  }




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91949/new/

https://reviews.llvm.org/D91949

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D91949: [cla... Anastasiia Lukianenko via Phabricator via cfe-commits
    • [PATCH] D91949:... Anastasiia Lukianenko via Phabricator via cfe-commits
    • [PATCH] D91949:... MyDeveloperDay via Phabricator via cfe-commits

Reply via email to