MyDeveloperDay added a comment.

In D99031#2640654 <https://reviews.llvm.org/D99031#2640654>, 
@HazardyKnusperkeks wrote:

> In D99031#2640425 <https://reviews.llvm.org/D99031#2640425>, @aybassiouny 
> wrote:
>
>>> How about verifyFormat? Would that fail without your patch?
>>
>> @HazardyKnusperkeks sorry, but not sure that I understand your point. Are 
>> you suggesting to use verifyFormat in my UT instead of EXPECT_EQ?
>
> I'm pretty sure @MyDeveloperDay would ask for that. I would maybe use both. 
> But what it really interesting for me if verifyFormat would fail, i.e. would 
> clang-format misformat something previously correctly formatted.

I would, see D98237: [clang-format] Option for empty lines after an access 
modifier. <https://reviews.llvm.org/D98237> as to why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99031/new/

https://reviews.llvm.org/D99031

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to