[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

leonardchan added a comment. > @leonardchan, @phosek, I am not aware of such flag. Do you know how much > memory does LTO + clang-repl consume and would it make sense to ping some of > the LTO folks for their advice? I played around a bit with adding a flag and it turned out to be not as diffi

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355323. leonardchan added a comment. Ok. Ready for reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt compi

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan added a comment. Let me know if this should be split up also. I think this might be small and and simple enough for one patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: mgorny. leonardchan requested review of this revision. As of D102374 , relative vtables is enabled on Fuchsia by defau

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355368. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/lib/hwasan/hwasan_fuchsia.cpp compiler-rt/lib

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

leonardchan updated this revision to Diff 355637. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104085/new/ https://reviews.llvm.org/D104085 Files: compiler-rt/lib/hwasan/CMakeLists.txt compiler-rt/lib/hwasan/hwasan_fuchsia.cpp compiler-rt/lib

[PATCH] D105145: [clang][Fuchsia] Remove relative-vtables multilibs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b0ddc2662ad: [clang][Fuchsia] Remove relative-vtables multilibs (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105145/new/ https:

[PATCH] D104085: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG966386514bec: [compiler-rt][hwasan] Setup hwasan thread handling on Fuchsia (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

This revision was automatically updated to reflect the committed changes. Closed by commit rG398bfa2eadbe: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete… (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. leonardchan marked 2 inline comments as done. Closed by commit rGa11aea68a4b3: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan… (authored by leo

[PATCH] D95182: [clang][Fuchsia] Turn on Relative VTables for Fuchsia

leonardchan abandoned this revision. leonardchan added a comment. Abandoned since D102374 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95182/new/ https://reviews.llvm.org/D95182 _

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

leonardchan created this revision. leonardchan added reviewers: aeubanks, vitalybuka. leonardchan added a project: Sanitizers. leonardchan requested review of this revision. Herald added a project: clang. The fix for PR52382 was already introduced in D112732 whi

[PATCH] D113143: [clang][asan] Add test for ensuring PR52382 is fixed

This revision was automatically updated to reflect the committed changes. Closed by commit rG456a7e52310d: [clang][asan] Add test for ensuring PR52382 is fixed (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113143/new/ http

[PATCH] D95204: [lld-macho] Switch default to new Darwin backend

leonardchan added a comment. Hi, I suspect thispatch might be causing the failure we're seeing in our non-mac builders (https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-x64/b8853941557626730880?): Testing: 0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..

[PATCH] D94355: [Passes] Add relative lookup table converter pass

leonardchan added a comment. One thing that just occurred to me: do we also perhaps want to hide this behind a flag? Right now it's being added to various default optimization pipelines, so some users might be surprised if they suddenly see their lookup tables change (either compiler or user ge

[PATCH] D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. Initially, this flag was meant to only be used through cc1 and not directly through the clang driver. However, we accidentally ended

[PATCH] D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70af0bf6fe46: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag (authored by leonardchan). Repository: rG LLVM Github Monorepo

[PATCH] D94355: [Passes] Add relative lookup table converter pass

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM pending a few more comments. Should also give some time to let others respond if they have feedback. Comment at: llvm/lib/Transforms/Utils/RelLookupTableConve

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan updated this revision to Diff 468701. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/C

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan created this revision. leonardchan added reviewers: mcgrathr, eugenis, phosek, vitalybuka. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Full context in https://bugs.fuc

[PATCH] D132620: [WIP][llvm] Extend aarch64 and x86_64 elf targets to use gotpcrel relocations

leonardchan created this revision. Herald added subscribers: pengfei, hiraditya, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan updated this revision to Diff 455423. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ https://reviews.llvm.org/D132425 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CGVTables.h clang/lib/CodeGen/ItaniumCXXABI.c

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3743276 , @mcgrathr wrote: > lgtm. > You might add some comments in CGVTables.cpp about why this is done and what > the alternatives might be in the future. Done. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D132691: [clang] Do not instrument the rtti_proxies under hwasan

leonardchan created this revision. leonardchan added reviewers: mcgrathr, phosek. leonardchan added a project: clang. Herald added a subscriber: kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. We run into a duplicate symbol error when instrumenting the rt

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

This revision was automatically updated to reflect the committed changes. Closed by commit rG93e5cf6b9c08: [clang] Do not instrument relative vtables under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ h

[PATCH] D132691: [clang] Do not instrument the rtti_proxies under hwasan

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdb30f7a2635: [clang] Do not instrument the rtti_proxies under hwasan (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3752468 , @hctim wrote: > Glad to see that refactoring the sanitizer metadata made someone's life > easier ;) (now allowing for disabling hwasanificiation of globals) > > Patch looks reasonable to me. Can you pleas

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: LLVM. Herald added subscribers: abrachet, hiraditya. Herald added a project: All. leonardchan requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added a comment. @phosek feel free to add who you think is appropriate for reviewing this. This is a conservative comparison of dso_local_equivalents where two are the same only if they point to the same underlying function. It could be argued that a `dso_local_equivalent @func` cou

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan updated this revision to Diff 461686. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 Files: llvm/lib/Transforms/Utils/FunctionComparator.cpp llvm/test/Transforms/MergeFunc/dso_local_equival

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added inline comments. Comment at: llvm/test/Transforms/MergeFunc/dso_local_equivalent_merged.ll:1 +;; Check the cases involving dso_local_equivalent where we do expect functions to be merged. +; RUN: opt -S -mergefunc < %s | FileCheck %s nikic wrote

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

leonardchan added a comment. Will wait until EOD before committing this unless others have more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134300/new/ https://reviews.llvm.org/D134300 ___ cf

[PATCH] D134300: [llvm] Handle dso_local_equivalent in FunctionComparator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21b03bf97061: [llvm] Handle dso_local_equivalent in FunctionComparator (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, tejohnson, pcc. leonardchan added a project: clang. Herald added a subscriber: Prazek. Herald added a project: All. leonardchan requested review of this revision. Prior to this, metadata pertaining to the size or add

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. This might allow lsan to find more leaks that would have gone undet

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

leonardchan added a comment. In D135713#3850730 , @mcgrathr wrote: > I had imagined making lsan always do this since there's a specific > lsan-related rationale for it that applies to everybody. > I'm not clear on how cmake structures things and whether

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. In D85802#3858760 , @rjmccall wrote: > Does Fuchsia still need this? If those experiments have stabilized, maybe we > can just remove it. Also, it should probably have been a -cc1 flag in the > first place. We still use th

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

leonardchan added a comment. > Naive question, but what does it mean to target Fuschia but be > gnu-compatible? (how would that be different than using whatever gnu OS > (linux, etc) the other code was built for) (Probably poor wording on my part.) When I mention gnu-compatible here, I don't m

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added subscribers: abrachet, kristof.beyls, mgorny. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: cfe-commits. `LLVM_TOOL_LLD

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. Won't be landing this until I'm sure any new tests that will be running from this won't fail locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128567/new/ https://reviews.llvm.org/D128567

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. An alternative approach to this is update this bit of cmake in compiler-rt/CMakeLists.txt: set(COMPILER_RT_LLD_PATH ${LLVM_MAIN_SRC_DIR}/tools/lld) if(EXISTS ${COMPILER_RT_LLD_PATH}/ AND LLVM_TOOL_LLD_BUILD) set(COMPILER_RT_HAS_LLD TRUE) else() set(COMP

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

leonardchan added a comment. In D128567#3609635 , @leonardchan wrote: > Won't be landing this until I'm sure any new tests that will be running from > this won't fail locally. Or given https://reviews.llvm.org/D126936 and this could just pass magically

[PATCH] D72959: Relative VTables ABI on Fuchsia

leonardchan abandoned this revision. leonardchan marked an inline comment as done. leonardchan added a comment. Herald added a subscriber: bd1976llvm. This was landed in various other smaller changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D729

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404742 , @mcgrathr wrote: > In D152405#4404616 , @leonardchan > wrote: > >> Oh this is completely independent from relative vtables. I'll update the >> wording. > > Great

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan updated this revision to Diff 556724. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152405/new/ https://reviews.llvm.org/D152405 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6385c1df919f: [clang] Add experimental option to omit the RTTI component from the vtable when… (authored by leonardchan). Changed prior to commit:

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added inline comments. Comment at: clang/include/clang/Driver/Options.td:2250 +def fexperimental_omit_rtti_component : + Flag<["-"], "fexperimental-omit-rtti-component">, + Group, Flags<[CC1Option]>, phosek wrote: > I think the name should signal th

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4645719 , @dyung wrote: > Hi @leonardchan your change was still causing a failure on the PS4 linux bot, > so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 >

[PATCH] D138855: [clang][Fuchsia] Allow for setting the default build type

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. Herald added a subscriber: abrachet. Herald added a project: All. leonardchan requested review of this revision. Prior to this, `CMAKE_BUILD_TYPE` would unconditionally be `Release`. This

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. Hi, a bisect seems to show https://reviews.llvm.org/rGf56550cf7f12b581a237b48a7f4d8b6682d45a09 is causing us to see the following error: error: argument value 1 is outside the valid range [0, 0] v2 = vdupq_lane_f64(vget_high_f64(a.v), 1); ^

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. Actually this may not need a reproducer since the error seems straightforward with just calling a builtin function. The main issue is that before this patch, something like #include float64x2_t func(int8x8_t x) { return __builtin_neon_splatq_lane_v(x, 1, 10

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. In D74619#1936336 , @pratlucas wrote: > Hi @leonardchan , > > I've double-checked the Neon intrinsics reference and it indeed confirms that > the only allowed value for the lane argument for `vdupq_lane_f64` is `0`: > > Argu

[PATCH] D76856: Fix TBAA for unsigned fixed-point types

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76856/new/ https://reviews.llvm.org/D76856

[PATCH] D74324: Tools emit the bug report URL on crash

leonardchan added a comment. Hi. This patch seems to cause the undefined symbol error we're seeing when linking clang: FAILED: bin/clang-11 : && /b/s/w/ir/k/cipd/bin/clang++ --sysroot=/b/s/w/ir/k/cipd/linux-amd64 -I/b/s/w/ir/k/recipe_cleanup/clangzmv99P/zlib_install/include -fPIC -fvisib

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan added a comment. In D76389#1951135 , @arsenm wrote: > Commit message should say only if? Updated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 ___

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > ebevhan wr

[PATCH] D69876: Support output constraints on "asm goto"

leonardchan added a comment. *Bump* We're also seeing the same test fail on our aarch64 bots: https://luci-milo.appspot.com/p/fuchsia/builders/ci/clang-linux-arm64/b8887516314819686496?blamelist=1#blamelist-tab FAIL: Clang :: Analysis/uninit-asm-goto.cpp (837 of 17008) T

[PATCH] D69876: Support output constraints on "asm goto"

leonardchan added a comment. Woops, sorry. Didn't see you sent out https://reviews.llvm.org/rGe11f9fb4508534d31b09d2ba6cd22428ccc75f65. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 ___

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Hi again, I think e058667a2e017d3225a9bb067dbac7f2159576f7 might've broken our toolchain again: FAIL: Clang :: Driver/riscv32-toolchain-extra.c (5723 of 17018) TEST 'Clang

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Unsure if my reply was sent over email so copying it here. Yup, adding `// REQUIRES: platform-linker` to both `*-extra.c` files seems to fix it. Thanks. Will you be sending out the fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. Submitted fixes in d2cbaf1755ffa90300365c0d71400a5ee4ada3bd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74704/new/ https://reviews.llvm.org/D74704

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

leonardchan added a comment. Hi. I have a suspicion this patch is causing a segfault for us when building zircon: https://ci.chromium.org/p/fuchsia/builders/ci/fuchsia-x64-debug-clang/b8897388724384628544 I'm almost done with a bisect and will provide a reproducer if this is the case. Just rai

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

leonardchan added a comment. Yup, a bisect shows it was this patch that caused it. I filed a bug for tracking at https://bugs.llvm.org/show_bug.cgi?id=43950 and attached a reproducer. Could you look into this? Thanks. Comment at: clang/lib/Sema/SemaExpr.cpp:487 +const Lan

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

This revision was automatically updated to reflect the committed changes. Closed by commit rGe278c138a937: [Sema] Add MacroQualified case for FunctionTypeUnwrapper (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ h

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

leonardchan added a comment. Hi. I think this patch is causing some test failures for us: FAIL: Clang :: Driver/riscv64-toolchain.c (5479 of 16161) TEST 'Clang :: Driver/riscv64-toolchain.c' FAILED Script: -- : 'RUN: at line 3'; /b/s/w/ir/k/

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

leonardchan added a comment. Hi! I think this patch might be causing some test failures on our mac bots: FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220) TEST 'Clang :: InterfaceStubs/merge-conflict-test.c' FAILED Script: --

[PATCH] D70576: [Clang] Always set -z now linker option on Fuchsia

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. But just to confirm, did you test this on CQ/bots by adding `["now", "-z"]` as linker flags to the `config("compiler")` in Fuchsia + Zircon? Repository: rG LLVM Github Monor

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

leonardchan added a comment. Could you add a test to show that with a fuchsia target we end up returning `this` from constructors + destructors and ensure that this ABI is used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70575/new/ https://revi

[PATCH] D70919: [Hexagon] Avoid passing unsupported options to lld when -fuse-ld=lld is used

leonardchan added a comment. Hi! This seems to be causing some test failures on our bots: https://ci.chromium.org/p/fuchsia/builders/ci/clang-linux-x64/b8893521019883752048 : 'RUN: at line 553'; /b/s/w/ir/k/recipe_cleanup/clangciZYdn/llvm_build_dir/bin/clang -### -target hexagon-unknown-el

[PATCH] D75890: [libunwind] Add flag to disable logging

leonardchan created this revision. leonardchan added a reviewer: phosek. Herald added subscribers: libcxx-commits, cfe-commits, mgorny. Herald added projects: clang, libc++. We were seeing non-deterministic binary size differences depending on which toolchain was used to build fuchsia. This is be

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

leonardchan updated this revision to Diff 249468. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/new/ https://reviews.llvm.org/D75890 Files: libunwind/src/config.h Index: libunwind/src/config.h ==

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

leonardchan added a comment. In D75890#1915493 , @thakis wrote: > `__FILE__` only expands to an absolute path if you pass an absolute path to > clang (ctrl-f "__FILE__" on > http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html). > >

[PATCH] D75890: [libunwind] Remove __FILE__ and __LINE__ from error reporting

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c70dec18c7e: [libunwind] Remove __FILE__ and __LINE__ from error reporting (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75890/ne

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass if the target has divergent branches

leonardchan created this revision. leonardchan added reviewers: chandlerc, arsenm, nhaehnle. leonardchan added a project: LLVM. Herald added subscribers: cfe-commits, dexonsmith, steven_wu, hiraditya, wdng. Herald added a project: clang. The `SpeculativeExecutionPass` was running under the new PM

[PATCH] D76416: [ASan] Apply -ffile-prefix-map mappings to ASan instrumentation

leonardchan updated this revision to Diff 251289. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76416/new/ https://reviews.llvm.org/D76416 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/ModuleBuilder.cpp clang/lib/CodeGen/

[PATCH] D76416: [ASan] Apply -ffile-prefix-map mappings to ASan instrumentation

leonardchan created this revision. leonardchan added reviewers: phosek, rnk, MaskRay, Lekensteyn, rsmith, echristo. leonardchan added a project: LLVM. Herald added subscribers: cfe-commits, ormris, hiraditya. Herald added a project: clang. leonardchan updated this revision to Diff 251289. Some asa

[PATCH] D76416: [ASan] Apply -ffile-prefix-map mappings to ASan instrumentation

leonardchan updated this revision to Diff 251421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76416/new/ https://reviews.llvm.org/D76416 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/ModuleBuilder.cpp clang/lib/CodeGen/

[PATCH] D76416: [WIP][ASan] Apply -ffile-prefix-map mappings to ASan instrumentation

leonardchan added a subscriber: mcgrathr. leonardchan added a comment. Putting this on hold for now. Although this implementation works for ASan, it would be have to be repeated for other tools like SourceBasedCoverage or other sanitizers. After discussing with @phosek and @mcgrathr, a more gen

[PATCH] D74704: Support -fuse-ld=lld for riscv

leonardchan added a comment. In D74704#1881012 , @vvereschaka wrote: > Hello @serge-sans-paille, > > looks like these changes broke the ARM builders: > http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749 > http://lab.llvm.org:8011/build

[PATCH] D73188: [AST] Improve overflow diagnostics for fixed-point constant evaluation.

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Could you also add a few test lines showing this warning doesn't appear for operations where the result is a saturated type? Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > > > > If the maximum

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a subscriber: reames. leonardchan added a comment. @reames let's continue the discussion here. What specific bits with the optimizer does this break? I'm not too familiar with SVEC. Prior to this, one thing I tried was instead just doing `Ops.push_back(GA)` and `getSCEV(GA)` bu

[PATCH] D139589: [clang][Fuchsia] Re-enable hwasan global instrumentation on hwasan multilibs

leonardchan abandoned this revision. leonardchan added a comment. This was landed in https://reviews.llvm.org/rG4308166403b4c28b6db7094a4e202e42da6e28a8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139589/new/ https://reviews.llvm.org/D139589 __

[PATCH] D144291: [clang-format-diff] Correctly parse start-of-file diffs

This revision was automatically updated to reflect the committed changes. Closed by commit rG50563944ab96: [clang-format-diff] Correctly parse start-of-file diffs (authored by tamird, committed by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. Hi. I think this led to some test failures on our builder at https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8784708268307261009/overview: Script: -- : 'RUN: at line 4'; rm -rf /b/s/w/ir/x/w/staging/llvm_build/tools/clang/te

[PATCH] D147209: [clang][lit] Make LIT aware of env CLANG_CRASH_DIAGNOSTICS_DIR.

leonardchan added a comment. In D147209#4245229 , @fpetrogalli wrote: > In D147209#4244615 , @leonardchan > wrote: > >> Hi. I think this led to some test failures on our builder at >> https://luci-milo.appspot.

[PATCH] D132275: [clang] Create alloca to pass into static lambda

leonardchan added subscribers: jdoerfert, leonardchan. leonardchan added a comment. Hi. For an embedded device, prior to this patch, we used to be able to see a significant savings of 28kB when we enabled the attributor. But with this patch, we don't see these savings anymore when enabling the a

[PATCH] D143533: [clang] Allow gnu::aligned attribute to work with templated type alias declarations

leonardchan created this revision. leonardchan added reviewers: rsmith, rnk, echristo. leonardchan added a project: clang. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. leonardchan requested review of this revision. Prior to this, the following would fail: template

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan created this revision. leonardchan added reviewers: pcc, eugenis, vitalybuka. leonardchan added a project: Sanitizers. Herald added subscribers: Enna1, jeroen.dobbelaere, hiraditya. Herald added a project: All. leonardchan requested review of this revision. Herald added projects: clang,

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan added a comment. Lemme know if the clang regression test isn't necessary or should be in its own commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 __

[PATCH] D144035: [hwasan] Ensure hwasan aliases do not have ODR linkage

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D144035: [hwasan] Ensure SCEV does not replace aliases with their aliasees

leonardchan updated this revision to Diff 499349. leonardchan retitled this revision from "[hwasan] Ensure hwasan aliases do not have ODR linkage" to "[hwasan] Ensure SCEV does not replace aliases with their aliasees". leonardchan edited the summary of this revision. Repository: rG LLVM Github

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. In D144035#4143030 , @pcc wrote: > Passes shouldn't be replacing aliases with aliasees in general, see D66606 > . The right fix is to fix SCEV to not do > that. Updated Repository: rG LL

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan updated this revision to Diff 499668. leonardchan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 Files: llvm/lib/Analysis/ScalarEvolution.cpp llvm/test/Ana

[PATCH] D144035: [llvm] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. In D144035#4145662 , @MaskRay wrote: >> Full context at https://github.com/llvm/llvm-project/issues/60668. > > Best to leave a simplified description in the summary so that a reader > doesn't have to go to the external link a

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

leonardchan added a comment. @pcc does this lgty? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035/new/ https://reviews.llvm.org/D144035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D144035: [SCEV] Ensure SCEV does not replace aliases with their aliasees

This revision was automatically updated to reflect the committed changes. Closed by commit rG608ee703e530: [SCEV] Ensure SCEV does not replace aliases with their aliasees (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144035

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. Herald added a project: All. leonardchan requested review of this revision. Herald added a subscriber: MaskRay. For programs that don't use RTTI, the rtti component is just replace

[PATCH] D152405: [WIP][clang] Add experimental option to omit the RTTI component from the vtable when -fno-rtti is used

leonardchan added a comment. In D152405#4404596 , @mcgrathr wrote: > It's not clear from the change description if this can be enabled > orthogonally to relative-vtables. I think it should be possible to choose > each switch independently, thus generati

<    3   4   5   6   7   8   9   >