leonardchan added a comment. In D152405#4645719 <https://reviews.llvm.org/D152405#4645719>, @dyung wrote:
> Hi @leonardchan your change was still causing a failure on the PS4 linux bot, > so I reverted it in 070493ddbd9473499d6f00ca62bc6aa92808ed79 > <https://reviews.llvm.org/rG070493ddbd9473499d6f00ca62bc6aa92808ed79>. I > noticed earlier that the failing test omit-rtti-component-without-no-rtti.cpp > was failing on both the linux and Windows PS bots, and I don't think it is > because it was on Windows, but rather, these bots use PS4 and PS5 as the > default targets, on which rtti is not enabled by default. The run command on > line 4 in your test tests the "default" behavior which on most platforms > seems to have rtti enabled by default. If I remove that line, the test then > passes on both of the PS targets. To reland the change, you might want to > consider removing that line as it makes an assumption which does not seem to > be true for all targets. Ahh. Thanks for the revert and the info. I'll reland with that removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152405/new/ https://reviews.llvm.org/D152405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
