leonardchan added a comment. In D135713#3850730 <https://reviews.llvm.org/D135713#3850730>, @mcgrathr wrote:
> I had imagined making lsan always do this since there's a specific > lsan-related rationale for it that applies to everybody. > I'm not clear on how cmake structures things and whether sanitizer_common > would have to do it unconditionally since it's used by lsan code. > > Doing this generally seems fine to me, but in the general case it's > considered a bug-masking feature (with =zero) and we should contemplate how > much we want to expect that compiler-rt might have bugs that we will be > making it harder for us to notice and properly fix. Oh I see. Yeah I had just been thinking of turning it on for us rather than for all of lsan for everyone. Is something like https://reviews.llvm.org/D135716 what you were thinking? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135713/new/ https://reviews.llvm.org/D135713 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
