[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 182092. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1359135 , @rjmccall wrote: > I think that's the right direction, yeah. > > I thought I told you it was fine to commit this patch under that assumption > awhile ago. Did I just never click "accept"? Whoops. I don't

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

This revision was automatically updated to reflect the committed changes. Closed by commit rL351364: [Fixed Point Arithmetic] Fixed Point Addition (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53738?vs=17686

[PATCH] D56746: [Fixed Point Arithmetic] Add APFixedPoint to APValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC351368: [Fixed Point Arithmetic] Add APFixedPoint to APValue (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D56746?vs=181918&id=182103#toc Repository: rC

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451 + case BO_Comma: +llvm_unreachable("Found unimplemented fixed point binary operation"); } rjmccall wrote: > Please create a separate case for the non-arithmetic operato

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

leonardchan updated this revision to Diff 182108. leonardchan marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55844/new/ https://reviews.llvm.org/D55844 Files: clang/lib/CodeGen/CGExprScalar.cpp clang/test/Frontend/fixed_point_s

[PATCH] D55844: [Fixed Point Arithmetic] Fixed Point Subtraction

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL351371: [Fixed Point Arithmetic] Fixed Point Subtraction (authored by leonardchan, committed by ). Herald added a subscrib

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan created this revision. leonardchan added reviewers: rjmccall, ebevhan, bjope. leonardchan added a project: clang. This patch includes the necessary code for converting between a fixed point type and integer. This also includes constant expression evaluation for conversions with these

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182456. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/include/clang/Basic/FixedPoint.h clang/lib/AST/Expr.cpp clang

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rC351593: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D55868?vs=181897&id=18259

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182717. leonardchan marked 6 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/include/clang/Basic

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:9825 +if (Result.isSigned() && !DstSigned) { + Overflow = Result < 0 || Result.ugt(DstMax); +} else if (Result.isUnsigned() && DstSigned) { ebevhan wrote: > The `Result < 0

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added a comment. @rsmith Any comments on this patch before submitting? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 182945. leonardchan marked 6 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/include/clang/Basic

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

This revision was automatically updated to reflect the committed changes. Closed by commit rL351997: [Sema] Fix Modified Type in address_space AttributedType (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D554

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 183242. leonardchan added a comment. - Rebase after D55447 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTCo

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:958-964 + // Remove the address_space qualifier so it does not get printed. We + // instead want to print the macro only. + SplitQualType Spli

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added a comment. Oh I forgot to submit the comments. Comment at: clang/lib/AST/ExprConstant.cpp:9825 +if (Result.isSigned() && !DstSigned) { + Overflow = Result < 0 || Result.ugt(DstMax); +} else if (Result.isUnsigned() && DstSigned) {

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan created this revision. leonardchan added reviewers: rjmccall, bjope, ebevhan. leonardchan added a project: clang. leonardchan added a parent revision: D46917: [Fixed Point Arithmetic] Comparison and Unary Operations for Fixed Point Types. This patch implements fixed point comparisons

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:437 + // DEFAULT-NEXT: [[RES:%[a-z0-9]+]] = trunc i39 [[SATMIN]] to i16 + // DEFAULT-NEXT: store i16 [[RES]], i16* %sat_sa, align 2 + -

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:141 + (RHSType->isFixedPointType() && + LHSType->isFixedPointOrIntegerType()); +} ebevhan wrote: > Can't it just be `LHSType->isFixedPointType() || RHST

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 183629. leonardchan marked 4 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan updated this revision to Diff 183980. leonardchan marked 2 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57219/new/ https://reviews.llvm.org/D57219 Files: clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D57219: [Fixed Point Arithmetic] Fixed Point Comparisons

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_comparisons.c:56 + +void TestComparisons() { + short _Accum sa; ebevhan wrote: > leonardchan wrote: > > ebevhan wrote: > > > Missing saturating and saturating/non-saturating compariso

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 184439. leonardchan marked 15 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Recurs

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: clang/lib/AST/Type.cpp:382-386 +QualType QualType::IgnoreMacroDefinitions(QualType T) { + while (const auto *MDT = T->getAs()) +T = MDT->getUnderlyingType(); + return T; +} rsmith wrote: > This doesn't seem lik

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Parse/ParseStmt.cpp:102-104 + Actions.PushExpressionEvaluationContext( + Actions.ExprEvalContexts.back().Context); ParenBraceBracketBalancer BalancerRAIIObj(*this); -

[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

leonardchan created this revision. leonardchan added reviewers: rsmith, aaron.ballman. leonardchan added a project: clang. leonardchan added a dependent revision: D49511: [Sema/Attribute] Check for noderef attribute. leonardchan removed a dependent revision: D49511: [Sema/Attribute] Check for nod

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added inline comments. Comment at: lib/Parse/ParseStmt.cpp:102-104 + Actions.PushExpressionEvaluationContext( + Actions.ExprEvalContexts.back().Context); ParenBraceBracketBalancer BalancerRAIIObj(*this); leonardchan wrote: > rsmith wrote: > >

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 172695. leonardchan marked 5 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D49511 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Basic/DiagnosticGroups.td clang/includ

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 173090. leonardchan marked an inline comment as done. leonardchan added a comment. Herald added a subscriber: arphaman. - Added a new type sugar node `MacroDefinedType` which wraps `AttributedType`s for the purpose of determining if an attribute was defin

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: lib/Sema/SemaType.cpp:5817-5822 + IdentifierInfo *AddressSpaceMacroII = nullptr; + auto FoundMacro = S.PP.AddressSpaceMacros.find( + S.SourceMgr.getSpellingLoc(Attr.getLoc())); + if (FoundMacro != S.PP.Address

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:958-964 + // Remove the address_space qualifier so it does not get printed. We + // instead want to print the macro only. + SplitQualType SplitTy = AttrTy->getModifiedType().split(); +

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 173961. leonardchan marked 11 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTContext.cpp clang/lib/Basic/FixedPoi

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. Sorry for the delay in responding to this. Been working on a few other patches. A couple of the bigger changes so far: - Added `getCommonSemantics` to `FixedPointSemantics` for finding a common full precision semantic. - `getFixedPointSemantics` accepts an int type.

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. For the integer conversion though, I was going to add that in a separate fixed-point-to-int and int-to-fixed-point patch. Repository: rC Clang https://reviews.llvm.org/D53738 ___ cfe-commits mailing list cfe-commits@

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174080. leonardchan marked 5 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTContex

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:129 + std::max(NonFractBits, OtherNonFractBits) + CommonScale; + + bool ResultIsSigned = isSigned() || Other.isSigned(); ebevhan wrote: > Does this properly compensate for types o

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In https://reviews.llvm.org/D53738#1299557, @ebevhan wrote: > I'd be interested in seeing tests for two saturating unsigned _Fract with and > without padding. > > If the padding case emits a uadd_sat, that seems wrong; uadd_sat doesn't > saturate on the padding bit,

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174235. leonardchan marked 13 inline comments as done. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTConte

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174279. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTContext.cpp clang/lib/Basic/FixedPoint.cpp clang

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. > Good case to bring up. For addition, I think we just need to add an extra > condition that checks for unsigned padding in the result. Added this test > also. Actually this was wrong. Updated and instead dictate how the appropriate number of bits to `getCommonSema

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_add.c:269 + // UNSIGNED-NEXT: [[SUM:%[0-9]+]] = call i15 @llvm.uadd.sat.i15(i15 [[USA_TRUNC]], i15 [[USA_SAT_TRUNC]]) + // UNSIGNED-NEXT: [[SUM_EXT:%[a-z0-9]+]] = zext i15 [[SUM]] to i16 + // UNSIG

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 174640. leonardchan marked an inline comment as done. Repository: rC Clang https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ASTContex

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. @ebevhan Any more comments on this patch? Repository: rC Clang https://reviews.llvm.org/D53738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added a comment. > Generally I think it's good! One final note; I assume we could technically > reuse/rename the EmitFixedPointAdd function and use it to emit other binops > when those are added? Yes, but I imagine if we choose to keep t

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added a comment. In D53738#1309171 , @ebevhan wrote: > In D53738#1308314 , @leonardchan > wrote: > > > > Generally I think it's good! One final note; I assu

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. > It's certainly interesting to degenerate integer-with-fixedpoint to just a > mul (since the scaling factor is 2^-n * 2^0, which is just 2^-n), but in the > general case you can't avoid doing the scale alignment. Unless I'm missing > something. No you're right. So

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/include/clang/Basic/FixedPoint.h:67 + FixedPointSemantics + getCommonSemantics(const FixedPointSemantics &Other) const; + rjmccall wrote: > Actually representing the fully-precise value is operation-specific;

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 175965. leonardchan marked 14 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53738/new/ https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 176204. leonardchan marked 6 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53738/new/ https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/include/clang/Basic/FixedPoint.h:67 + FixedPointSemantics + getCommonSemantics(const FixedPointSemantics &Other) const; + rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > Actually representing t

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + rjmccall wrote: > ebevhan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > rjmccall wrote: > > >

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > >

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan added a comment. *ping* @rsmith Any more comments on this patch or the one before it (https://reviews.llvm.org/D54014)? That one has the fix for pushing and popping another ExprEvalContext before acting on a function body in this patch. Repository: rC Clang CHANGES SINCE LAST AC

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + rjmccall wrote: > leonardchan wrote: > > rjmccall wrote: > > > leonardchan wrote: > > > > rjmccall wrote: >

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan updated this revision to Diff 176862. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53738/new/ https://reviews.llvm.org/D53738 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:1304 +RHSTy = ResultTy; + } + ebevhan wrote: > rjmccall wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > leonardchan wrote: > > > > > rjmccall wrote: > > > > > > leonardchan wr

[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

leonardchan updated this revision to Diff 176893. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54014/new/ https://reviews.llvm.org/D54014 Files: clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaDeclObjC.cpp clang/

[PATCH] D54014: [Sema] Push and Pop Expression Evaluation Context Records at the start and end of function definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rC348434: [Sema] Push and Pop Expression Evaluation Context Records at the start and end… (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D54014?vs=176893&id=17

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan updated this revision to Diff 176907. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49511/new/ https://reviews.llvm.org/D49511 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rC348442: [Sema/Attribute] Check for noderef attribute (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D49511?vs=176907&id=176908#toc Repository: rC Clang C

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan created this revision. leonardchan added reviewers: rsmith, aaron.ballman. leonardchan added a project: clang. This is a fix for https://reviews.llvm.org/D51229 where we pass the address_space qualified type as the modified type of an AttributedType. This change now instead wraps the

[PATCH] D51329: [Attribute/Diagnostics] Print macro instead of whole attribute for address_space

leonardchan updated this revision to Diff 177335. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/clang/AST/Type.

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177561. leonardchan marked an inline comment as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h clang/lib/AST/TypePrinter.cpp clan

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1320936 , @rjmccall wrote: > Okay, thanks, that makes sense to me. > > I'll ask around to find a way to contact the C committee. @rjmccall Any updates on this? If we aren't able to find a way to contact anyone affi

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added inline comments. Comment at: clang/test/Sema/address_space_attribute.cpp:9 + // CHECK: VarDecl {{.*}} x '__attribute__((address_space(1))) int *' + __attribute__((address_space(1))) int *x; + aaron.ballman wrote: > Can you also add a test usin

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177587. leonardchan marked 3 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/clang/Sema/Sema.h clang/lib/AST/TypePrinter.cpp clan

[PATCH] D53738: [Fixed Point Arithmetic] Fixed Point Addition

leonardchan added a comment. In D53738#1325998 , @rjmccall wrote: > We sent the question out, but we haven't gotten a response yet. I think > going forward under the idea that this just changes the type but does the > operation on the original operand t

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return MakeCXType(ATT->getModifiedType(), TU); ---

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan updated this revision to Diff 177620. leonardchan marked 2 inline comments as done. leonardchan added a comment. - Added the CXX11 test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55447/new/ https://reviews.llvm.org/D55447 Files: clang/include/cl

[PATCH] D55447: [Sema] Fix Modified Type in address_space AttributedType

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/tools/libclang/CXType.cpp:132 + if (!(TU->ParsingOptions & CXTranslationUnit_IncludeAttributedTypes) && + ATT->getAttrKind() != attr::AddressSpace) { return M

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188256. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h clang/include/clang/Bas

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan added a comment. In D58321#1407362 , @pcc wrote: > Can we start with a patch that just exposes a flag that enables the relative > ABI unconditionally, and remove all the platform ABI compatibility stuff? Done. Removed the checks requiring LT

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added a comment. @rjmccall @ebevhan @bjope *ping* any other comments on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 ___ cfe-commits mailing list cf

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188973. leonardchan added a comment. Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLVM. Update to current working version without needing LTO Repository: rG LLVM Githu

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188975. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/AST/VTableBuilder.h clang/include/clang/Bas

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 188987. leonardchan added a comment. - Remove `hasHiddenLTOVisibility` from `CXXRecordDecl` and rename the flag to `-frelative-c++-abi-vtables` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ http

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan updated this revision to Diff 189422. leonardchan marked 11 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 Files: clang/include/clang/AST/OperationKinds.def clang/inc

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added inline comments. Comment at: clang/test/Frontend/fixed_point_conversions.c:45 + +short _Accum sa_const9 = 2u; // DEFAULT-DAG: @sa_const9 = {{.*}}global i16 256, align 2 +unsigned short _Accum usa_const3 = 2; bjope wrote: > Perhaps we should ver

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC355462: [Fixed Point Arithmetic] Fixed Point and Integer Conversions (authored by leonardchan, committed by ). Changed pr

[PATCH] D58321: [WIP] Support for relative vtables

leonardchan updated this revision to Diff 196180. leonardchan added a subscriber: mcgrathr. leonardchan added a comment. Herald added a subscriber: hiraditya. Uploading my latest version of this patch and reporting some results. Will proceed with formatting and cleanup and ask for official review

[PATCH] D58321: Support for relative vtables

leonardchan updated this revision to Diff 197196. leonardchan marked an inline comment as done. leonardchan retitled this revision from "[WIP] Support for relative vtables" to "Support for relative vtables". leonardchan added a comment. Ok. Formally requesting for code reviews now. - Made the fl

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan updated this revision to Diff 197415. leonardchan marked 17 inline comments as done. leonardchan removed a reviewer: martong. Herald added a reviewer: martong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:257-262 + bool AttrStartIsInMacro = + (StartLoc.isMacroID() && Lexer::isAtStartOfMacroExpansion( + StartLoc, SrcMgr, PP.getLangOpts())); + bool At

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan updated this revision to Diff 197416. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan updated this revision to Diff 197454. leonardchan marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 Files: clang/include/clang/AST/ASTContext.h clang/include/cl

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:257-262 + bool AttrStartIsInMacro = + (StartLoc.isMacroID() && Lexer::isAtStartOfMacroExpansion( + StartLoc, SrcMgr, PP.getLangOpts())); + bool At

[PATCH] D58321: Support for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58321/new/ https://reviews.llvm.org/D58321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D51329/new/ https://reviews.llvm.org/D51329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added a comment. In D51329#1488465 , @rsmith wrote: > Thanks, looks great! > > I think the handling of the expansion location in the `MacroQualifiedTypeLoc` > isn't quite right yet (it looks like it will never actually be set at all, > becaus

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rC359826: [Attribute/Diagnostics] Print macro if definition is an attribute declaration (authored by leonardchan, committed by ). Changed prior to commit: https://reviews.llvm.org/D51329?vs=197454&id=1978

[PATCH] D51329: [Attribute/Diagnostics] Print macro if definition is an attribute declaration

leonardchan added a comment. In D51329#1488918 , @JDevlieghere wrote: > I think this is change is causing an assertion to be hit: > > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/25103/consoleFull#-239233992d489585b-5106-414a-ac11-3ff90657619c

[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

leonardchan marked 2 inline comments as done. leonardchan added inline comments. Comment at: lib/Sema/SemaType.cpp:4913-4916 +ExpectNoDerefChunk = false; + } + + ExpectNoDerefChunk = state.didParseNoDeref(); dblaikie wrote: > Pointed out in PR41

[PATCH] D61709: [NewPM] Port HWASan

leonardchan created this revision. leonardchan added reviewers: philip.pfaffe, fedor.sergeev, chandlerc, phosek. leonardchan added projects: LLVM, clang. Herald added subscribers: hiraditya, srhines. Port hardware assisted address sanitizer to new PM following the same guidelines as msan and tsan

[PATCH] D61709: [NewPM] Port HWASan and Kernel HWASan

leonardchan updated this revision to Diff 198889. leonardchan marked 2 inline comments as done. leonardchan retitled this revision from "[NewPM] Port HWASan" to "[NewPM] Port HWASan and Kernel HWASan". leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D52386: [Lexer] Add udefined_behavior_sanitizer feature

leonardchan created this revision. leonardchan added reviewers: phosek, kcc, echristo, vitalybuka, morehouse. leonardchan added a project: clang. This can be used to detect whether the code is being built with UBSan using the __has_feature(undefined_behavior_sanitizer) predicate. Repository:

[PATCH] D52386: [Lexer] Add udefined_behavior_sanitizer feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL342793: [Lexer] Add udefined_behavior_sanitizer feature (authored by leonardchan, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52386?vs=166

[PATCH] D52386: [Lexer] Add udefined_behavior_sanitizer feature

This revision was automatically updated to reflect the committed changes. Closed by commit rC342793: [Lexer] Add udefined_behavior_sanitizer feature (authored by leonardchan, committed by ). Repository: rL LLVM https://reviews.llvm.org/D52386 Files: include/clang/Basic/Features.def test/L

[PATCH] D52286: [Intrinsic] Signed Saturation Intirnsic

leonardchan updated this revision to Diff 166746. leonardchan added a comment. Herald added a subscriber: cfe-commits. - Removed passes since ssaturate can be expanded in the DAG Repository: rC Clang https://reviews.llvm.org/D52286 Files: include/llvm/CodeGen/ISDOpcodes.h include/llvm/IR

<    1   2   3   4   5   6   7   8   9   >