leonardchan added a comment.

> It's certainly interesting to degenerate integer-with-fixedpoint to just a 
> mul (since the scaling factor is 2^-n * 2^0, which is just 2^-n), but in the 
> general case you can't avoid doing the scale alignment. Unless I'm missing 
> something.

No you're right. Sorry, for some reason I kept only thinking about the 
saturation fixed point intrinsics and not the regular fixed point ones.

@rjmccall Any more comments on this patch? As soon as I get LGTM, I can reuse 
the functions here for subtraction and use the updated 
`UsualArithmeticConversions` for casing between fixed point types in other 
patches.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53738/new/

https://reviews.llvm.org/D53738



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to