leonardchan added a comment.

In D51329#1488465 <https://reviews.llvm.org/D51329#1488465>, @rsmith wrote:

> Thanks, looks great!
>
> I think the handling of the expansion location in the `MacroQualifiedTypeLoc` 
> isn't quite right yet (it looks like it will never actually be set at all, 
> because the code to set it is not reachable) but it's also unused at the 
> moment, so I'm happy with that being fixed as a follow-up change after you 
> land this.


Thanks! Will make another patch eventually with the followup changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D51329/new/

https://reviews.llvm.org/D51329



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to