leonardchan added inline comments.
================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3451
+ case BO_Comma:
+ llvm_unreachable("Found unimplemented fixed point binary operation");
}
----------------
rjmccall wrote:
> Please create a separate case for the non-arithmetic operators
> (pointer-to-member, assignment, comma) that will obviously never end up in
> this function.
>
> Otherwise, LGTM.
Done. Although this patch wasn't marked as ready to land, do you mean that I
can commit it still with the LGTM?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55844/new/
https://reviews.llvm.org/D55844
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
