[PATCH] D106528: [clangd] Improve performance of dex by 45-60%

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0987e350ccc: [clangd] Improve performance of dex by 45-60% (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106528/new/ https://review

[PATCH] D106645: [clangd] Tweak constructor of dex AndIterator for performance.

kbobyrev added a comment. I am extremely confused, but this is actually 4.5% slower than the updated (improved performance with D106528 ) baseline. Now, this actually works (2.2-2.5% faster): ❯ git diff diff --git a/clang-tools-extra/clangd/index/dex/Iterat

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev added a comment. Hi! Thanks for the patch, it makes sense to me! Honestly, I think having the `open` shadow is maybe not the best way to solve this (please feel free to let me know if there are reasons it would be better), maybe spell it out explicitly (there aren't that many cases of

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev added a comment. > For example, right now > clang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst > has non-ASCII quotes Also, hm... Do we really need these? It's safe to remove those, this shouldn't be a problem, I think. Repository: rG LLVM Github Monorepo

[PATCH] D107047: [clangd] Fix the crash in getQualification

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Happens when DestContext is Link

[PATCH] D107047: [clangd] Fix the crash in getQualification

kbobyrev updated this revision to Diff 362687. kbobyrev added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107047/new/ https://reviews.llvm.org/D107047 Files: clang-tools-extra/clangd/AST.cpp Index: clang-tools-extra

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev added a comment. Makes sense, thank you for the explanation. I've changed the problematic doc but this is probably still fine. Honestly, I don't really think we should have more Unicode symbols in the docs for generators hence this patch might not be needed but I'd be OK if you really

[PATCH] D107047: [clangd] Fix the crash in getQualification

kbobyrev updated this revision to Diff 362707. kbobyrev added a comment. Make the controol flow less confusing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107047/new/ https://reviews.llvm.org/D107047 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D106792: [clang-tidy] Always open files using UTF-8 encoding

kbobyrev requested changes to this revision. kbobyrev added a comment. This revision now requires changes to proceed. It's certainly doable but looks like a complete overkill for this kind of problem :) The patch is fine, I'm okay with landing it if you're expecting similar problem to arise in t

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

kbobyrev added a comment. Hi! I'm glad you're excited about IncludeCleaner and having a tool to try it out seems like a cool idea! > I'm not sure why include-cleaner wasn't integrated in clang-tidy, but I > suspect there's a good reason. The problem with IncludeCleaner as of right now is that

[PATCH] D121838: Generalize "check-all" umbrella targets, use for check-clang-tools

kbobyrev added a comment. LG to me with the comments that Haojian made! Comment at: llvm/cmake/modules/AddLLVM.cmake:1827 +# Convert a target name like check-clangd to a variable name like CLANG. +function(umbrella_lit_testsuite_var target outvar) hokein wrot

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Th

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 47. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-e

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 48. kbobyrev added a comment. Fix the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-extra/clangd/Config.h clang-tools-extra/cla

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev added a comment. In D123488#3444900 , @dsanders11 wrote: > Cool stuff! Chiming in randomly here, but I've been keeping a loose eye on > the progress of IncludeCleaner. > > I've been using IncludeCleaner to power include cleanup in the Chromium

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev added a comment. Oops, sorry, I linked the wrong revision; here's the prototype: we plan to start rolling it out gradually https://reviews.llvm.org/D122677 and then have a common library that we could share between both clangd and Clang-Tidy (and potentially other tools). Repository:

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

kbobyrev updated this revision to Diff 423601. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123488/new/ https://reviews.llvm.org/D123488 Files: clang-tools-e

[PATCH] D123488: [clangd] IncludeCleaner: Add filtering mechanism

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf0b757d593: [clangd] IncludeCleaner: Add filtering mechanism (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. Thanks, this looks good; just few nits regarding the comments. Comment at: clang/include/clang/Testing/TestAST.h:9 +// +// In normal operation of clang, the FrontendActio

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev updated this revision to Diff 424176. kbobyrev added a comment. Remove unused include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124166/new/ https://reviews.llvm.org/D124166 Files: clang-tools-extra/clangd/Headers.cpp clang-tools-

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev updated this revision to Diff 424189. kbobyrev added a comment. Use strlen for performance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124170/new/ https://reviews.llvm.org/D124170 Files: clang-tools-extra/clangd/Headers.cpp clang-t

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

kbobyrev updated this revision to Diff 424192. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124166/new/ https://reviews.llvm.org/D124166 Files: clang-too

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

kbobyrev updated this revision to Diff 424205. kbobyrev marked an inline comment as done. kbobyrev added a comment. Resolve comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124170/new/ https://reviews.llvm.org/D124170 Files: clang-tools-ex

[PATCH] D124166: [clangd] Correctly identify self-contained headers included rercursively

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1c0d2fb8272: [clangd] Correctly identify self-contained headers included rercursively (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D124170: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f05b111ee1f: [clangd] Include Cleaner: suppress unused warnings for IWYU pragma: export (authored by kbobyrev). Repository: rG LLVM Github Monore

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

kbobyrev updated this revision to Diff 405598. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118882/new/ https://reviews.llvm.org/D118882 Files: clang-

[PATCH] D118882: [clangd] IncludeCleaner: Decrease API dependency on clangd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG089d9c50b29e: [clangd] IncludeCleaner: Decrease API dependency on clangd (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D119116: [clangd] Pull AST printer helpers to Clang

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This will be ne

[PATCH] D119116: [clangd] Pull AST printer helpers to Clang

kbobyrev updated this revision to Diff 406367. kbobyrev added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119116/new/ https://reviews.llvm.org/D119116 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406401. kbobyrev added a comment. Move include-mapping generators to clang and re-generate the files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406741. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev added inline comments. Comment at: clang/include/clang/Tooling/Inclusions/StandardLibrary.h:37 + static llvm::Optional named(llvm::StringRef Scope, + llvm::StringRef Name); + kadircet wrote: > should scope have trail

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev added a comment. In D119130#3300780 , @kadircet wrote: > Regarding the include mapping generator, I think it would've been better if > we had some sort of list directly from libc++ (as this is now being part of > clang rather than just clangd),

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406793. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-too

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kbobyrev updated this revision to Diff 406794. kbobyrev added a comment. Add a comment for the helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406800. kbobyrev added a comment. Fix the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc clang-tools-extra

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. Oh, and also regarding the Python generator scripts: they don't seem to work with the latest archives :( 2018 mentioned in the docs (works perfectly) but 2019 crashes. Probably not very relevant if we switch to libc++ eventually. Repository: rG LLVM Github Monorepo

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 406827. kbobyrev added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130 Files: clang-tools-extra/clangd/CSymbolMap.inc clang-tools-extra/

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev updated this revision to Diff 407093. kbobyrev marked an inline comment as done. kbobyrev added a comment. Add a test for C Standard Library symbol. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119130/new/ https://reviews.llvm.org/D119130

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307222 , @sammccall wrote: > In D119130#3304505 , @kbobyrev > wrote: > >> Oh, and also regarding the Python generator scripts: they don't seem to work >> with the latest arc

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46a6f5ae148a: [clangd] NFC: Move stdlib headers handling to Clang (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D11913

[PATCH] D119130: [clangd] NFC: Move stdlib headers handling to Clang

kbobyrev added a comment. In D119130#3307333 , @paulwalker-arm wrote: > After this commit I am seeing the link time error > > ld.lld: error: undefined symbol: clang::DeclContext::isInlineNamespace() > const > >>> referenced by StandardLibrary.cpp:11

[PATCH] D118847: Added early exit for defaulted FunctionDecls. This prevents matching of defaulted comparison operators. fixes llvm#53355

kbobyrev added a comment. Mostly LG with few nits. I think it might be able to make it into the 14 release if we cherry-pick into the release branch. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) +

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:407 - if (F->getLocation().isInvalid()) + // operator<=> generates also the AST of e.g. operator==, which is implicit + if (F->getLocation().isInvalid() || F->i

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG, thanks! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type-cxx20.cpp:71 + template + requires(T{0}) // + friend conste

[PATCH] D118847: Added early exit for defaulted FunctionDecls.

kbobyrev added a comment. In D118847#3307497 , @Febbe wrote: > Can I still add a diff, or does this cause a revoke (apply the rest of the > feedback)? > Also, is the commit added automatically to the repo, or do I / another one > have to rebase it. > >

[PATCH] D119842: [clangd] NFC: Cleanup IncludeCleaner API

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Make a further improv

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); A ==

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/unittests/ConfigYAMLTests.cpp:259 + Fragment::parseYAML(YAML.code(), "config.yaml", Diags.callback()); + ASSERT_THAT(Diags.Diagnostics, IsEmpty()); + ASSERT_EQ(Results.size(), 1u); kbobyr

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kbobyrev added a comment. In D125088#3499649 , @nridge wrote: > Is there a related change that explains what this setting does? Yes: https://reviews.llvm.org/D123488 It seems that I forgot to add the YAML parser logic :( CHANGES SINCE LAST ACTION ht

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev created this revision. kbobyrev added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 428947. kbobyrev added a comment. Remove unwanted formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 428949. kbobyrev added a comment. Remove redundant comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp clang-too

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429618. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments: the structure is a bit different but the bug is now actually removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429619. kbobyrev added a comment. Also rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp clang-t

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429637. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40f361ace3e9: [clangd] Include Cleaner: ignore headers with IWYU export pragmas (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D125930: [clangd] WIP: Experimental support for "IWYU pragma: export"

kbobyrev created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github M

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

kbobyrev added a comment. For some reason, running this patch on a recent version of the source tree fails. The AST parsing fails with fatal diagnostics, but I can't understand why: E[15:14:33.084] source file unknown type name 'PathRef' is illformed: 1 E[15:15:02.831] source file unknown ty

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. In some cases the candidate ranges for rename final stage (textual replacements) are invalid and do not contain referenc

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kbobyrev updated this revision to Diff 235841. kbobyrev added a comment. Improve wording in the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72071/new/ https://reviews.llvm.org/D72071 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D72071: [clangd] Add correctness checks for index-based rename

kbobyrev added a comment. @sammccall `Indexed.size() > Lexed.size()` is one of the assumptions that I think might not hold in real-world scenarios. I was reading patch heuristics code a lot and trying to understand whether anything breaks when this check is not in place, but I couldn't come up

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev edited the summary of this revision. kbobyrev added a comment. I'm not sure if leaving both `Refe

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added a comment. I'm not sure if leaving both `ReferenceLoc`s pointing to the same location is a sensible solution, but merging them seems quite complicated and probably not really worth the effort. I've considered multiple alternative solutions, as described in https://github.com/clan

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev added a subscriber: hokein. This patch allows the index does to provide a way to distinguish implicit referen

[PATCH] D72638: [clangd] Fix rename for explicit destructor calls

kbobyrev added a comment. Changed reviewer to @kadircet because Sam would be out until the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72638/new/ https://reviews.llvm.org/D72638 ___

[PATCH] D72746: [clangd] Add a flag for implicit references in the Index

kbobyrev added a comment. The patch could be shorter and slightly less confusing if I preserved 1:1 `RefKind::Implicit` <-> `index::SymbolKind::Implicit` relation, but I thought we might want to keep `RefKind` being 1 byte so that we don't waste unnecessary memory. Also, since we might want to

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291508. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang-to

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:226 + llvm::sys::TimePoint<> LastModificationTime = + std::chrono::system_clock::now(); + for (;; std::this_thread::sleep_for(std::chrono::seconds(90))) { k

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291521. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address remaining comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 291861. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address a round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clan

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, xazax.hun. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. The integration is already

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292130. kbobyrev marked 5 inline comments as done. kbobyrev added a comment. Address another round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files:

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kadi

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292131. kbobyrev added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87450 Files: clang-tools-extra/clangd/index/remote/server/Server.cpp Ind

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev updated this revision to Diff 292144. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Save last status to prevent redundant updates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87450/new/ https://reviews.llvm.org/D87

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:234 + LastStatus.getLastModificationTime(), Status->getLastModificationTime()); + std::unique_ptr NewIndex = loadIndex(IndexPath); + if (!NewIndex) { kadi

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

kbobyrev updated this revision to Diff 292149. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87686/new/ https://reviews.llvm.org/D87686 Files: clang-to

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a0a2a6347f5: [clangd] Implement hot index reloading for clangd-index-server (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D87686: [clang-tidy] Improve documentation on Clangd integration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa909a84ef2d9: [clang-tidy] Improve documentation on Clangd integration (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D87831 Files: clang-tools-extra/clangd/Semant

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.h:99 +PPKeywordKind getPPKeywordFromSpelling(const std::string &Name); + riccibruno wrote: > A string is expensive here and unneeded. Why not a `StringRef`? Yeah, this piece is unf

[PATCH] D87831: [clang] Expose helper function to turn PP keywords spelling into PPKeywordKind

kbobyrev updated this revision to Diff 294614. kbobyrev marked an inline comment as not done. kbobyrev added a comment. Update the patch. Still WIP, stash progress. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87831/new/ https://reviews.llvm.org/D

[PATCH] D86604: [clangd] Use string[] for allCommitCharacters

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. As per LSP specification

[PATCH] D86604: [clangd] Use string[] for allCommitCharacters

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d11e6789c47: [clangd] Use string[] for allCommitCharacters (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86604/new/ https://reviews

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev updated this revision to Diff 290256. kbobyrev added a comment. "Fail" early. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85426/new/ https://reviews.llvm.org/D85426 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp Index: cl

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev updated this revision to Diff 290453. kbobyrev added a comment. Also check if deinition comes from unwwanted file (e.g. omit forward declarations). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85426/new/ https://reviews.llvm.org/D85426

[PATCH] D85426: [clangd] Implement FileFilter for the indexer

kbobyrev planned changes to this revision. kbobyrev added a comment. WIP. Need to get around background indexing tricks to make it work. Failed Tests (3): Clangd Unit Tests :: ./ClangdTests/BackgroundIndexTest.Config Clangd Unit Tests :: ./ClangdTests/BackgroundIndexTest.IndexTwoFiles

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch adds a mechanism to load

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev updated this revision to Diff 310232. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Resolve review comments. @sammccall, thanks for clarifying the cases you thought should be remaining as they are! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310357. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-to

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to check this patch again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 ___ cfe-commi

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 ___ cfe-comm

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:114 assert(!ProjectRoot.empty()); +ChannelStatusWatcher = std::thread([&Channel]() { + grpc_connectivity_state Status = sammccall wrote: > The thread is a b

[PATCH] D92198: [clangd] Log remote index connectivity status

kbobyrev updated this revision to Diff 310381. kbobyrev marked 3 inline comments as done. kbobyrev added a comment. Resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92198/new/ https://reviews.llvm.org/D92198 Files: clang-tools

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310614. kbobyrev added a comment. Rebase on top of master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-tools-extra/clangd/index/remote/Client.cpp

[PATCH] D92181: [clangd] NFC: Add client-side logging for remote index requests

kbobyrev updated this revision to Diff 310616. kbobyrev added a comment. Change logging format to be consistent with another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92181/new/ https://reviews.llvm.org/D92181 Files: clang-tools-extra

<    3   4   5   6   7   8   9   10   11   12   >