kbobyrev added a comment. @sammccall `Indexed.size() > Lexed.size()` is one of the assumptions that I think might not hold in real-world scenarios. I was reading patch heuristics code a lot and trying to understand whether anything breaks when this check is not in place, but I couldn't come up with some cases, so I thought it'd be OK to remove it.
I have written down some thoughts on the topic in the issue I opened on GitHub: https://github.com/clangd/clangd/issues/238 We have briefly discussed range patching heuristics in D71598 <https://reviews.llvm.org/D71598>, @kadircet has more context if you are interested. I'd be happy to discuss more details once I'm back, let me know if you have any thoughts/comments on the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72071/new/ https://reviews.llvm.org/D72071 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
