kbobyrev added a comment.

The patch could be shorter and slightly less confusing if I preserved 1:1 
`RefKind::Implicit` <-> `index::SymbolKind::Implicit` relation, but I thought 
we might want to keep `RefKind` being 1 byte so that we don't waste unnecessary 
memory. Also, since we might want to start using `findExplicitReferences` (or 
something else we come up with) for indexing, it shouldn't be critical. Let me 
know if you think it's unnecessary.
+CC @hokein


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72746/new/

https://reviews.llvm.org/D72746



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to