kbobyrev added a comment. LG to me with the comments that Haojian made!
================ Comment at: llvm/cmake/modules/AddLLVM.cmake:1827 +# Convert a target name like check-clangd to a variable name like CLANG. +function(umbrella_lit_testsuite_var target outvar) ---------------- hokein wrote: > if I read the code correctly, input `check-clangd` the output is CLANGD, not > CLANG. Also, maybe the other way around (-> `check-clang`) since it's a generic LLVM CMake module, not everyone here knows what clangd is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121838/new/ https://reviews.llvm.org/D121838 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
