[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet updated this revision to Diff 198630. kadircet marked 23 inline comments as done. kadircet added a comment. - Address comments - Make little modifications to existing tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61497/new/ https://r

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:574 - // We want to include the template in the Hover. - if (TemplateDecl *TD = D->getDescribedTemplate()) -D = TD; +llvm::raw_ostream &operator<<(llvm::raw_ostream &OS, +

[PATCH] D61497: [clangd] Introduce a structured hover response

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:539 -/// Generate a \p Hover object given the declaration \p D. -static Hover getHoverContents(const Decl *D) { - Hover H; - llvm::Optional NamedScope = g

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet updated this revision to Diff 198770. kadircet marked 7 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59481/new/ https://reviews.llvm.org/D59481 Files: clang-tools-ex

[PATCH] D60827: [rename] Deduplicate symbol occurrences

kadircet requested changes to this revision. kadircet added a comment. This revision now requires changes to proceed. Note that the bug has been fixed with D61596 incidentally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D61724: [clangd] Use AsyncTaskRunner in BackgroundIndex instead of std::thread

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/Background.cpp:152 + for (unsigned I = 1; I <= ThreadPoolSize; ++I) { +ThreadPool.runAsync("background-worker-" + llv

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

kadircet updated this revision to Diff 198816. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59481/new/ https://reviews.llvm.org/D59481 Files: clang-tools-ex

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360344: [clangd] Count number of references while merging RefSlabs inside FileIndex (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59481?vs=198816&id=198818#

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. Herald added a project: clang. After rL360344 , BackgroundIndex expects symbols with zero refcounts. Therefore existing i

[PATCH] D61734: [clangd] Bump index version and get rid of wrong assertion

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE360349: [clangd] Bump index version and get rid of wrong assertion (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D61734?vs=198825&id=198828#toc Repository:

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added a subscriber: cfe-commits. In clangd we had a new type of completion suggestions for cpp class/struct/unions that will show override signatures for virtual methods in base classes. This patch implements i

[PATCH] D52226: [clangd] Remove override result handling logic from clangd

kadircet created this revision. kadircet added reviewers: ioeric, ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay. kadircet added a dependency: D52225: [clang] Implement Override Suggestions in Sema.. Since we plan to move handling of override suggestions to Sema

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

kadircet updated this revision to Diff 166076. kadircet marked 14 inline comments as done. kadircet added a comment. - Delete include fixit option. - Rebase Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51214 Files: clangd/tool/ClangdMain.cpp Index: clangd/tool/ClangdMain.

[PATCH] D51214: [clangd] Add options to enable/disable fixits and function argument snippets.

kadircet added inline comments. Comment at: clangd/tool/ClangdMain.cpp:197 +static llvm::cl::opt IncludeFixIts( +"include-fixits", ilya-biryukov wrote: > sammccall wrote: > > ilya-biryukov wrote: > > > sammccall wrote: > > > > kadircet wrote: > > > > > ilya

[PATCH] D51214: [clangd] Add option to enable/disable function argument snippets.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE342533: [clangd] Add option to enable/disable function argument snippets. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D51214?vs=166076&id=166082#toc Repos

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D52301 Files: include/clang/AST/PrettyPrinter.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/T

[PATCH] D52422: [clangd] Handle template args for disabled function arg snippets

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/CodeComplete.cpp:507 + if (Snippet->front() == '<') +return EmptyArgs ? "<$0>()" : "<$1>($0)"; + if (Snippet->front() == '(') --

[PATCH] D52465: [clangd] Extract mapper logic from clangd-indexer into a library.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks for factoring out this to a library. Comment at: clangd/index/IndexAction.cpp:41 + llvm::errs() + << "Found uncompilable errors in the translat

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167071. kadircet added a comment. - Change order of fucntions for better diff. - Add tests. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/ove

[PATCH] D52226: [clangd] Remove override result handling logic from clangd

kadircet updated this revision to Diff 167075. kadircet added a comment. - Remove test, since it has been moved into Sema. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52226 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp =

[PATCH] D52517: [clangd] clangd-indexer: Drop support for MR-via-YAML

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D52544: Improve diagnostics range reporting.

kadircet created this revision. kadircet added reviewers: sammccall, ioeric. Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov. If we have some range information coming from clang diagnostic, promote that one even if it doesn't contain diagnostic location inside. Repository

[PATCH] D52547: Tell whether file/folder for include completions.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52547 Files: clangd/CodeComplete.cpp clangd/Protocol.h unittests/clangd/Code

[PATCH] D52544: Improve diagnostics range reporting.

kadircet added inline comments. Comment at: unittests/clangd/ClangdUnitTests.cpp:82 o]](); - foo()$semicolon[[]] + foo()$semicolon[[]]//with comments $unk[[unknown]](); ioeric wrote: > What is this `//with comments` for? Maybe explain it in the

[PATCH] D52544: Improve diagnostics range reporting.

kadircet updated this revision to Diff 167283. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52544 Files: clangd/Diagnostics.cpp unittests/clangd/ClangdUnitTests.cpp Index: unittests

[PATCH] D52544: Improve diagnostics range reporting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL343197: Improve diagnostics range reporting. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52544 Files: clang-tools-ex

[PATCH] D52547: Tell whether file/folder for include completions.

kadircet added a comment. In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote: > A drive-by comment. > Would it be cleaner to pass this information from clang? Relying on > completion label seems shaky. Actually I also wanted to do that at first, but then wasn't really sure wheth

[PATCH] D52547: Tell whether file/folder for include completions.

kadircet updated this revision to Diff 167320. kadircet marked 2 inline comments as done. kadircet added a comment. Preparing the patch to respect client capabilities. - Add other itemkinds as well. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52547 Files

[PATCH] D52547: Tell whether file/folder for include completions.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343221: Tell whether file/folder for include completions. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52547?vs=167320&id=167321#toc Repository: rCTE Cl

[PATCH] D52616: Introduce completionItemKind capability support.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52616 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Prot

[PATCH] D52616: Introduce completionItemKind capability support.

kadircet updated this revision to Diff 167332. kadircet added a comment. - Minimum CompletionItemKind is Text. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52616 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.cpp clangd/Protocol.h Index: c

[PATCH] D52616: Introduce completionItemKind capability support.

kadircet updated this revision to Diff 167346. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52616 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/Protocol.cpp cl

[PATCH] D52616: Introduce completionItemKind capability support.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343237: Introduce completionItemKind capability support. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52616?vs=167346&id=167347#toc Repository: rCTE Cla

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet added a comment. ping Repository: rC Clang https://reviews.llvm.org/D52225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167700. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletio

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1639 +llvm::raw_string_ostream OS(OverrideSignature); +CodeCompletionResult CCR(Method, 0); +PrintingPolicy Policy = ioeric wrote: > Could you add comments explainin

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167708. kadircet marked 4 inline comments as done. kadircet added a comment. - Fix a bug and address comments. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1639 +llvm::raw_string_ostream OS(OverrideSignature); +CodeCompletionResult CCR(Method, 0); +PrintingPolicy Policy = ioeric wrote: > kadircet wrote: > > ioeric wrote

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

kadircet updated this revision to Diff 167717. kadircet added a comment. - Add a fixme on limitation. Repository: rC Clang https://reviews.llvm.org/D52225 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/overrides.cpp Index: test/CodeC

[PATCH] D52301: [clang] Set TypeSourceInfo for vardecl's in addition to type when we can deduce.

kadircet updated this revision to Diff 167718. kadircet added a comment. rebase & ping Repository: rC Clang https://reviews.llvm.org/D52301 Files: include/clang/AST/PrettyPrinter.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/Sema.h lib/AST/TypePrinter.cpp lib/Fron

[PATCH] D52226: [clangd] Remove override result handling logic from clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343567: [clangd] Remove override result handling logic from clangd (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52226?vs=167075&id=167901#toc Repository:

[PATCH] D52225: [clang] Implement Override Suggestions in Sema.

This revision was automatically updated to reflect the committed changes. Closed by commit rC343568: [clang] Implement Override Suggestions in Sema. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52225?vs=167717&id=167902#toc Repository: rC Clang h

[PATCH] D52889: [clangd] Add new test to cover no_member diag.

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. kadircet edited the summary of this revision. kadircet added reviewers: sammccall, ilya-biryukov. kadircet added a dependency: D52890: Also report range for the name token on

[PATCH] D52890: Also report range for the name token on no_member error.

kadircet created this revision. kadircet added reviewers: sammccall, ilya-biryukov. Herald added subscribers: cfe-commits, ioeric. kadircet added a dependent revision: D52889: [clangd] Add new test to cover no_member diag.. [clang] Report range of the missing-memmber on no_member diagnostic. Curr

[PATCH] D53016: [clangd] Mark colon as a safe character when percent-encoding.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Also change output of percent-encoding to use upper-case letters. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53016

[PATCH] D52889: [clangd] Add new test to cover no_member diag.

kadircet updated this revision to Diff 168762. kadircet added a comment. - Revert to previous heuristic with special handling of empty fixit range. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52889 Files: clangd/Diagnostics.cpp unittests/clangd/ClangdUnitTests.cpp Inde

[PATCH] D52889: [clangd] Revert back to previous heuristic for diagnostic range extraction.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344025: [clangd] Revert back to previous heuristic for diagnostic range extraction. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D52889?vs=168762&id=168764#

[PATCH] D53016: [clangd] Mark colon as a safe character when percent-encoding.

This revision was automatically updated to reflect the committed changes. Closed by commit rL344033: [clangd] Mark colon as a safe character when percent-encoding. (authored by kadircet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D5301

[PATCH] D53016: [clangd] Mark colon as a safe character when percent-encoding.

kadircet updated this revision to Diff 168771. kadircet added a comment. - Add comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53016 Files: clangd/URI.cpp unittests/clangd/URITests.cpp Index: unittests/clangd/URITests.cpp =

[PATCH] D57507: [clang] Add getCommentHandler to PreambleCallbacks

kadircet updated this revision to Diff 184998. kadircet marked an inline comment as done. kadircet added a comment. Herald added a project: clang. - Update comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57507/new/ https://reviews.llvm.org/D57507 Files:

[PATCH] D57507: [clang] Add getCommentHandler to PreambleCallbacks

This revision was automatically updated to reflect the committed changes. Closed by commit rL353030: [clang] Add getCommentHandler to PreambleCallbacks (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

kadircet added inline comments. Comment at: clangd/ClangdUnit.cpp:100 + : File(File), ParsedCallback(ParsedCallback), +IWYUHandler(collectIWYUHeaderMaps(&CanonIncludes)) {} ioeric wrote: > Does this have to own the `IWYUHandler`? Could we create on

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

kadircet updated this revision to Diff 185030. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments. - Call addSystemHeaderMappings when we are building ast without preamble. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

kadircet marked an inline comment as done. kadircet added a comment. I don't think so, since the only reason this already wasn't enabled was because there was a fixme ? Also we want people to use -background-index by default in future so I think it should be OK Repository: rCTE Clang Tools E

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

kadircet updated this revision to Diff 185052. kadircet added a comment. - Delete unnecessary include Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57508/new/ https://reviews.llvm.org/D57508 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp

[PATCH] D57508: [clangd] Enable include insertion for dynamic index

This revision was automatically updated to reflect the committed changes. Closed by commit rL353054: [clangd] Enable include insertion for static index (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. clangd is using as many threads as logical cores for BackgroundIndex by default. Due to hyper-threading this causes ca

[PATCH] D57819: [clangd] Reduce number of threads used by BackgroundIndex to number of physical cores.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353422: [clangd] Reduce number of threads used by BackgroundIndex to number of physical… (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D57819?vs=185549&id=18

[PATCH] D57392: [clangd] Mention indexing in docs.

kadircet updated this revision to Diff 185777. kadircet marked 2 inline comments as done. kadircet added a comment. Address comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57392/new/ https://reviews.llvm.org/D57392 Files: docs/clangd.rst

[PATCH] D57392: [clangd] Mention indexing in docs.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353423: [clangd] Mention indexing in docs. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D57392?vs=185777&id=185781#toc Repository: rCTE Clang Tools Extra

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added a subscriber: sammccall. kadircet added a comment. Implementation LG, but I am not sure about adding a functionality on a proposal that might change. WDYT @sammccall ? Comment at: clang-tools-extra/clangd/FindSymbols.cpp:16 #include "SourceCode.h" +#include "XR

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

kadircet created this revision. kadircet added reviewers: hokein, akyrtzi. Herald added subscribers: cfe-commits, arphaman, ioeric, ilya-biryukov. Herald added a project: clang. Parameters in declarations are useful for clangd, so that we can provide symbol information for them as well. It also he

[PATCH] D57950: [clangd] Index parameters in function decls

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D57950 Files: clangd/XRefs.cpp unittests/

[PATCH] D57950: [clangd] Index parameters in function decls

kadircet planned changes to this revision. kadircet added a comment. Also enable `IndexParametersInDeclarations` in symbolcollector Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57950/new/ https://reviews.llvm.org/D57950 _

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

kadircet updated this revision to Diff 185962. kadircet added a comment. - Also delete comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57949/new/ https://reviews.llvm.org/D57949 Files: include/clang/Index/IndexingAction.h lib/Index/IndexDecl.cpp lib/

[PATCH] D57950: [clangd] Index parameters in function decls

kadircet updated this revision to Diff 185967. kadircet added a comment. This revision is now accepted and ready to land. Also index function params in findrefs Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57950/new/ https://reviews.llvm.org/D57950

[PATCH] D58029: [clangd] Make system header mappings available for PreambleParsedCallback

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. SystemHeaderMappings were added only after takeIncludes call, which resulted in getting mapping on main file

[PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:925 +CXXRD = VD->getType().getTypePtr()->getAsCXXRecordDecl(); + } else if (const CXXMethodDecl *Method = dyn_cast(D)) { +// If this is a method, use the type of the class. nr

[PATCH] D58029: [clangd] Make system header mappings available for PreambleParsedCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rL353687: [clangd] Make system header mappings available for PreambleParsedCallback (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

[PATCH] D57949: [clang][Index] Add a knob to index function parameters in declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rL353695: [clang][Index] Add a knob to index function parameters in declarations (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[PATCH] D57950: [clangd] Index parameters in function decls

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353696: [clangd] Index parameters in function decls (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D57950?vs=185967&id=186235#toc Repository: rCTE Clang To

[PATCH] D58126: [clangd] Fix a lit-test.

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=40593. Non-percent-encoded chars doesn't cause any problems on

[PATCH] D58133: [clangd] Testcase for bug 39811

kadircet created this revision. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58133 Files: unittests/clangd/XRefsTests.cpp Index: unittests/cl

[PATCH] D58126: [clangd] Fix a lit-test.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE353857: [clangd] Fix a lit-test. (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58126?vs=186475&id=186490#toc Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet created this revision. Herald added subscribers: cfe-commits, jdoerfert, arphaman. Herald added a project: clang. Indexing context was skipping explicit template instantiations as well. This patch makes sure it only skips implicit ones. Repository: rC Clang https://reviews.llvm.org/D

[PATCH] D58190: [clangd] Add tests for template specializations

kadircet created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58190 Files: unittests/clangd/XRefsTests.cpp Index: unittests/clangd/XRefsT

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet updated this revision to Diff 186995. kadircet marked 6 inline comments as done. kadircet added a comment. Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58189/new/ https://reviews.llvm.org/D58189 Files: lib/Index/IndexTypeSourceInfo.c

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet added inline comments. Comment at: unittests/Index/IndexTests.cpp:40 +Position P; +P.Line = static_cast(SM.getLineNumber(FID, Offset)) - 1; +P.Column = SM.getColumnNumber(FID, Offset) - 1; ilya-biryukov wrote: > Why do we need to `static_cast

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

kadircet updated this revision to Diff 187014. kadircet added a comment. - Get rid of redundant test Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58189/new/ https://reviews.llvm.org/D58189 Files: lib/Index/IndexTypeSourceInfo.cpp test/Index/Core/index-sourc

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet created this revision. kadircet added reviewers: ilya-biryukov, akyrtzi. Herald added subscribers: cfe-commits, arphaman, ioeric, kristof.beyls, javed.absar. Herald added a project: clang. clangd uses indexing api to provide references and it was not possible to perform symbol informatio

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Fixes https://bugs.llvm.org/show_bug.cgi?id=36285 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG but is this information really useful to users? According to LSP `The diagnostic's code, which might appear in the user interface.`, I think seeing this will be mostly noise for users.

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet created this revision. kadircet added reviewers: ilya-biryukov, akyrtzi. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Add indexing of UsingDecl itself. Also enable generation of USRs for UsingDecls, using the qualified name of the decl. Repository: r

[PATCH] D58341: [clangd] Index UsingDecls

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. D58340 enables indexing of USRs, this makes sure test in clangd

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 187208. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: lib/Index/IndexDecl.cpp lib

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187209. kadircet added a comment. - Update USR to include "UD" Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clangd/SymbolCollectorTests.cpp unit

[PATCH] D58190: [clangd] Add tests for template specializations

kadircet updated this revision to Diff 187213. kadircet added a comment. - Add more testcases Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58190/new/ https://reviews.llvm.org/D58190 Files: unittests/clangd/XRefsTests.cpp Index: unittests/clang

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL354262: [clang][Index] Fix usage of IndexImplicitInstantiation (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 187236. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: lib/Index/IndexDecl.cpp lib/Index/USRGeneration.cpp test/Index/usrs.

[PATCH] D58190: [clangd] Add tests for template specializations

kadircet updated this revision to Diff 187237. kadircet marked an inline comment as done. kadircet added a comment. - Fix typo and make comments start with 2 slashes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58190/new/ https://reviews.llvm.org/D

[PATCH] D58190: [clangd] Add tests for template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rL354272: [clangd] Add tests for template specializations (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet added a comment. Yeah you are right, no need to have those in the index. I thought we looked at only index for findreferences(which turned out to be wrong, we also traverse ast), therefore I had turned this functionality on for dynamic index. Repository: rCTE Clang Tools Extra CHAN

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187322. kadircet added a comment. - Turn off indexing of template type parms for dynamic index Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd/XRefs.cpp

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet added inline comments. Comment at: lib/Index/IndexingContext.cpp:51 + bool IndexingContext::handleDecl(const Decl *D, SymbolRoleSet Roles, ilya-biryukov wrote: > Do we call `handleDecl` for template parameters now too?

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187341. kadircet marked 2 inline comments as done. kadircet added a comment. - Fix handling of TemplateTemplateTypeParams Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: inc

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187342. kadircet added a comment. - Add handling for template template type parameters Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd/XRefs.cpp unitt

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187367. kadircet added a comment. - Add tests for code completion Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clangd/SymbolCollectorTests.cpp u

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet updated this revision to Diff 187370. kadircet marked 2 inline comments as done. kadircet added a comment. - Change options name - Also index decls Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58293/new/ https://reviews.llvm.org/D58293 Files: include

[PATCH] D58294: [clangd] Enable indexing of template type parameters

kadircet updated this revision to Diff 187371. kadircet marked an inline comment as done. kadircet added a comment. - Option's name has changed Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58294/new/ https://reviews.llvm.org/D58294 Files: clangd

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

kadircet added inline comments. Comment at: lib/Index/IndexingContext.cpp:51 + bool IndexingContext::handleDecl(const Decl *D, SymbolRoleSet Roles, ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > Do we call

<    1   2   3   4   5   6   7   8   9   10   >