kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LG but is this information really useful to users? According to LSP `The 
diagnostic's code, which might appear in the user interface.`, I think seeing 
this will be mostly noise for users.



================
Comment at: clangd/Diagnostics.cpp:39
+#include "clang/Basic/DiagnosticCommentKinds.inc"
+#include "clang/Basic/DiagnosticSemaKinds.inc"
+#include "clang/Basic/DiagnosticAnalysisKinds.inc"
----------------
I suppose `CrossTUKinds` is left out intentionally ?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58291/new/

https://reviews.llvm.org/D58291



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to