kadircet added inline comments.
================ Comment at: lib/Sema/SemaCodeComplete.cpp:1639 + llvm::raw_string_ostream OS(OverrideSignature); + CodeCompletionResult CCR(Method, 0); + PrintingPolicy Policy = ---------------- ioeric wrote: > Could you add comments explaining what the following code does? The original > code in clangd only has `Results.emplace_back(Method, 0);`, and it's > non-trivial what the new code here is for. Yeah you are right added some comments, previously this was handled on CodeCompletionBuilder in clangd which converted the completion item into a override declaration to be inserted. Repository: rC Clang https://reviews.llvm.org/D52225 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
