kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM, thanks for factoring out this to a library. ================ Comment at: clangd/index/IndexAction.cpp:41 + llvm::errs() + << "Found uncompilable errors in the translation unit. Igoring " + "collected symbols...\n"; ---------------- s/Igoring/Ignoring/ ================ Comment at: clangd/index/IndexAction.cpp:63 + index::IndexingOptions::SystemSymbolFilterKind::All; + IndexOpts.IndexFunctionLocals = false; + Opts.CollectIncludePath = true; ---------------- nit: this is false by default. ================ Comment at: clangd/index/IndexAction.h:24 +// - references are always counted +// - (all) references ane provided if RefsCallback is non-null +// - the symbol origin is always Static ---------------- s/ane/are/ What is RefsCallback? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
