[PATCH] D106535: [clangd] Use CommandMangler in TestTU

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-tools-extra. This makes testing setup

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mo

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet updated this revision to Diff 360835. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ https://reviews.llvm.org/D106527 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, mgrang. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Depends on D106527

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet updated this revision to Diff 361132. kadircet added a comment. - Also get rid of the insertion adjuster Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org/D106562 Files: clang-tools-extra/clangd/CompileC

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet updated this revision to Diff 361133. kadircet marked 3 inline comments as done. kadircet added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ https://reviews.llvm.org/D106527 Files: clang

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:210 + if (!ArgList.hasArgNoClaim(driver::options::OPT__DASH_DASH)) { +// In theory there might be more than one input, but clangd can't deal wi

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

kadircet updated this revision to Diff 361135. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106639/new/ https://reviews.llvm.org/D106639 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-tools-extra/

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! it is unfortunate that history won't remember what an adventure it was to figure out the issue :D Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.

[PATCH] D106654: [clangd] Avoid range-loop init-list lifetime subtleties.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:288 }; - for (const auto &Entry : {CDBFile{&CompileCommandsJson, parseJSON}, -CDBFile{&BuildCompileCommandsJson, parseJSON}, -

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet updated this revision to Diff 361182. kadircet marked an inline comment as done. kadircet added a comment. Use move_iterator instead of inserting in a loop. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225 +auto It = llvm::find(Cmd, "--"); +for (std::string &Arg : ToAppend) + Cmd.insert(It++, std::move(Arg)); sammccall wrote: > oops, might have left this commen

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

kadircet updated this revision to Diff 361183. kadircet marked 2 inline comments as done. kadircet added a comment. Change occurence of ArgList usage for canonical prefixes to `Has` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ https://

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

kadircet updated this revision to Diff 361193. kadircet marked 2 inline comments as done. kadircet added a comment. - push_back instead of insert - don't parse argv[0] rather than skipping it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106639/new/

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

kadircet updated this revision to Diff 361195. kadircet added a comment. - Add FIXME for using CommandMangler and buildCompilerInvocation in clangd-indexer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106562/new/ https://reviews.llvm.org/D106562

[PATCH] D106669: [clangd] Unify compiler invocation creation

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Background-indexing is fine, be

[PATCH] D106535: [clangd] Use CommandMangler in TestTU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd2a6ec8eae75: [clangd] Use CommandMangler in TestTU (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D106562: [clangd] Get rid of arg adjusters in CommandMangler

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c0d0085bcaa: [clangd] Get rid of arg adjusters in CommandMangler (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D106527: [clangd] Canonicalize compile flags before applying edits

This revision was automatically updated to reflect the committed changes. Closed by commit rG7cc8a8e3849d: [clangd] Canonicalize compile flags before applying edits (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106527/new/ ht

[PATCH] D106639: [clangd] Adjust compile flags to contain only the requested file as input

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba5dd945ad91: [clangd] Adjust compile flags to contain only the requested file as input (authored by kadircet). Repository: rG LLVM Github Monorep

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Also use it in other places that performed it on their own. Repository: rG LLVM Github Monorepo https://revi

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet updated this revision to Diff 361646. kadircet added a comment. - Preserve no diagnostic behaviour in case of an empty driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106789/new/ https://reviews.llvm.org/D106789 Files: clang/inclu

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

kadircet updated this revision to Diff 361656. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106789/new/ https://reviews.llvm.org/D106789 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp

[PATCH] D106794: Revert "Revert "[clangd] Canonicalize compile flags before applying edits""

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Set driver mode before parsing

[PATCH] D106796: [clangd] Record remote index usage

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This is a gauage metric that se

[PATCH] D106789: [clang][Driver] Expose driver mode detection logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGce90b60bd09d: [clang][Driver] Expose driver mode detection logic (authored by kadircet). Herald added a re

[PATCH] D106794: Revert "Revert "[clangd] Canonicalize compile flags before applying edits""

This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGab714ba056c1: Revert "Revert "[clangd] Canonicalize compile flags before applying edits"" (authored by kadircet). Changed prior to commit: https://reviews.llv

[PATCH] D107040: [clangd] Make use of diagnostic tags for some clang diags

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. It is not great to list diag id

[PATCH] D107047: [clangd] Fix the crash in getQualification

kadircet added a comment. thanks for chasing this down! as mentioned offline a test case like: namespace ns { extern "C" { typedef int foo; } foo Fo^o(int id) { return id; } } in define outline should be enough to ensure it is WAI. Comment at: clang-tools-extra/cl

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:13 +namespace { +class CollectPragmaMarks : public clang::PPCallbacks { can you nest this inside `clang::clangd` and drop the qualifiers ? Comment at: clan

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldman wrote: > kadircet wrote: > > dgoldman wr

[PATCH] D107130: [clangd] Enable relative configs in check mode

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. See https://github.com/clangd/c

[PATCH] D107130: [clangd] Enable relative configs in check mode

kadircet updated this revision to Diff 362972. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107130/new/ https://reviews.llvm.org/D107130 Files: clang-tools-extra/clangd/test/check-fail.test clang-tools-extra

[PATCH] D121286: [clangd] Test against path insensitivity

kadircet created this revision. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo h

[PATCH] D121286: [clangd] Test against path insensitivity

kadircet updated this revision to Diff 414301. kadircet added a comment. Add tests specifically and postpone change in testRoot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/c

[PATCH] D121286: [clangd] Test against path insensitivity

kadircet updated this revision to Diff 414324. kadircet added a comment. - Adjust after tests on windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/clangd/HeaderSourceSwitc

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet updated this revision to Diff 414325. kadircet retitled this revision from "[clangd] Test against path insensitivity" to "[clangd] Handle case insensitive file systems in header/source switch". kadircet added a comment. - rename patch Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet updated this revision to Diff 414326. kadircet added a comment. - Match path ignoring case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/clangd/HeaderSourceSwitch.cp

[PATCH] D119701: [clangd] Re-enable clang-tidy's nolint blocks

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Herald added a project: All. thanks, sorry for missing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119701/new/ https://reviews.llvm.

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet added a comment. Thanks, LG in general. I suppose the extra timing overhead should be negligible, considering the preamble build times but would be nice to see some numbers if you have any. Apart from that I've raised the concern around multiple preamble builds finishing in parallel an

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FS.h:71 +/// Used for tracking time spent in FS operations. Like llvm::Timer, but only +/// tracks wall time, which is much cheaper. adamcz wrote: > kadircet wrote: > > kadircet wrote: > > > I

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet updated this revision to Diff 416984. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/support/Path.h:50 +/// If \p Prefix doesn't match, leaves \p Path untouched and returns false. +bool pathConsumeFront(PathRef &Path, PathRef Prefix); +

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

kadircet updated this revision to Diff 416988. kadircet added a comment. - Address comments for real Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121286/new/ https://reviews.llvm.org/D121286 Files: clang-tools-extra/clangd/HeaderSourceSwitch.cp

[PATCH] D121286: [clangd] Handle case insensitive file systems in header/source switch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG164a10dcf205: [clangd] Test against path insensitivity (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D121712: [clangd] Track time spent in filesystem ops during preamble builds

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! sorry for the long round trip. Comment at: clang-tools-extra/clangd/Preamble.cpp:315 +/// Accumulating wall time timer. Similar to llvm::Timer, but much c

[PATCH] D122315: [clangd] Retain main file fixes attached to diags from preamble

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Cl

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet created this revision. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo h

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet updated this revision to Diff 421847. kadircet added a comment. - Address comments and more cleanups Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123289/new/ https://reviews.llvm.org/D123289 Files: clang-tools-extra/clangd/index/Symbol

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet updated this revision to Diff 421855. kadircet marked 6 inline comments as done. kadircet edited the summary of this revision. kadircet added a comment. - Get rid of leftovers and update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:710 // FIXME: Populate container information for macro references. -MacroRefs[ID].push_back({Loc, Roles, /*Container=*/nullptr}); +// FIXME: All macro references are marked

[PATCH] D123478: [clangd] Fix incorrect operator< impl for HighlightingToken

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Oopsy :/ Thanks for the fix! Regarding the test, if you came looking for this piece due to a particular issue, it might be nice to have that included in the test suite (assuming it can be

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:189 + clang::Token Tok; + if (clang::Lexer::getRawToken(Loc, Tok, SM, LO)) +return false; sammccall wrote: > You've changed this from tokenizing the file with a c

[PATCH] D124013: [clangd] Dont include version string in update tasks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman, javed.absar. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-too

[PATCH] D124013: [clangd] Dont include version string in update tasks

This revision was automatically updated to reflect the committed changes. Closed by commit rG1aa3a54921a1: [clangd] Dont include version string in update tasks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124013/new/ https:/

[PATCH] D123289: [clangd][SymbolCollector] Introduce a cache for SymbolID generation and some cleanups

kadircet closed this revision. kadircet added a comment. Landed in 001e88ac83b5c3a4d4f4e61480953ebcabc82b88 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123289/new/ https://rev

[PATCH] D124176: [clangd] Add beforeExecute() callback to FeatureModules.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/FeatureModule.h:109 +// Called before the preamble build. Allows modules to modify the +// CompilerInvocation

[PATCH] D118913: [clang-tidy] Fix LLVM include order check policy

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: carlosgalvezp, xazax.hun. kadircet requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Clang-format LLVM style has a custom include cate

[PATCH] D118913: [clang-tidy] Fix LLVM include order check policy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0447ec2fb050: [clang-tidy] Fix LLVM include order check policy (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D118782: clangd: Add a break for every case in the PopulateSwitch tweak

kadircet added a comment. I agree with Sam on this one and remember having some (possibly offline) discussions around not having those breaks explicitly (we should've documented the reasoning, sorry). As pointed out, I believe the main benefit is not spelling out each enum value (it's usually

[PATCH] D113874: [clang] Propagate requires-clause from constructor template to implicit deduction guide

kadircet added a comment. As for testing strategy, after this change the AST should look different. You can probably modify `clang/test/SemaTemplate/deduction-guide.cpp` to check for existence of requires clauses in the implicitly generated function templates for guides. Repository: rG LLVM

[PATCH] D118471: [clang][Lexer] Make raw and normal lexer behave the same for line comments

kadircet added inline comments. Comment at: clang/unittests/Lex/LexerTest.cpp:654 + while (!L.LexFromRawLexer(T)) { +ASSERT_TRUE(!ToksView.empty()); +EXPECT_EQ(T.getKind(), ToksView.front().getKind()); probinson wrote: > @kadircet @sammccall It turns o

[PATCH] D119130: [clangd] NFC: Move stdlibg headers handling to Clang

kadircet added a comment. Regarding the include mapping generator, I think it would've been better if we had some sort of list directly from libc++ (as this is now being part of clang rather than just clangd), but having the current symbol mapping available for other tools too is definitely a u

[PATCH] D118976: clangd: Set a diagnostic on a code action resulting from a tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd6c6974f5ea: clangd: Set a diagnostic on a code action resulting from a tweak (authored by ckandeler, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D119989: [clangd] Fix building SerializationTests unit test on OpenBSD

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks Comment at: clang-tools-extra/clangd/unittests/SerializationTests.cpp:313 // Sanitizers use a lot of address space, so we can't apply strict limits. -#if LLVM_ON_

[PATCH] D120065: [clang][SemaTemplate] Fix a stack use after scope

kadircet created this revision. kadircet added a reviewer: sammccall. kadircet requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120065 Files: clang/include/clang/AST/DeclTem

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet updated this revision to Diff 424417. kadircet added a comment. Get rid of shrink_to_fit as PostingList representation doesn't really make a copy of the vector, but rather build a new representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:89 + Result.try_emplace(Token(Token::Kind::Trigram, E.first.str()), + std::move(E.second)); +TrigramDocs.clear(); sammccall wrote: > the move h

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

kadircet updated this revision to Diff 424489. kadircet marked 2 inline comments as done. kadircet added a comment. Copy-assign to empty containers rather than clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124240/new/ https://reviews.llvm.or

[PATCH] D124240: [clangd][NFC] Reduce memory usage while building dex

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2efccf5166f4: [clangd][NFC] Reduce memory usage while building dex (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

kadircet added a comment. can you please upload the patch with full context? see https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: clang-tools-extra/clangd/tool/Check.cpp:196 + // Build Inlay Hints for the entire AST or the specified

[PATCH] D124427: [Serialization] Pack Expr ObjectKind and ValueKind into one VBR.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124427/new/ https://reviews.llvm.org/D124427 __

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, as discussed offline. this mostly LG. there are concerns about more code re-use, especially around handling pragmas but we should probably address them as we go rather than now.

[PATCH] D124679: [clangd] More precisely enable clang warnings through ClangTidy options

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/ParsedAST.cpp:240 +// Note that unlike -Wunused, clang-diagnostics-unused does not imply +// subcategories like clang-d

[PATCH] D124971: [Frontend] give createInvocationFromCommandLine an options struct

kadircet added a comment. Thanks this LGTM. Just two questions: - Why not migrate rest of the usages and drop the old function completely in this patch - What about moving the function from clang/Frontend to Tooling, Support or FrontendTool? this is clearly only inteded to be used by tools and

[PATCH] D124970: [Driver] Make "upgrade" of -include to include-pch optional; disable in clangd

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM! as discussed offline, let's move forward with what you proposed (i.e. this patch, and then flip the default while making libclang opt-in) Comment at: clan

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

kadircet added a comment. I agree that clangd's indexing should probably be higher priority than whatever FS indexing is going on (because clangd's indexing only start when user actually starts working on a project, hence this indicates some level of "interactiveness"). so I feel like the right

[PATCH] D125012: [clang] createInvocationFromCommandLine -> createInvocation, delete former. NFC

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125012/new/ https://reviews.llvm.org/D125012 __

[PATCH] D125088: [clangd] Add parsing for IgnoreHeaders config option

kadircet created this revision. kadircet added reviewers: sammccall, kbobyrev. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D129579: [clangd] Remove `allCommitCharacters`

kadircet added a comment. sorry for being late to the party, but reading the spec it sounds like vscode behaviour is actually the corre

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

kadircet added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:1784 if (D->isInvalidDecl() || D->isUsed() || D->hasAttr()) return false; i think we can just bail out early here when the main file is a header file (i.e. lang opts have `IsHeader

[PATCH] D129642: [Sema] Tweak diagnostic logic so suppress-in-hedaer logic works in tools too.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDecl.cpp:1784 if (D->isInvalidDecl() || D->isUsed() || D->hasAttr()) return false; sammccall wrote: > kadirc

[PATCH] D130003: [clangd] Use empty string to represent None semantics in FoldingRange::kind

kadircet created this revision. kadircet added a reviewer: usaxena95. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D130003: [clangd] Use empty string to represent None semantics in FoldingRange::kind

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0496cf2f6a2e: [clangd] Use empty string to represent None semantics in FoldingRange::kind (authored by kadircet). Repository: rG LLVM Github Monor

[PATCH] D128621: [clangd] Do not try to use $0 as a placeholder in completion snippets

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LG, just some extra precautions. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:195 ++SnippetArg; - *Snippet += - "${" + -

[PATCH] D130011: Use pseudoparser-based folding ranges in ClangdServer.

kadircet added a comment. as discussed offline i don't see much value in having an extra flag to choose between ast-based and pseudo-based implementation, as the pseudo-based one is a super-set of the ast-based implementation. hence it shouldn't be regressing change in any way, therefore i am i

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

kadircet added a comment. thanks, this LG per symboldetails change but as discussed offline i think we actually need a new request or a capability to indicate this (and having a new request is just easier for both clients and clangd) otherwise it can't be reliably used by clients. in addition

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. That way when

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. This could cr

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang-tools-extra. Repository:

[PATCH] D130228: [clangd] Mention whether compile flags were inferred in check mode

This revision was automatically updated to reflect the committed changes. kadircet marked an inline comment as done. Closed by commit rG1515490c80fa: [clangd] Mention whether compile flags were inferred in check mode (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D130

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:1446 +void bax(Args... args) { foo({args...}, args...); } + +void foo() { ilya-biryukov wrote: > NIT: maybe test for the case with a single expansion here: >

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

kadircet updated this revision to Diff 446529. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130261/new/ https://reviews.llvm.org/D130261 Files: clang-tools-

[PATCH] D130261: [clangd] Refactor forwarding call detection logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5871dfaf318: [clangd] Refactor forwarding call detection logic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446531. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/unitt

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

kadircet added a comment. sorry for not mentioning in the bug that i was also working on a patch, D130260 seems to be a little bit more contained and focused on making the check not crash (as we're getting close to release cut). WDYT about landing it now, an

[PATCH] D130259: [clangd] fix crash and handle implicit conversions in inlay hints for forwarding functions

kadircet added a comment. In D130259#3671022 , @nridge wrote: > Which bug/issue is this? https://github.com/llvm/llvm-project/issues/56620 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130259/new/ https:/

[PATCH] D130260: [clangd] Make forwarding parameter detection logic resilient

kadircet updated this revision to Diff 446759. kadircet added a comment. - Check to ensure function call receives all the arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130260/new/ https://reviews.llvm.org/D130260 Files: clang-tools-ext

<    12   13   14   15   16   17   18   19   20   21   >