kadircet added a comment.

Thanks this LGTM. Just two questions:

- Why not migrate rest of the usages and drop the old function completely in 
this patch
- What about moving the function from clang/Frontend to Tooling, Support or 
FrontendTool? this is clearly only inteded to be used by tools and not part of 
the Frontend. There's actually Tooling/Tooling.h which has a `newInvocation` 
that takes in cc1 args, rather than driver args. so these two seem like 
siblings.



================
Comment at: clang/include/clang/Frontend/Utils.h:232
+
+/// Deprecated version of createInvocation with individual optional args.
 std::unique_ptr<CompilerInvocation> createInvocationFromCommandLine(
----------------
what's the reason for not deleting this all together from open source. there 
isn't very many references.
is it just to keep the patch small so that relevant changes are more visible ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124971/new/

https://reviews.llvm.org/D124971

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to