kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks, as discussed offline. this mostly LG. there are concerns about more 
code re-use, especially around handling pragmas but we should probably address 
them as we go rather than now.



================
Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:42
+  for (Decl *D : AST.context().getTranslationUnitDecl()->decls()) {
+    if (ReferencingFile == 
SM.getDecomposedExpansionLoc(D->getLocation()).first)
+      walkAST(*D, [&](SourceLocation Loc, NamedDecl &ND) {
----------------
nit: early exit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124164/new/

https://reviews.llvm.org/D124164

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to