This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.
Closed by commit rG1515490c80fa: [clangd] Mention whether compile flags were
inferred in check mode (authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D130228?vs=446383&id=446518#toc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130228/new/
https://reviews.llvm.org/D130228
Files:
clang-tools-extra/clangd/tool/Check.cpp
Index: clang-tools-extra/clangd/tool/Check.cpp
===================================================================
--- clang-tools-extra/clangd/tool/Check.cpp
+++ clang-tools-extra/clangd/tool/Check.cpp
@@ -111,7 +111,9 @@
if (auto TrueCmd = CDB->getCompileCommand(File)) {
Cmd = std::move(*TrueCmd);
- log("Compile command from CDB is: {0}", printArgv(Cmd.CommandLine));
+ log("Compile command {0} is: {1}",
+ Cmd.Heuristic.empty() ? "from CDB" : Cmd.Heuristic,
+ printArgv(Cmd.CommandLine));
} else {
Cmd = CDB->getFallbackCommand(File);
log("Generic fallback command is: {0}", printArgv(Cmd.CommandLine));
Index: clang-tools-extra/clangd/tool/Check.cpp
===================================================================
--- clang-tools-extra/clangd/tool/Check.cpp
+++ clang-tools-extra/clangd/tool/Check.cpp
@@ -111,7 +111,9 @@
if (auto TrueCmd = CDB->getCompileCommand(File)) {
Cmd = std::move(*TrueCmd);
- log("Compile command from CDB is: {0}", printArgv(Cmd.CommandLine));
+ log("Compile command {0} is: {1}",
+ Cmd.Heuristic.empty() ? "from CDB" : Cmd.Heuristic,
+ printArgv(Cmd.CommandLine));
} else {
Cmd = CDB->getFallbackCommand(File);
log("Generic fallback command is: {0}", printArgv(Cmd.CommandLine));
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits