[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. How about using `multi-value`/`MultiValue`/`MULTI-VALUE` (depending on positions)? The repo name is also multi-value. https://github.com/WebAssembly/multi-value Otherwise LGTM. Repository:

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin added a comment. In D62047#1505838 , @sbc100 wrote: > Does it make sense to support the flags before we support the feature? > > Otherwise lgtm. I think this is OK; flags anyway should be added before actual feature implementation starts in orde

[PATCH] D62047: [WebAssembly] Add multivalue and tail-call target features

aheejin added a comment. I see. LGTM either way 😂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62047/new/ https://reviews.llvm.org/D62047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } Does this mean we only support `Vptr` among sanitizers [[ https://github.com/llvm/llvm-project

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } quantum wrote: > aheejin wrote: > > Does this mean we only support `Vptr` among sanitizers [[

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } quantum wrote: > aheejin wrote: > > quantum wrote: > > > aheejin wrote: > > > > Does this mean

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } aheejin wrote: > quantum wrote: > > aheejin wrote: > > > quantum wrote: > > > > aheejin wrote:

[PATCH] D56504: [WebAssembly] Add unimplemented-simd128 feature, gate builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

aheejin added a comment. Can you give the link for the spec of these new instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67425/new/ https://reviews.llvm.org/D67425 ___ cfe-commits mailing l

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

aheejin created this revision. aheejin added a reviewer: NoQ. Herald added subscribers: cfe-commits, xazax.hun, mgorny. Herald added a project: clang. This fixes build failures with `-DBUILD_SHARED_LIB=ON` after D67419 . Repository: rG LLVM Github Monorepo ht

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

aheejin added a comment. I think that's it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67473/new/ https://reviews.llvm.org/D67473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D67473: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON

This revision was automatically updated to reflect the committed changes. Closed by commit rL371706: [clang-tidy] Fix build with -DBUILD_SHARED_LIB=ON (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

This revision was automatically updated to reflect the committed changes. Closed by commit rL371708: [WebAssembly] Add -fwasm-exceptions for wasm EH (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D67425: [WebAssembly] Narrowing and widening SIMD ops

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM. - Maybe we can lower these to these new instructi

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

aheejin added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } MaskRay wrote: > calculateAttributeSpellingListIndex is defined in cla

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

aheejin added a comment. +1 on erroring out on the backend side. And how about "wasm64 is not supported"? wasm64... is still a registered target in the frontend, so... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/ https://reviews.llvm.o

[PATCH] D45555: Fix a link failure in applyChanges()

aheejin created this revision. aheejin added a reviewer: jdemeule. Herald added subscribers: cfe-commits, mgorny, klimek. This call (https://github.com/llvm-mirror/clang-tools-extra/blob/e6bfa666d96c0d3010bb7d572f6240424ebd1cff/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp#L228-L229)

[PATCH] D45555: [clang-apply-replacements] Fix a link failure in applyChanges()

aheejin abandoned this revision. aheejin added a comment. Looks like the same patch https://reviews.llvm.org/rL329892 has already landed. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D4 ___ cfe-commits mailing list cfe-commits@

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Add support for atomic.wait / atomic.wake builtins based on the Wasm thread proposal. Repository: rC Clang https://reviews.llvm.org/D49396 Files: incl

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 155738. aheejin added a comment. - test fix Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c ===

[PATCH] D49396: [WebAssembly] Support for atomic.wait / atomic.wake builtins

aheejin updated this revision to Diff 155958. aheejin added a comment. - Type fix Repository: rC Clang https://reviews.llvm.org/D49396 Files: include/clang/Basic/BuiltinsWebAssembly.def lib/CodeGen/CGBuiltin.cpp test/CodeGen/builtins-wasm.c Index: test/CodeGen/builtins-wasm.c ===

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. > LLVM produces a poison value if the dynamic swizzle indices are greater than > the vector size, but the WebAssembly instruction sets the corresponding > output lane to zero. Where do we s

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:117 + llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, + llvm_i32_ty, llvm_i32_ty, llvm_i32_ty, llvm_i32_ty], +[IntrNoMem, IntrSpeculatable

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. In D80061 we added warning for exception specifications with types (such as `throw(int)`), b

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin updated this revision to Diff 265432. aheejin added a comment. - Fix warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/docs/DiagnosticsReference.rst clang/include/clan

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin updated this revision to Diff 265645. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/was

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG48acac362938: [WebAssembly] Warn on exception spec only when Wasm EH is used (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/

[PATCH] D80968: [WebAssembly] Improve macro hygiene in wasm_simd128.h

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Headers/wasm_simd128.h:1040 + (__c4)*2 + 1, (__c5)*2, (__c5)*2 + 1, (__c6)*2, (__c6)*2 + 1, (__c7)*2, \ + (__c7)*2 + 1)) ---

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + It'd be clearer to

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

aheejin added a comment. This looks fine to me, but I haven't worked on this part of code myself, so probably others who have can provide better review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375 __

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + tlively wrote: > aheejin wrote: > > It'd be clearer to say starting indices of these don't start wit

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + tlively wrote: > aheejin wrote: > > tlively wrote: > > > aheejin wrote: > > > > It'd be clearer to s

[PATCH] D84876: [clangd] Add clangdSupport to indexer target libraries

aheejin created this revision. aheejin added a reviewer: kbobyrev. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, mgorny. Herald added a project: clang. aheejin requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. After D84697

[PATCH] D84876: [clangd] Add clangdSupport to indexer target libraries

aheejin abandoned this revision. aheejin added a comment. It looks it was already addressed by https://github.com/llvm/llvm-project/commit/1603470e59a99a39ebdc4bf62a3a16c8c4ebea36#diff-761bab5bd4145e54cef902c493740880. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198 +[LLVMPointerType], +[IntrReadMem, IntrArgMemOnly, IntrSpeculatable], +

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

aheejin added a comment. Could you revert this patch? This is causing an error like this whenever I run `clang` binary: : CommandLine Error: Option 'openmp-ir-builder-optimistic-attributes' registered more than once! LLVM ERROR: inconsistency in registered CommandLine options This happens

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

aheejin added a comment. Thanks. Not sure if there's a buildbot that uses `-DLLVM_LINK_LLVM_DYLIB=ON -DLLVM_BUILD_LLVM_DYLIB=ON`, but I think you can build with it yourself to reproduce it. About how to resolve the issue, I have no idea, sorry. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D77666: [OpenMP] "UnFix" layering problem with FrontendOpenMP

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. I don't know much about how this part works, but if this is purely a revert of the previous patch, I don't think you need a review for that. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Wasm does not currently handle exception specifications such as `throw()` or `throw(int)`. We have a plan to correctly implemen

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:23 #include "clang/AST/StmtVisitor.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetBuiltins.h" One thing I'm not sure

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/lib/CodeGen/CGException.cpp:23 #include "clang/AST/StmtVisitor.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetBuiltins.h" aheejin wrote: > One th

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin updated this revision to Diff 263218. aheejin added a comment. - Delete a debugging(?) line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79742: [WebAssembly] Implement pseudo-min/max SIMD instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:147 +TARGET_BUILTIN(__builtin_wasm_pmin_f64x2, "V2dV2dV2d", "nc", "simd128") +TARGET_BUILTIN(__builtin_was

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. Now this handles `throw()` in the same way as `noexcept`, and prints a warning only in case of `throw(type, ..)`, as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264335. aheejin added a comment. Handle `throw()` in the same way as `noexcept` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 Files: clang/include/clang/Basic/Diagn

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling

[PATCH] D79655: [WebAssembly] Handle exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGbca347508c86: [WebAssembly] Handle exception specifications (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. aheejin edited the summary of this revision. aheejin updated this revision to Diff 264423. aheejin added a comment. - rst file

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin added a comment. This is an improved version of D79655 . The warning now can be suppressed by `-Wno-wasm-exception-spec`. To do this, we needed a diagnostic group. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264423. aheejin added a comment. - rst file fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80061/new/ https://reviews.llvm.org/D80061 Files: clang/docs/DiagnosticsReference.rst clang/include/clang/Basic

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. Committed and reverted this. Resubmitted this in D80061 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 ___

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin added a comment. This is very strange. I haven't committed a file called wasm-eh.ll. (There is a file called wasm-eh.cpp, which existed for more than a year now.) Also there's no wasm-eh.ll in LLVM repo now either. I wonder how this happened..? Also I can't reproduce the bug in my local

[PATCH] D79655: [WebAssembly] Handle exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:387 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264461. aheejin added a comment. - Add missing -o Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80061/new/ https://reviews.llvm.org/D80061 Files: clang/docs/DiagnosticsReference.rst clang/include/clang/Bas

[PATCH] D80061: [WebAssembly] Handle exception specifications

aheejin updated this revision to Diff 264466. aheejin added a comment. - Add missing `-` after `-o` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80061/new/ https://reviews.llvm.org/D80061 Files: clang/docs/DiagnosticsReference.rst clang/inclu

[PATCH] D80174: [WebAssembly] Implement i64x2.mul and remove i8x16.mul

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:690 defm "" : SIMDBinary; } Can we delete this now then? Comme

[PATCH] D80061: [WebAssembly] Handle exception specifications

This revision was automatically updated to reflect the committed changes. Closed by commit rGd94bacbcf87a: [WebAssembly] Handle exception specifications (authored by aheejin). Changed prior to commit: https://reviews.llvm.org/D80061?vs=264466&id=264821#toc Repository: rG LLVM Github Monorepo

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

aheejin added a comment. After this patch, a couple of gcc torture tests started to fail. Could you possibly look at this? https://bugs.llvm.org/show_bug.cgi?id=35503 Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing li

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

aheejin added a comment. Once you confirm the bug, could you possibly revert the patch? Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D39455: [CodeGen] Add initial support for union members in TBAA

aheejin added a comment. Thank you for confirming and reverting! Repository: rL LLVM https://reviews.llvm.org/D39455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/simd-unsupported.ll:13 ; CHECK-LABEL: ctlz_v16i8: -; CHECK: i32.clz +; CHECK: i8x16.popcnt declare <16 x i8> @llvm.ctlz.v16i

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:1141 +def : Pat<(vec.int_vt (vselect +(setolt (vec.vt (bitconvert V128:$rhs)), +(vec.vt (bitconvert V128:$lhs))), Sorry I asked this in

[PATCH] D106612: [WebAssembly] Codegen for pmin and pmax

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. Thanks for the explanation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106612/new/ https://reviews.llvm.org/D106612 __

[PATCH] D66910: [clangd] Fix ExtractFunction dependencies

aheejin created this revision. aheejin added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Without these dependencies, builds with `-DBUILD_SHARED_LIBS=ON` fail. Repository: rG LLVM Git

[PATCH] D66910: [clangd] Fix ExtractFunction dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL370273: [clangd] Fix ExtractFunction dependencies (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

aheejin added a comment. Could you point to the spec of these instructions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67020/new/ https://reviews.llvm.org/D67020 ___ cfe-commits mailing list cfe-com

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added a comment. In D66983#1653226 , @tlively wrote: > The code that does the undesirable optimization is around > llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:18776. Now line 18776 is a blank line :) You can take a permalink from the https://

[PATCH] D67020: [WebAssembly] Add SIMD QFMA/QFMS

aheejin added a comment. Should we handle these too? - There seems to be a generic intrinsic for fused multiply-add: https://github.com/llvm/llvm-project/blob/d21a3e41a4cfd52e3c5c9341f0b5ce8a173198bf/llvm/include/llvm/Target/GenericOpcodes.td#L612-L619 - There are FMA related nodes in ISDOpcode.

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

aheejin added a comment. Yeah I think that can be a more generalized solution too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983/new/ https://reviews.llvm.org/D66983 ___ cfe-commits mailing list

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, aprantl. Herald added a project: clang. This adds `-fwasm-exceptions` (in similar fashion with `-fdwarf-exceptions` or `-fsjlj-exceptions`) that turn

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin updated this revision to Diff 218834. aheejin added a comment. - Remove a blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208 Files: clang/include/clang/Basic/LangOptions.def clang/includ

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. @tlively @sbc100 What I wanted was to make `-fwasm-exceptions` as something like `-pthreads`, which serves as the only flag that needs to be turned on and turns on all other necessary flags, such as `+matomics`, `+mbulk-memory`, and `--shared-memory`. I think all those

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1659941 , @sbc100 wrote: > But why not make -mexception-handling be the option that enabled everything? > I mean -mexception-handling is a flag we have today.. if you add > -fwasm-exceptions what does -mexception-han

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1659972 , @dschuff wrote: > If this is to be like `-fdwarf-exceptions` I assume the idea is that > eventually it will default on when targeting wasm, and become one of those > flags that most users never set. In that ca

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1660041 , @sbc100 wrote: > `-pthreads` enabling `-matomics` and `-mbulk-memory`make some sense > because each of those low level flags might make sense on its own. But if > `-fwasm-exceptions` only going to enable

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1660041 , @sbc100 wrote: > `-pthreads` enabling `-matomics` and `-mbulk-memory`make some sense > because each of those low level flags might make sense on its own. But if > `-fwasm-exceptions` only going to enable

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1661694 , @tlively wrote: > What happens when users have exceptions in their code but don't pass Do they > get the old SJLJ emulated exception handling? The current emscripten EH is enabled by `-mllvm -enable-emscrip

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin updated this revision to Diff 219203. aheejin added a comment. - Error out when -fwasm-exceptions is specified with -enable-emscripten-cxx-exceptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

aheejin added a comment. Looks OK to me, but I haven't worked on this part of code either, so I think someone else should approve it. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

aheejin resigned from this revision. aheejin added a comment. I don't have enough context or knowledge on this code base. Sorry! https://reviews.llvm.org/D36764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: llvm-commits, cfe-commits, wingo, ecnelises, jfb, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. aheejin requested review of this revision. - atomic.notify -> me

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, wingo, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. This RUN line was added as a temporary measure to undo t

[PATCH] D91448: [WebAssembly] Remove a temporarily added RUN line

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG01d871536940: [WebAssembly] Remove a temporarily added RUN line (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D91447: [WebAssembly] Rename atomic.notify and *.atomic.wait

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG902ea588eab8: [WebAssembly] Rename atomic.notify and *.atomic.wait (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D88968: [WebAssembly] Prototype i16x8.q15mulr_sat_s

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_q15mulr_saturate_s_i8x16, "V8UsV8UsV8Us", "nc", "simd128") + ---

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane, "V4iIii*", "nU", "simd128") +TARGET_BUILTIN(__builtin_wasm

[PATCH] D89366: [WebAssembly] v128.load{8, 16, 32, 64}_lane instructions

aheejin added a comment. Do loads need the vector argument? The proposal has that but I'm wondering why... Can that possibly be an error from the author's side? Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:180 +TARGET_BUILTIN(__builtin_wasm_load32_lane, "V4iIi

[PATCH] D89446: [WebAssembly] Prototype i8x16.popcnt

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:117 +TARGET_BUILTIN(__builtin_wasm_popcnt, "V16ScV16Sc", "nc", "simd128") + - Even if t

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

aheejin created this revision. aheejin added a reviewer: tlively. Herald added subscribers: cfe-commits, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. aheejin requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D90253: [WebAssembly] Prototype extending multiplication SIMD instructions

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:263 +// TODO: Add a new LLVMMatchType that can describe the relationship between the +// result and parameter

[PATCH] D90294: [WebAssembly] Clang-format builtins generation (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98941279b90e: [WebAssembly] Clang-format builtins generation (NFC) (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin created this revision. aheejin added a reviewer: dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It turns out we have not correctly supp

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

aheejin added a comment. In D102791#2769892 , @dschuff wrote: > BTW Is there a way to disable this warning? The warning is like test.cpp:3:6: warning: dynamic exception specifications with types are currently ignored in wasm [-Wwasm-exception-spec]

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb12b0ae11f: [WebAssembly] Warn on exception spec for Emscripten EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https:

[PATCH] D95557: [WebAssembly] Prototype i8x16 to i32x4 widening instructions

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. This does not yet have i64x2 version of the instructions in https://github.com/WebAssembly/simd/pull/395 yet, right? Comment at: llvm/lib/Target/WebAssembly/WebAssemblyIns

[PATCH] D110295: [WebAssembly] Add prototype relaxed SIMD fma/fms instructions

aheejin accepted this revision. aheejin added inline comments. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:14 // Instructions requiring HasSIMD128 and the simd128 prefix byte +multiclass ABSTRACT_SIMD_Ihttps://reviews.llvm.org/D110295/new/ https://reviews.

[PATCH] D96903: [WebAssembly] Remove dependency of reference types from EH

aheejin created this revision. aheejin added reviewers: dschuff, tlively. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. aheejin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new spec does not have `exn

[PATCH] D96903: [WebAssembly] Remove dependency of reference types from EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b5d2b0efd3e: [WebAssembly] Remove dependency of reference types from EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96903/new/ htt

<    1   2   3   >