aheejin marked an inline comment as done. aheejin added inline comments.
================ Comment at: clang/lib/CodeGen/CGException.cpp:23 #include "clang/AST/StmtVisitor.h" +#include "clang/Basic/DiagnosticSema.h" #include "clang/Basic/TargetBuiltins.h" ---------------- aheejin wrote: > One thing I'm not sure about is if it is a good thing to include this in > CodeGen. Usually this header is used in Sema/ directory. This depends on > which .td file I add `warn_wasm_exception_spec_ignored`. > DiagnosticSemaKinds.td seemed to have a section in exception spec so I added > it there, but not entirely sure if that's the best location to add it. Oh, and this warning message was requested by Adobe, but I think it's good to have in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
