aheejin added a comment.

In D67208#1661694 <https://reviews.llvm.org/D67208#1661694>, @tlively wrote:

> What happens when users have exceptions in their code but don't pass  Do they 
> get the old SJLJ emulated exception handling?


The current emscripten EH is enabled by `-mllvm 
-enable-emscripten-cxx-exceptions`, which is not a clang flag (it's passed by 
`-mllvm`). The reason it is not a clang flag is emscripten EH does not need any 
action in clang. If  users use exceptions but don't pass `-fwasm-exceptions`, 
if they pass `-mllvm -enable-emscripten-cxx-exceptions` instead, emscripten EH 
will be used. If they pass neither, neither EH will be used and all invokes 
will be lowered to calls.

Having said that, `-fwasm-exceptions` and `-mllvm 
-enable-emscripten-cxx-exceptions` are not compatible. If we can check this 
that'd be better. I'll check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67208/new/

https://reviews.llvm.org/D67208



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to