aheejin added inline comments.
================ Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } ---------------- MaskRay wrote: > calculateAttributeSpellingListIndex is defined in clangSema. This can cause > lib/libclangAST.so.10svn (-DBUILD_SHARED_LIBS=on) fail to link: > > ``` > ld.lld: error: undefined symbol: > clang::AttributeCommonInfo::calculateAttributeSpellingListIndex() const > >>> referenced by AttributeCommonInfo.h:166 > >>> (../tools/clang/include/clang/Basic/AttributeCommonInfo.h:166) > >>> > >>> tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/AttrImpl.cpp.o:(clang::AttributeCommonInfo::getAttributeSpellingListIndex() > >>> const) > ``` +1 This fails builds with `-DBUILD_SHARED_LIBS=ON`. I tried to add `clangSema` as a dependent library to `clangAST`, but this creates several circular dependencies. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67368/new/ https://reviews.llvm.org/D67368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
