[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

HazardyKnusperkeks added a comment. In D134049#3798389 , @rymiel wrote: > In D134049#3798366 , @owenpan wrote: > >> Would you like to get commit access? See >> https://llvm.org/docs/DeveloperPolicy.html#obtaining

[PATCH] D134325: [clang-format] Look ahead before consuming `bool` in requires clause.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the fix. In D134325#3804969 , @MyDeveloperDay wrote: > given that #57538 manifested itself as a incorrect format (

[PATCH] D134587: [clang-format] Correctly annotate static and consteval lambdas

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Fancy stuff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134587/new/ https://reviews.llvm.org/D134587 ___ cfe-commits mail

[PATCH] D134652: [clang-format] Add Basic Carbon Support/Infrastructure to clang-format

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3671 parseRecord(); - // This does not apply to Java, JavaScript and C#. + // This does not apply to Java, JavaScript and C# or Carbon if (Style.Language == FormatStyle::LK_Java

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

HazardyKnusperkeks added a comment. One does not need to remove this, when adding response file support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111000/new/ https://reviews.llvm.org/D111000 ___ cfe

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

HazardyKnusperkeks added a comment. Looks good. You could add a FIXME before the commented out tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134853/new/ https://reviews.llvm.org/D134853 ___ cfe-co

[PATCH] D135115: [clang-format] update --files help description

HazardyKnusperkeks added a comment. It's too long ago for me. Does the `--files` option take multiple file names on the command line, or a file containing the file names? If the latter the patch generally looks good. Except for the `@` part. (Which also isn't handles by clang-format, or is it?

[PATCH] D135372: [clang-format] Fix for #58188

HazardyKnusperkeks added a comment. What is the problem that remains? Please add a test case. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1142-1143 + PPStack.back().Kind == PP_Unreachable && + !(PPStack.size() > 1 && +PPStack[PPStack.size() - 2].Kind

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3841248 , @owenpan wrote: > Is this option really required? Can we just fix the regression as reported in > https://github.com/llvm/llvm-project/issues/56283? It seems that we haven't > followed the policy

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

HazardyKnusperkeks added a comment. Please add a regression test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D135466: [clang-format] Add support to remove unnecessary semicolons after function definition

HazardyKnusperkeks added a comment. Maybe even extend the option to other unnecessary semicolons like `int x = 5;;` or other noop statements, one just has to be careful not to remove the semicolon when it's the sole if/loop body. Comment at: clang/include/clang/Format/Format.

[PATCH] D135422: Fix clang-format misattributing preprocessor directives to macros

HazardyKnusperkeks added a comment. The clang-format tests are (mainly) in `clang/unittests/Format/FormatTest.cpp`, please put it there. You should have a Format-Tests (or similar) build target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135422/new/ https://reviews.llvm.org/D135422

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a reviewer: Vigilans. HazardyKnusperkeks added a comment. In D129443#3844535 , @owenpan wrote: > In D129443#3842427 , > @HazardyKnusperkeks wrote: > >> We can //fix// that regression, and

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:950-952 + if (RestoredLineLength >= Style.ColumnLimit && Style.ColumnLimit != 0) { +break; + } Elide the braces. Comment at: clang/un

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ReleaseNotes.rst:540 -- Add `RemoveSemicolon` option for removing `;` after a non-empty function definition. +- Add ``RemoveSemicolon`` option for removing ``;`` after a non-empty function definition

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1189-1194 +// User defined literal without a space +if (CurrentToken->Previous->is

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. In D135740#3851405 , @sstwcw wrote: > Should I add a test with comments to be aligned like in the bug report? I > was not sure because I didn't find an existing test for alignment of comments. Yes you should. Repos

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1304 LLVMStyle.RequiresClausePosition = FormatStyle::RCPS_OwnLine; + LLVMStyle.RequiresExpressionIndentation = FormatStyle::REI_Keyword; LLVMStyle.SeparateDefinitionBlocks = FormatStyle::SDS_

[PATCH] D135866: [clang-format][NFC] Fix comment grammer in ContinuationIndenter

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, OwenBed, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D135872: [clang-format] Handle unions like structs and classes

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks added a comment. Fun fact, there is one instance of such a case within the clang-format code. I can't remember where (I stumbled upon this in January, and tried to fix it ever since), should that be reformatted with this patch, or with a follow up? Comment

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. For me this is good. But please wait for @MyDeveloperDay . Comment at: clang/lib/Format/WhitespaceManager.cpp:931-933 + if (Style.AlignTrailingComments.Kind == FormatStyle::TCAS_Always) { +NewLi

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3857816 , @owenpan wrote: > In D129443#3857608 , @rymiel wrote: > >> Changing the default LLVM style would change the output of all the >> requires-related test case

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

HazardyKnusperkeks added a comment. In D135707#3859357 , @rymiel wrote: > Thanks for the kind words ❤️ (I've noticed Björn already includes me in his > reviewers list); and while I am humbled, and I do look at every patch, I > don't *yet* trust myself t

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3121 + return 1; +if (Right.is(tok::period)) + return 500; owenpan wrote: > Otherwise, it wouldn't be NFC. It was Left == :: || Right == . Repository: rG L

[PATCH] D140267: [clang-format] Allow line break between template closer and right paren

HazardyKnusperkeks added a comment. Maybe do not limit to `JsTypeColon` but all colons? What about something like `f(some_template).method()`? I'd have to check where it breaks if there isn't a template in the argument, but I'd guess not before the paren. Comment at: clang/li

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. You have to do better: https://gcc.godbolt.org/z/7hEKx1dhv Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140312

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

HazardyKnusperkeks added a comment. I'm shocked and impressed, that it just works. Comment at: clang/lib/Format/TokenAnnotator.cpp:1683 -if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_concept, - tok::kw_struct, tok::kw_using)) { +

[PATCH] D140339: [clang-format] Remove special logic for parsing concept definitions.

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1683 -if (Tok->isOneOf(tok::kw_class, tok::kw_enum, tok::kw_concept, -

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks added a comment. In D140312#4006106 , @rymiel wrote: > What if I make this depend on D140339 ? > Then this change would no longer impact concept definitions. Yep, that would be right. It seems I can't

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the expression is The com

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// clause. It returns, when the parsing is complete, or the expression is Hazardy

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2395 + /// >0: Insert separators between digits, starting from the rightmost digit. + struct IntegerLiteralSeparatorStyle { +/// \code Also add Octal? ==

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Format/FormatTest.cpp:25124 +TEST_F(FormatTest, IntegerLiteralSeparator) { + FormatStyle Style = getLLVMStyle(); --

[PATCH] D140312: [clang-format] Disallow decltype in the middle of constraints

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3494 /// /// This is either the definition of a concept, or the body of a requires /// cla

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new (Allocator.Al

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. But please wait for at least one of the others. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140767/new/ https://review

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new (Allocator.Al

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. On second thought, shouldn't we test for removing the braces? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

HazardyKnusperkeks added a comment. In D140835#4023132 , @owenpan wrote: > In D140835#4023080 , > @HazardyKnusperkeks wrote: > >> On second thought, shouldn't we test for removing the braces? > > Hmm. This patch

[PATCH] D140835: [clang-format] Improve UnwrappedLineParser::mightFitOnOneLine()

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D140835#4028274 , @owenpan wrote: > If `RemoveBracesLLVM` is false, the line is too long and will wrap. That's what I fail

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

HazardyKnusperkeks added a comment. What Owen says. Apart from that looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137223/new/ https://reviews.llvm.org/D137223 ___ cfe-commits mailing list cfe

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. I'm lost at this topic. Is this change still needed? Is it superseded by or additional to D137052 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llv

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdbe296853b1: [clang-format] Fix lambda formatting in conditional (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf97639ce1375: [clang-format] Don't misannotate in CTor init list (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D137075: [clang-format] Fix document of AlignTrailingComments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG691774d4030d: [clang-format][NFC] Fix document of AlignTrailingComments (authored by yusuke-kadowaki, committed by HazardyKnusperkeks). Repository:

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. You can reopen this, if you wish to continue working on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___ cfe-com

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. More than a year silence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 ___ cfe-

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. Herald added a project: All. If you still want this to be landed, we need a name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-co

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. In D90121#3065063 , @dmikis wrote: > Since we used heavily patched version of clang-format (including this patch) > that problem didn't bugged us and I kinda moved on to other

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:366 + CurrentToken->is(tok::identifier) && + !Next->isOneOf(tok::equal, tok::l_brace)) { Prev->setType(TT_BinaryOperator); Could you a

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137327/new/ https://reviews.llvm.org/D137327

[PATCH] D137486: [clang-format] Correctly annotate function names before attributes

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:76 +static bool isCppAttribute(bool IsCpp, const FormatToken &Tok) { + if (!IsCpp || !Tok.startsS

[PATCH] D137409: [clang-format][NFCish] Alphabetical sort Format.(h|pp)

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23323 "WhitespaceSensitiveMacros: ['FOO', 'BAR']"))); - std::vector NonDefaultWhiteSpaceMacros{"FOO", "BAR"}; + std::vector NonDefaultWhiteSpaceMacros = +

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a subscriber: owenpan. HazardyKnusperkeks added a comment. @MyDeveloperDay @owenpan What shall we do? 1. Abandon this 2. Commit it in our name 3. Use the email from this commit: https://github.com/Wandalen/game_chess/commit/a84bba03667643ded0cfe7aff2907c6546a6a192 I'm p

[PATCH] D91949: [clang-format] Add BeforeStructInitialization option in BraceWrapping configuration

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. More than one year silence. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91949/new/ https://reviews.llvm.org/D91949 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. In D91950#3917635 , @MyDeveloperDay wrote: > I think this is them.. > > https://twitter.com/xen_org/status/1397581514318225412 > https://xenproject.org/ > https://xenproject.org/2021/09/22/clang-format-for-xen-coding-st

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6b252978c40: [clang-format] Add BreakBeforeInlineASMColon configuration (authored by anastasiia_lukianenko, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D91950?v

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1 +//===- unittest/Format/ConfiParseTest.cpp - Config parsing unit tests -===// +// rymiel wrote: > typo (Co

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks added a comment. In D137762#3919092 , @MyDeveloperDay wrote: > Definitely needs tests Could you please add tests in the `clang/unittests/Format/FormatTest.cpp` file? Comment at: clang/lib/Format/TokenAnnotator.cpp:

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: rymiel, MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137883: [clang-format][NFC] Improve documentation of FixNamespaceComments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:5006-5010 +return !((Previous && (Previous->is(tok::kw_for) || Previous->isIf())) || + (Right.Next && + (Right.Next->is(tok::l_paren) || + (Right.N

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1006 + +TEST(FormatStyle, GetStyleWithEmptyFileName) { + llvm::vfs::InMemoryFileSystem FS; owenpan wrote: > Othe

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7215 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - EXPECT_EQ(StringRef("functionCall(paramA, paramB,\n" - "paramC);\n" - "vo

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks updated this revision to Diff 475253. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137865/new/ https://reviews.llvm.org/D137865 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3073-3076 + /// If ``true``, clang-format will attempt to re-flow comments. That is it + /// will touch a comment and *reflow* long comments into new lines, trying to + /// obey the ``Col

[PATCH] D137883: [clang-format][NFC] Improve documentation of FixNamespaceComments

HazardyKnusperkeks updated this revision to Diff 475257. HazardyKnusperkeks marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137883/new/ https://reviews.llvm.org/D137883 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40c1476e3ae2: [clang-format][NFC] Improve documentation on ReflowComments (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo C

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for your patience. Please wait for @MyDeveloperDay . Comment at: clang/unittests/Format/FormatTest.cpp:7215 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - EXPECT_EQ(StringRef(

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D142412: [clang-format] Put peekNextToken(/*SkipComment=*/true) to good use

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3592-3601 case tok::kw_bool: // bool is only allowed if it is directly followed by a paren for a cast: // concept C = bool(

cfe-commits@lists.llvm.org

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a reviewer: rymiel. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good to me, but please wait until another one has given their blessing, or at least no veto for a few days. CHANGES

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} rymiel wrote: > Should the space be required? What about `// clang-form

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3901 + return Comment.startswith(Prefix) && + (Comment.size() == Size || isblank(Comment[Size])); +} owenpan wrote: > HazardyKnusperkeks wrote: > > rymiel wrote: > > > Shou

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:839-846 return Style.AlignConsecutiveAssignments.AlignCompound ? C.Tok->getPrecedence() == prec::Assignment - : C.Tok->is(tok::equal); +

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

HazardyKnusperkeks added a comment. An entry in the changelog would be nice. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1406-1408 + CurrentState.BreakBeforeParameter = !( + Style.PackConstructorInitializers == FormatStyle::PCIS_NextLine || + St

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

HazardyKnusperkeks added a comment. In D143091#4099585 , @Backl1ght wrote: > In D143091#4097534 , > @HazardyKnusperkeks wrote: > >> An entry in the changelog would be nice. > > It is already added I think. I don

[PATCH] D142891: [clang-format] Recognize Verilog non-blocking assignment

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks ok to me. Please wait for some other opinion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142891/new/ https://re

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3891 + * ``PCIS_OnlyNextLine`` (in configuration: ``OnlyNextLine``) +Put all constructor initializers on the next line if they fit. owenpan wrote: > Backl1ght wrot

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D141654#4050852 , @rymiel wrote: > (This needs to run the updated dump script from D138446 > ) > > I'm not sure what the strict //benefit/

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

HazardyKnusperkeks added reviewers: owenpan, HazardyKnusperkeks. HazardyKnusperkeks added a comment. Looks ok for me. Comment at: clang/include/clang/Format/Format.h:3500 +/// \code +///using std::c; +///using std::b; You should use the same

[PATCH] D141654: [clang-format] Replace DeriveLineEnding and UseCRLF with LineEnding

HazardyKnusperkeks added a comment. In D141654#4053470 , @rymiel wrote: > This also made me wonder, is there an actual policy on deprecated options? As > in, when they are actually removed. Is there even prior precedent for doing > this? (I wouldn't kno

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. What about `decltype(auto)`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141811/new/ https://reviews.llvm.org/D141811

cfe-commits@lists.llvm.org

HazardyKnusperkeks added a comment. Could this be added to `Context` instead of a new type? Comment at: clang/lib/Format/TokenAnnotator.cpp:1205 case tok::r_brace: + if (Scopes.size() > 1) +Scopes.pop_back(); How does this happen? The only `pu

cfe-commits@lists.llvm.org

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2544 SmallVector Contexts; + static SmallVector Scopes; dkt01 wrote: > HazardyKnusperkeks wrote: > > Why static? > The AnnotatingParser object lifetime is too short to

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks added a comment. In D141811#4064428 , @rymiel wrote: > In D141811#4055485 , > @HazardyKnusperkeks wrote: > >> What about `decltype(auto)`? > > Turns out this is a problem even without this patc

cfe-commits@lists.llvm.org

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:851 if (CurrentToken->is(tok::r_brace)) { +// Handle unbalanced braces +if (Scopes.size() > 1) See below Comment at: clang/lib/Form

[PATCH] D141811: [clang-format] Allow trailing return types in macros

HazardyKnusperkeks added a comment. In D141811#4070629 , @rymiel wrote: > In D141811#4068180 , > @HazardyKnusperkeks wrote: > >> I thought about `auto NAME() -> int { return 42; }`. >> >> `decltype(auto) a = (b)

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: nlopes. Comment at: clang/lib/Format/FormatToken.h:982 kw_always = &IdentTable.get("always"); kw_always_com

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1314 LLVMStyle.SpaceBeforeParensOptions.AfterIfMacros = true; + LLVMStyle.SpaceBeforeParensOptions.AfterPlacementNew = true; LLVMStyle.SpaceBeforeRangeBasedForLoopColon = true; --

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3586475 , @MyDeveloperDay wrote: > what about (may not be useful but compiles) > > struct { > int foo; > } &&ptr2 = {}; > > https://godbolt.org/z/rbb8x3hKP Let's ask why it was set to a binary

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declartion of pointer to struct

HazardyKnusperkeks added a comment. Could you please either directly link to the github issue or better use llvm.org/pr55810 than just #55810 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127873/new/ https://reviews.llvm.org/D127873 ___

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3495 +/// \code +///true: false: +///new (buf) T;vs.new(buf) T; MyDeveloperDay wrote: > should t

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3589465 , @jackhong12 wrote: > I think it's a good idea. When does `MatchingParen` bind? The value of > `PrevToken->MatchingParen` is still NULL in `determineStarAmpUsage` function. What has changed, now y

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added a comment. Nice work adding the capability to the dump script. Comment at: clang/docs/ClangFormatStyleOptions.rst:4264 +and opening parentheses. +14 + This seems to be not entirely correct yet. :) Comment at:

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_Binary

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2328 +} + if (PrevToken->Tok.isLiteral() || MyDeveloperDay wrote: > Thank you I wish more of the clauses were commented l

<    1   2   3   4   5   6   7   8   9   10   >