HazardyKnusperkeks added a comment.

What is the problem that remains?

Please add a test case.



================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1142-1143
+      PPStack.back().Kind == PP_Unreachable &&
+      !(PPStack.size() > 1 &&
+        PPStack[PPStack.size() - 2].Kind == PP_Unreachable);
   if (!PPStack.empty())
----------------
Could you remove the negation? I find negations of compound statements always 
harder to read.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135372/new/

https://reviews.llvm.org/D135372

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to