[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7309404536c: [clang-format] Suppress diagnostics on second parse (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/

[PATCH] D97927: [clang-format] Rename case sorting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b02794f0aeb: [clang-format] Rename case sorting (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7f9f94b2e2b: [clang-format] Rework Whitesmiths mode to use line-level values in… (authored by timwoj, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2605517 , @timwoj wrote: > In D94500#2605515 , > @HazardyKnusperkeks wrote: > >> In D94500#2604754 , @timwoj wrote: >> >>> Reba

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks added a comment. In D97927#2605914 , @kentsommer wrote: > LGTM > > Sorry for the slow response! No problem, we all have some phases where we don't have or find the time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, nikola. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Breaking a

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2612908 , @atirit wrote: > In D93938#2610568 , @curdeius wrote: > >> I hadn't had another look, because the CI still shows the test `AfterEnum` >> to be failing. > > I

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2613096 , @atirit wrote: > In D93938#2612952 , > @HazardyKnusperkeks wrote: > >> In my opinion you should then, either temporarily deactivate the test, or >> fix the b

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added a comment. I would like additional tests: - With at least 2 empty lines - With 0-2 empty lines without `verifyFormat` to demonstrate what is kept, added, and removed. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284 (!PreviousLine->

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:332-340 if (Changes[ScopeStart - 1].Tok->is(TT_FunctionDeclarationName) || (ScopeStart > Start + 1 && Ch

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2616044 , @atirit wrote: > In D93938#2614825 , > @HazardyKnusperkeks wrote: > >> If the bugs are (very) similar, I could live with one fix for both. >> Otherwise you s

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added a comment. Please also add an entry in the `clang/doc/ReleaseNotes.rst`. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284 (!PreviousLine->InPPDirective || !RootToken.HasUnescapedNewline)) -Newlines = std::min(1u, Newlines); +N

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks updated this revision to Diff 329755. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Addressed comments - Fixed handling of continued string literals when aligning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks added a comment. Please add a note to the release notes and also a test for a range based for with initializer (c++20). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 __

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3690-3691 +return (isAllowedByAfterEnum && isAllowedByShortEnums) || (Line.startsWith(tok::kw_class) && Style.BraceWrapping.AfterClass) || (Line.startsWith(tok::

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

HazardyKnusperkeks added a comment. In D109557#3066854 , @csmulhern wrote: > In D109557#3063681 , > @MyDeveloperDay wrote: > >> Personally I'm not convinced there wouldn't be people who want this for >> function

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Looks good. :) In D113826#3129229 , @Quuxplusone wrote: > Personally I'd remove the tests that are invalid expressions; but I don't > know what's the usual practice. Ship it

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

HazardyKnusperkeks added a comment. Should I copy my comments on the old file? Comment at: clang/lib/Format/BraceInserter.cpp:21-56 +bool SupportsAnyAutomaticBraces(FormatStyle &Style, bool insertion) { + if (insertion) { +if (Style.AutomaticBraces.AfterIf == FormatStyle::

[PATCH] D113826: [clang-format][c++2b] support removal of the space between auto and {} in P0849R8

HazardyKnusperkeks added a comment. In D113826#3129383 , @lichray wrote: > Thanks for the patch! It works for me, both for the `auto{x}` and `new > auto{x}` cases. Some corner cases left: > > void f() { T(&a)->n = 1; } > void f() { T{&a}->n = 1; }

[PATCH] D113844: [clang-format] [NFC] build clang-format with -Wall

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Is okay, but I think the compiler is a bit overreacting, since there is only one call (chain). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D114151: [clang-format] [C++20] [Module] clang-format couldn't recognize partitions

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. The current goal seems to be achieved. I have no idea what are acceptable module names or so, I've not yet looked into them. CHANGES SINCE LAST ACTION https://review

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

HazardyKnusperkeks added a comment. In D114142#3139756 , @MyDeveloperDay wrote: > I'm thinking that those cases are handled else where > > as S=1 on those elements (which means space required before) > > M=0 C=0 T=Unknown S=1 F=0 B=0 BK=0 P=0 Name=doub

[PATCH] D114142: [clang-format] [PR52527] can join * with /* to form an outside of comment error C4138

HazardyKnusperkeks added a comment. In D114142#3142122 , @MyDeveloperDay wrote: >> I only now this from the tests with `-debug`. Is there a way to get "normal" >> clang-format to print these? Or did you write a test for that to print the >> information

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks added a comment. This is dead, isn't it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22505/new/ https://reviews.llvm.org/D22505 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D80528: [clang-format][WIP] Run more stability FormatTests

HazardyKnusperkeks added a comment. It says tests are failing. But generally this seems to be a good idea. So one should take the tests one by one. I would do it, but currently I'm trying to wrap my head around some of the internals, to get my requires clauses correctly formatted. ;) Reposito

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks added a comment. In D22505#3147501 , @MyDeveloperDay wrote: > I think so, it came to the top because someone subscribed to it, I was > wondering if this was something that is still needed or if our existing > options cover this. > > I

[PATCH] D114430: [clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.

HazardyKnusperkeks added a comment. In D114430#3151082 , @klimek wrote: > Thanks for cleaning up after me, and sorry for the mess - do y'all have > clang-format set up as a presubmit or do you just remember to format manually? I think one "problem" is t

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:3274 + llvm::SmallVector FilesToLookFor; + // User provided clang-format file using -style=file:/path/to/format/file + // Check for explicit config filename MyDeveloperDay wrote:

[PATCH] D114583: [clang-format] Adjust braced list detection

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. That will be a pain in the ass to merge with my current changes, but looks good. In D114583#3153780 , @curdeius wrote

[PATCH] D114583: [clang-format] Adjust braced list detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Thanks for the update. (You forgot to add the context, but since it was already accepted it's okay.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114583/new/

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say after that there can not

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Give I[1

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115063: [clang-format][NFC] Rename variable so no shadowing happens

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the loo

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think th

[PATCH] D115065: [clang-format][NFC] Merge two calls of isOneOf

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115066: [clang-format][NFC] Reorder conditions

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prefer to

[PATCH] D115067: [clang-format][NFC] Use range based for

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. That's muc

[PATCH] D115068: [clang-format][NFC] Move static variable in scope

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Let only t

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not com

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository

[PATCH] D115072: [clang-format][NFC] Use member directly

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Instead of

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Delayed until D113319 is resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks updated this revision to Diff 391708. HazardyKnusperkeks retitled this revision from "[clang-format] Improve require handling" to "[clang-format] Improve require and concept handling". HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added reviewers: go

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks added a comment. Still WIP, not marking as changes planned, so that it pops up on your list and you can give me feedback. :) Comment at: clang/lib/Format/Format.cpp:1213 + // This is open for discussions! When will LLVM adapt C++20? + LLVMStyle.RequiresCla

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Is this valid code? Or did we just wrongly assign

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:1294-1296 + Previous->isOneOf(tok::l_paren, tok::comma, tok::colon, TT_BinaryOperator, +TT_ConditionalExpr) && !Previous->isOneOf(TT_DictLiteral, T

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks added a comment. No I don't think there is a performance penalty. **I** just don't like using pointers. I'm happy to drop this, if the Style says to use pointers. But from what I've seen in clang-format pointers are mostly used when it can be null, but there is a wild mix.

[PATCH] D113319: [clang-format] Improve require and concept handling

HazardyKnusperkeks marked 4 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3464-3483 + * ``RCPS_TwoLines`` (in configuration: ``TwoLines``) +The clause always gets its own line, and the content of the cla

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + Quuxplusone wr

[PATCH] D115060: [clang-format][NFC] Code Tidies in UnwrappedLineFormatter

HazardyKnusperkeks updated this revision to Diff 391853. HazardyKnusperkeks edited the summary of this revision. HazardyKnusperkeks added a comment. Fixed formatting and added a name for I[-1]. I[i + 1] is used in the loop condition, which also checks if i + 1 is valid, so do not give a name her

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3170615 , @curdeius wrote: > Deque, contrary to the vector, doesn't need to move the elements when > growing. I'm not sure if that's relevant here though. > Have you checked what's on average the maximum siz

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 391855. HazardyKnusperkeks added a comment. Formatting fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115064/new/ https://reviews.llvm.org/D115064 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/Unwra

[PATCH] D115069: [clang-format][NFC] Merge another two calls to isOneOf

HazardyKnusperkeks updated this revision to Diff 391857. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Incorporated feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115069/new/ https://reviews.llvm.org/D115069 Files: clang/lib/Format/

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

This revision was automatically updated to reflect the committed changes. Closed by commit rG25f637913fe3: [clang-format][NFC] Prefer pass by reference (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115061/new/ https

[PATCH] D115063: [clang-format][NFC] Rename variable so no shadowing happens

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7fdeda2c9db: [clang-format][NFC] Rename variable so no shadowing happens (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[PATCH] D115065: [clang-format][NFC] Merge two calls of isOneOf

This revision was automatically updated to reflect the committed changes. Closed by commit rG5878ac7d2db6: [clang-format][NFC] Merge two calls of isOneOf (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115065/new/ htt

[PATCH] D115066: [clang-format][NFC] Reorder conditions

This revision was automatically updated to reflect the committed changes. Closed by commit rG4483e9b5279b: [clang-format][NFC] Reorder conditions (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115066/new/ https://rev

[PATCH] D115068: [clang-format][NFC] Move static variable in scope

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d1c85454daa: [clang-format][NFC] Move static variable in scope (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115068/new/

[PATCH] D115067: [clang-format][NFC] Use range based for

This revision was automatically updated to reflect the committed changes. Closed by commit rGc25536e4feed: [clang-format][NFC] Use range based for (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115067/new/ https://re

[PATCH] D115070: [clang-format][NFC] Early return when nothing to do

This revision was automatically updated to reflect the committed changes. Closed by commit rG4041f16bb489: [clang-format][NFC] Early return when nothing to do (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115070/new/

[PATCH] D115071: [clang-format][NFC] Use range based for for fake l parens

This revision was automatically updated to reflect the committed changes. Closed by commit rG88fa4bfe1ec2: [clang-format][NFC] Use range based for for fake l parens (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11507

[PATCH] D115072: [clang-format][NFC] Use member directly

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e8678903523: [clang-format][NFC] Use member directly (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115072/new/ https://re

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks added a comment. This was not intended to be pushed, I forgot to move it out of the chunk. If we come to the conclusion that we want pointers I will revert this. If no one objects in the next say 3 days I will leave it so. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3171950 , @owenpan wrote: > In D115064#3170615 , @curdeius > wrote: > >> Maybe using `llvm::SmallVector` with some well-thought (data-based) static >> number of ele

[PATCH] D115061: [clang-format][NFC] Prefer pass by reference

HazardyKnusperkeks reopened this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. I will revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115061/new/ https://reviews.llvm.org/D115061 _

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added a comment. You have reverted some of your changes. Including all the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3172860 , @MyDeveloperDay wrote: > Even if you choose a number, beyond that number it behaves like a vector > (just without the data being on the stack), its really good for small vectors > but its not bad

[PATCH] D136154: Fix the continuation indenter

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:812-814 +if (Style.BreakBeforeBinaryOperators == FormatStyle::BOS_None || ++ Style.BreakBeforeBinaryOperators == FormatStyle::BOS_NonAssignment) CurrentState.LastSpace

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

HazardyKnusperkeks added a comment. In D129443#3867400 , @owenpan wrote: > In D129443#3867364 , @rymiel wrote: > >> How should I proceed with a stale rejecting review? > > You can commit as https://reviews.llvm.or

[PATCH] D136154: [clang-format] Fix the continuation indenter

HazardyKnusperkeks added a comment. In D136154#3867461 , @hel-ableton wrote: >> must have been introduced somewhere between 7.1.0 and 10.0.0 > > In fact, someone in our team thought that this must have been introduced > exactly with this commit: > > htt

[PATCH] D136154: [clang-format] Fix the continuation indenter

HazardyKnusperkeks added a comment. In D136154#3868036 , @hel-ableton wrote: > In D136154#3867935 , > @MyDeveloperDay wrote: > >> You've dropped the test on your most recent updated > > Oh, that's why it appeare

[PATCH] D135972: [clang-format] Don't crash on malformed preprocessor conditions

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1217 + assert(PPBranchLevel >= -1); + if (PPBranchLevel <= -1) +conditionalCompilationStart(/*Unreachable=*/true); You assert >= -1, that means this has to be ==

[PATCH] D135866: [clang-format][NFC] Fix comment grammer in ContinuationIndenter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG11b8795bb94c: [clang-format][NFC] Fix comment grammer in ContinuationIndenter (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorep

[PATCH] D135872: [clang-format] Handle unions like structs and classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5755f44f0cf: [clang-format] Handle unions like structs and classes (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D135871: [clang-format][NFC] Handle language specific stuff at the top...

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked 2 inline comments as done. Closed by commit rG006bf8d81770: [clang-format][NFC] Handle language specific stuff at the top... (authored by Haza

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks updated this revision to Diff 470272. HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added a comment. Override in `canBreak()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Form

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D136658: [clang-format] Move InsertBraces unit tests out of FormatTest.cpp

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D136658#3883372 , @rymiel wrote: > Is the intent here to somewhat reduce the 30k line behemoth of FormatTest.cpp? I'm all i

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1345 while (CurrentToken) { -if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator)) +if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) {

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks added a comment. Do you still intend to work on this? Otherwise I will commandeer and abandon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___ cfe-commits mailing list cfe-comm

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks updated this revision to Diff 470914. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Format/ContinuationIndenter.c

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:336 + Previous.MatchingParen && Previous.MatchingParen->Previous && + Previous.MatchingParen->Previous->is(tok::r_brace) && + Previous.MatchingParen->Previous->MatchingP

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

HazardyKnusperkeks updated this revision to Diff 470921. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136635/new/ https://reviews.llvm.org/D136635 Files: clang/lib/Format/TokenAnnotator.cpp c

[PATCH] D131789: [clang-tools-extra] Rewrite prints in python3 compatible way

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Maybe add the [NFC] tag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131789/new/ https://reviews.llvm.org/D131789 ___

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. Nice patch. Could you please also extend the test in `TokenAnnotatorTests.cpp`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D131978#3727084 , @rymiel wrote: > Added negation unary operator check to TokenAnnotatorTest > > Is this what you meant? Alt

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. In D131978#3729644 , @rymiel wrote: > It seems that even with this patch, there is seemingly weird formatting with > the negation in requires clauses, such as: > > template > requires !F > int bar(T

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:379 /// \version 3.7 bool AlignTrailingComments; Maybe you can port this to `AlignConsecutiveStyle`? `AcrossComments` would not affect anything in this context. =

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

HazardyKnusperkeks added a comment. In D132189#3733747 , @rymiel wrote: > There could also possibly be a TokenAnnotatorTest checking for > `TT_FunctionAnnotationRParen`, but there wasn't an existing one similar to > it, so I was unsure if I should add o

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. Please run `clang/docs/tools/dump_format_style.py`. Comment at: clang/include/clang/Format/Format.h:3189 + /// to DefinitionBlockSpacing. + /// \version 15 + unsigned DefinitionBlockSpacing; This isn't going to land in 15.

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. In D132256#3738407 , @alecto wrote: > In D132256#3736076 , > @HazardyKnusperkeks wrote: > >> Do we want to define the behavior of `MaxEmptyLinesToKeep < >> DefinitionBlockSpac

[PATCH] D132256: [clang-format] Add DefinitionBlockSpacing option

HazardyKnusperkeks added a comment. In D132256#3740714 , @alecto wrote: > If possible I would like to error out if MaxEmptyLinesToKeep < > DefinitionBlockSpacing, because that case is probably a mistake on the part > of the user, and a failure would be

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. Please mark things as done. Comment at: clang/include/clang/Format/Format.h:297 AlignConsecutiveStyle AlignConsecutiveDeclarations; + /// Style of aligning consecutive trailing comments. + /// Run clang/docs/tools/dump_f

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:649 IO.mapOptional("AlignOperands", Style.AlignOperands); -IO.mapOptional("AlignTrailingComments", Style.AlignTrailingComments); IO.mapOptional("AllowAllArgumentsOnNextLine", -

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

HazardyKnusperkeks added a comment. Please reupload the diff with the context. Comment at: clang/unittests/Format/FormatTest.cpp:5785 + "}"; +EXPECT_EQ(Expected, format(ToFormat, Style)); +EXPECT_EQ(Expected, format(Expected, Style)); -

[PATCH] D134049: [clang-format] Disallow trailing return arrows to be operators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:2615 + if (Current->isOneOf(tok::period, tok::arrow) && + !Current->is(TT_TrailingRe

[PATCH] D134042: [clang-format] Fix alignment in #else preprocessor blocks

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Looks good, please wait for other reviewers. Comment at: clang/unittests/Format/FormatTest.cpp:5747 +TEST_F(FormatTest, FormatAlignInsidePreprocessorE

[PATCH] D134103: [clang-format] Skip token annotation in passes that don't need it

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/Format.cpp:3276 Passes.emplace_back([&](const Environment &Env) { -return BracesInserter(Env, Expanded

<    1   2   3   4   5   6   7   8   9   10   >