HazardyKnusperkeks added a comment.

I would like additional tests:

- With at least 2 empty lines
- With 0-2 empty lines without `verifyFormat` to demonstrate what is kept, 
added, and removed.



================
Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284
       (!PreviousLine->InPPDirective || !RootToken.HasUnescapedNewline))
-    Newlines = std::min(1u, Newlines);
+    Newlines = Style.EmptyLinesAfterAccessModifier + 1u;
 
----------------
I don't know, I'm just asking:
Shouldn't this be `Newlines = std::min(Newlines, 
Style.EmptyLinesAfterAccessModifier + 1u);`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98237/new/

https://reviews.llvm.org/D98237

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to