HazardyKnusperkeks added a comment. In D93938#2612908 <https://reviews.llvm.org/D93938#2612908>, @atirit wrote:
> In D93938#2610568 <https://reviews.llvm.org/D93938#2610568>, @curdeius wrote: > >> I hadn't had another look, because the CI still shows the test `AfterEnum` >> to be failing. > > I know the test fails; it's due to a separate bug wherein `AfterEnum: true` > and `AllowShortEnumsOnASingleLine: true` produces incorrect behaviour. The > unit test has the correct expectation. I've also already mentioned this. > > In D93938#2476691 <https://reviews.llvm.org/D93938#2476691>, @atirit wrote: > >> The first test fails due to the aforementioned corner case. > > I could modify the unit test to expect the currently broken behaviour and > then fix the test later alongside a fix for the corner case. In my opinion you should then, either temporarily deactivate the test, or fix the bug first. A failing test blocks the pipeline and confuses everyone working on the project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93938/new/ https://reviews.llvm.org/D93938 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
