HazardyKnusperkeks added a comment.
Please run `clang/docs/tools/dump_format_style.py`.
================
Comment at: clang/include/clang/Format/Format.h:3189
+ /// to DefinitionBlockSpacing.
+ /// \version 15
+ unsigned DefinitionBlockSpacing;
----------------
This isn't going to land in 15.
================
Comment at: clang/include/clang/Format/Format.h:3190
+ /// \version 15
+ unsigned DefinitionBlockSpacing;
+
----------------
Please sort alphabetically.
================
Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:609
+ Style.DefinitionBlockSpacing = 2;
+ /// This has to be set, otherwise the extra lines will be removed
+ Style.MaxEmptyLinesToKeep = 2;
----------------
================
Comment at: clang/unittests/Format/DefinitionBlockSeparatorTest.cpp:610
+ /// This has to be set, otherwise the extra lines will be removed
+ Style.MaxEmptyLinesToKeep = 2;
+ verifyFormat("int foo(int i, int j) {\n"
----------------
Do we want to define the behavior of `MaxEmptyLinesToKeep <
DefinitionBlockSpacing`? Then we need tests for that!
Tests with `MaxEmptyLinesToKeep < DefinitionBlockSpacing` and initially more
than `DefinitionBlockSpacing` should definitely be there.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132256/new/
https://reviews.llvm.org/D132256
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
