[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:797 +AlignConsecutiveMacros: + Enabled: true + AcrossEmptyLines: true MyDeveloperDay wrote: > why do we need Enabled? > > isn't it just > > ``` > false: >

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:785 + - Consecutive + - AcrossEmptyLines + - AcrossComments yusuke-kadowaki wrote: > MyDeveloperDay wrote: > > may be AcrossEmptyLines should be a number (to mean the

[PATCH] D132911: [clang-format] Fix annotating when deleting array of pointers

HazardyKnusperkeks added a comment. Please mark comments as done, when the discussion has ended. Comment at: clang/lib/Format/TokenAnnotator.cpp:2376 +const FormatToken *Prev = PrevToken; +if (Prev->is(tok::r_square) && (Prev = Prev->getPreviousNonComment()) && +

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:141 - /// Alignment options. - /// - /// They can also be read as a whole for compatibility. The choices are: + /// Alignment styles of ``AlignConsecutiveStyle`` are: /// - None ---

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks added a comment. You have to make the change in the `Format.h` and run `clang/docs/tools/dump_format_style.py` which generates the rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087

[PATCH] D133093: [clang-format] Fix a bug in merging blocks with a wrapped l_brace

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:716 +auto IsCtrlStmt = [](const auto &Line) { + return Line.First->isOneOf(tok::k

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In my opinion we are nearly done. Comment at: clang/docs/ClangFormatStyleOptions.rst:3698 - QualifierOrder: ['inline', 'static', 'type', 'const'] + QualifierOrder: ['inline', 'static' , 'type', 'const'] Anyone k

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In D132131#3766590 , @MyDeveloperDay wrote: > Is there a technical reason for reusing the struct rather than introducing a > new one? I see, good point. Really only if one would port the implementation to `AlignToke

[PATCH] D131750: [clang-format] Distinguish logical and after bracket from reference

HazardyKnusperkeks added a subscriber: tstellar. HazardyKnusperkeks added a comment. You have to ask @tstellar to cherry-pick it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131750/new/ https://reviews.llvm.org/D131750 __

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks added a comment. In D133087#3768928 , @Passw wrote: > I do not have commit access, please help to commit this change. > Thanks. Please state name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087

[PATCH] D129934: [clang-format][docs] Fix incorrect 'clang-format 4' option markers

This revision was automatically updated to reflect the committed changes. Closed by commit rG961fd77687d2: [clang-format][docs] Fix incorrect 'clang-format 4' option markers (authored by kuzkry, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

HazardyKnusperkeks added a comment. In D126365#3736864 , @Eitot wrote: > In D126365#3565891 , @curdeius > wrote: > >> @Eitot, do you need help landing this? > > I do need help. Could someone land this for me? Pl

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks added a comment. In D133087#3768928 , @Passw wrote: > I do not have commit access, please help to commit this change. > Thanks. Please state a name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1330

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. Please state a name and email for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978 ___ cfe-commits mailing list c

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

HazardyKnusperkeks added a comment. Can you please rebase the patch, it doesn't apply anymore. Sorry for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 _

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf54d42abcf82: [clang-format] Don't put `noexcept` on empty line following constructor (authored by rymiel, committed by HazardyKnusperkeks). Reposi

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6e7752f8e14: [clang-format] Allow `throw` to be a keyword in front of casts (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3dd10a8b48: [clang-format] Concepts: allow identifiers after negation (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG LLVM

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In D132131#3770170 , @MyDeveloperDay wrote: > My personal preference is a new struct without Enabled We go for a new struct. But why without enabled? Currently we have a boolean on/off switch `AlignTrailingComments`.

[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

This revision was automatically updated to reflect the committed changes. Closed by commit rG2adf241592b3: [clang-format] [doc] Fix example of wrapping class definitions (authored by Passw, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG247613548bac: [clang-format] Change heuristic for locating lambda template arguments (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

HazardyKnusperkeks added a comment. Just a note, I had to edit your patch. Did you create it with git diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 ___

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. MyDeveloperDay wrote: > yusuke-kadowaki wrote: > > MyDeveloperDay wrot

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In D132131#3776956 , @MyDeveloperDay wrote: > an example of the exact reason why we should not reuse the same struct... > https://github.com/llvm/llvm-project/issues/57464 Just a bit rephrasing. In D132131#3777004

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:469 + /// Different styles for merging short case labels. + enum ShortCaseLabelStyle : int8_t { +/// Never merge case code While we're at it, shouldn't there be a `Lea

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

HazardyKnusperkeks added inline comments. Comment at: clang/.clang-format:2 BasedOnStyle: LLVM +RemoveBracesLLVM: true Unrelated. Comment at: clang/include/clang/Format/Format.h:2063 + /// otherwise it will scan until the closing `]` to deter

[PATCH] D133589: [clang-format] JSON formatting add new option for controlling newlines in json arrays

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1965 (Style.JavaScriptQuotes == FormatStyle::JSQS_Double && - !Input.startswith("\'"))) { + !Input.startswith("\'"))) continue; These

[PATCH] D133571: [clang-format] Introduce NoFallThrough option into AllowShortCaseLabelsOnASingleLine

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:469 + /// Different styles for merging short case labels. + enum ShortCaseLabelStyle : int8_t { +/// Never merge case code MyDeveloperDay wrote: > HazardyKnusperkeks w

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:865 + + * ``TCAS_DontAlign`` (in configuration: ``DontAlign``) +Don't align trailing comments. yusuke-kadowaki wrote: > HazardyKnusperkeks wrote: > > yusuke-kadowaki

[PATCH] D127873: [clang-format] Fix misplacement of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3614559 , @jackhong12 wrote: > Sorry, I don't have commit access. @HazardyKnusperkeks, could you help me > commit it? > > If I want to contribute to LLVM in the future, how do I get the commit > permission

[PATCH] D128709: [clang-format] Handle Verilog attributes

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems straight forward. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128709/new/ https://reviews.llvm.org/D128709

[PATCH] D128712: [clang-format] Handle Verilog modules

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:1742 + /// Returns whether \p Tok is a Verilog keyword that opens a module, etc. + bool isVerilogHier(const FormatToken &Tok) const { +if (Tok.endsSequence(kw_function, kw_with)) --

[PATCH] D128714: [clang-format] Handle Verilog case statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:1265 LLVMStyle.IndentAccessModifiers = false; - LLVMStyle.IndentCaseLabels = false; + LLVMStyle.IndentCaseLabels = LLVMStyle.isVerilog() ? true : false; LLVMStyle.IndentCaseBlocks = false; -

[PATCH] D129064: [clang-format] Avoid crash in LevelIndentTracker.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:62-70 while (IndentForLevel.size() <= Line.Level) IndentForLevel.push_back(-1); if (Line.InPPDirective) { unsigned IndentWidth = (Style.PPIndentWid

[PATCH] D129105: [clang-format][NFC] Clean up IndentForLevel in LevelIndentTracker

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:82-83 +if (Size <= Line.Level) + IndentForLevel.insert(IndentForLevel.end(), Line.Level - Size + 1, +UnknownIndent ? -1 : Indent); } -

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks added a comment. In D121756#3407320 , @owenpan wrote: > In D121756#3398165 , @sstwcw wrote: > >> It turned out this patch does change behavior. >> >> - while ( >> - FormatTok->isOneOf(

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage NFC

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. I cannot view the diff between the last two revisions: > Unhandled Exception ("Exception") > Found unknown intradiff source line, expected a line beginning with "+", "-", > or " " (space): \ No newline at end of file

[PATCH] D126845: [clang-format] Handle Verilog numbers and operators

HazardyKnusperkeks added a comment. In D126845#3675721 , @sstwcw wrote: > Are there any problems with this revision? The ones that depend on it are > approved. Sorry, last time you updated I had no time, and then I forgot. Repository: rG LLVM Githu

[PATCH] D88299: [clang-format] Add MacroUnexpander.

HazardyKnusperkeks added a comment. A bit surprising such a big change... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 ___ cfe-commits mailing list cfe-commits

[PATCH] D106112: [clang-format] Break an unwrapped line at a K&R C parameter decl

HazardyKnusperkeks added a comment. In D106112#2883301 , @curdeius wrote: > Looks okay, but I was wondering if we don't want to guard all K&R-related > changes behind e.g. ```Standard: Cpp78``, so as not to possibly introduce > strange bugs in newer mod

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2893672 , @MyDeveloperDay wrote: > This feels like there is some overlap with D93938: [clang-format] Fixed > AfterEnum handling Yeah that may be, but it is stale for over

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. Looks good, could you also add a note in the relasenotes.rst? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://reviews.llvm.org/D106349 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2900770 , @m1cha wrote: > In D106349#2897400 , > @HazardyKnusperkeks wrote: > >> Looks good, could you also add a note in the relasenotes.rst? > > Sure > > Can I do

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2900803 , @baramin wrote: > You are right. > > The problem is in > > FromLegacyTimestamp(monitorFrequencyUsec), > seconds(std::uint64_t(maxSampleAge)), maxKeepSamples)); > > line indentation. It is 6 instead

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:3800 + FormatStyle Style = getLLVMStyle(); + Style.BreakBeforeInlineASMColon = true; verifyFormat( I already gave my go in the past, but now I have to wonder, why are

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, baramin. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This amend

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks added a comment. In D98214#2901304 , @baramin wrote: > This is true. > .clang-format: > > Language:Cpp > AlignConsecutiveAssignments: Consecutive > BinPackArguments: false > BinPackParameters: false > ColumnLimit:

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Then I am sorry that I've missed that before. But you need to change your `bool` to an `enum` and also model the current behavior, so that there is no change

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75f6a795ee0f: [clang-format] Fix aligning with linebreaks #2 (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks added a comment. In D106773#2912732 , @curdeius wrote: > This bug fix should probably be cherry-picked into 13.x branch. WDYT? Yeah, I wrote already an email about it. Or can (and should) I push it myself? Repository: rG LLVM Githu

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. And format what clang-format says. Then it looks good to me. Comment at: clang/unittests/Format/FormatTest.cpp:6250 + verifyFormat("asm volatile(\"lng\",\n" + " : : val);", + Style)

[PATCH] D106773: [clang-format] Fix aligning with linebreaks #2

HazardyKnusperkeks added a comment. It's picked: 0e3777bb0ad94ecd1429dc96409177cdccf39bdd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106773/new/ https://reviews.llvm.org/D106

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. No one objects, you can push it. Or if you don't have commit access (and don't want to, or don't want to wait for it) we can push it, then please state name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106349/new/ https://

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for your patience. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2759 + IncludeName = + StringRef(Twine("<", IncludeName).concat(Twine(">")).str()); +} How does that not go out of scope and I have a dangling referenc

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

HazardyKnusperkeks added a comment. Your patches are not directly applicable. You have --- clang/include/clang/Format/Format.h +++ clang/include/clang/Format/Format.h instead of --- a/clang/include/clang/Format/Format.h +++ b/clang/include/clang/Format/Format.h which results in $ gi

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4d68bf65ef: [clang-format] Handle builtins in constraint expression (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D120774?vs=413430&id=414881#toc Repository: r

[PATCH] D120631: [clang-format][docs] Fix incorrect 'clang-format 12' option markers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9106a07f1fcb: [clang-format][docs] Fix incorrect 'clang-format 12' option markers (authored by kuzkry, committed by HazardyKnusperkeks). Repository

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

HazardyKnusperkeks added a comment. You either get commit access https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access or ask someone of us to push it for you. In the latter case we need a name and mail for the commit. I recommend the former, especially if you want to contribute m

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, curdeius, MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:424-425 - if (CurrentToken->is(tok::l_brace)) -Left->setType(TT_Unknown); // Not TT_ObjCBlockLParen + if (CurrentToken->is(tok::l_brace) && OpeningParen.is(TT_ObjCBlockL

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks added a comment. Why limit to macros, could it be a member of AlignConsecutiveStyle and apply to the other stuff as well? Comment at: clang/include/clang/Format/Format.h:256 + /// \endcode + /// \version 14 + unsigned AlignConsecutiveMacrosMinWidth; -

[PATCH] D121557: [clang-format][NFC] Rename Left to OpeningParen...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks updated this revision to Diff 414956. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Split rename and bug fix CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121550/new/ https://reviews.llvm.org/D121550 Files: clang/lib/Forma

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:215 +assert(CurrentToken->Previous && "Unknown previous token"); +FormatToken &OpeningParen = *CurrentToken->Previous; +assert(OpeningParen.is(tok::l_paren)); cu

[PATCH] D121558: [clang-format][NFC] Left renamed to OpeningBrace...

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D121559: [clang-format] Fix crash on asm block with label

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D112019: [clang-format] [PR51412] AlignConsecutiveMacros fights with Visual Studio and resource.h

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D112019#3378031 , @MyDeveloperDay wrote: > In D112019#3378024 , > @HazardyKnusperkeks wrote: > >> Why limit to macros, could it b

[PATCH] D121557: [clang-format][NFC] Rename Left to OpeningParen...

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d8e907016ef: [clang-format][NFC] Rename Left to OpeningParen... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121557/new/

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

This revision was automatically updated to reflect the committed changes. Closed by commit rGacd17a2be81a: [clang-format] Fix crash on invalid requires expression (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121550/

[PATCH] D121558: [clang-format][NFC] Left renamed to OpeningBrace...

This revision was automatically updated to reflect the committed changes. Closed by commit rGb7494a1d72c1: [clang-format][NFC] Left renamed to OpeningBrace... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121558/new/

[PATCH] D121559: [clang-format] Fix crash on asm block with label

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35abbf166d4a: [clang-format] Fix crash on asm block with label (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscri

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:615 +TEST_F(TokenAnnotatorTest, UnderstandsObjCBlock) { + auto Tokens = annotate("int (^)() = ^ ()\n" I hope the name is appropriate, I don't know shit about ob

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

HazardyKnusperkeks added a comment. In D121550#3381903 , @owenpan wrote: > Nvm. See https://github.com/llvm/llvm-project/issues/54384. Phew. I thought I needed a fix for the fix, for the fix, for the fix. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks added a comment. Some test with a main header and blocks would be nice. Comment at: clang/lib/Format/Format.cpp:2779 /*CheckMainHeader=*/!MainIncludeFound && FirstIncludeBlock); -int Priority = Categories.getSortIncludePriority( -

[PATCH] D121596: [clang-format] Fix crash with ObjC Blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG1db8112311c7: [clang-format] Fix crash with ObjC Blocks (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121596/new/ https://

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks added a comment. In D121370#3383574 , @HazardyKnusperkeks wrote: > Some test with a main header and blocks would be nice. This one please. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D121758: [clang-format] Add support for formatting Verilog code

HazardyKnusperkeks added a comment. This is an enormous patch. @MyDeveloperDay mentioned different places which could be separate patches, but in addition could the adding of the verilog language be split up, so that one can comprehend the patch in a reasonable time? Comment

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2161 -if (PrevToken->isOneOf(tok::l_paren, tok::l_square, tok::l_brace, - tok::comma, tok::semi, tok::k

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3069 -bool TokenAnnotator::spaceRequiredBetween(const AnnotatedLine &Line, - const FormatToken &Left, - co

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:907 + KEYWORD(infer, 0) \ + KEYWORD(is, ATTR_JS_KEYWORD | ATTR_CSHARP_KEYWORD | ATTR_CSHARP_KEYWORD) \ + KEYWORD(let, ATTR_JS_K

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks added a comment. Please add tests in TokenAnnotatorTests for `TT_ConditionLParen`. Comment at: clang/lib/Format/FormatToken.h:521 + /// statement's condition like if or while. + bool isConditionLParen(bool IncludeSpecial) const { +if (!is(tok::l_paren))

[PATCH] D121757: [clang-format] Take out common code for parsing blocks

HazardyKnusperkeks added a comment. Looks basically okay. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2851 -addUnwrappedLine(); -++Line->Level; -parseStructuralElement(); This is completely missing. Didn't it affect anything?

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2138 + +// These keywords are deliberately not included here. They are either +// included in determineStarAmpUsage or determinePlusMinusCaretUsage. I'm not sure abo

[PATCH] D121753: [clang-format] Use a macro for non-C keywords

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:992-999 + enum { +ATTR_JS_KEYWORD = 0x1, +ATTR_CSHARP_KEYWORD = 0x2, + }; + unsigned getAttrs(const FormatToken &Tok) const { +auto At = KeywordAttr.find(Tok.Tok.getIdentifierInfo(

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:1431-1442 +TT_AttributeMacro, TT_BracedListLBrace, TT_ClassLBrace, +TT_Com

[PATCH] D121907: [clang-format] Use an enum for context types.

HazardyKnusperkeks added a comment. In D121907#3390226 , @MyDeveloperDay wrote: > So out of interest, what is the reason? my assumption is that you wanted to > add more for Verilog and you felt adding the extra bools was the wrong design > and its bett

[PATCH] D121916: [clang-format] [doc] Add script to automatically update help output in ClangFormat.rst.

HazardyKnusperkeks added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:105 +SortIncludes("sort-includes", + cl::desc("If set, overrides the include sorting behavior\n" + "determined by the SortIncludes style fla

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2146-2147 +// know how they can be followed by a star or amp. +// co_await, delete - It doesn't make sense to have them followed by a unary +// `+` or `-`. +if (PrevToke

[PATCH] D121755: [clang-format] Join spaceRequiredBefore and spaceRequiredBetween

HazardyKnusperkeks added a comment. FWIW I proposed to go this way: https://discourse.llvm.org/t/clang-format-spacerequiredbefore-vs-spacerequiredbetween/60901/5?u=hazardyknusperkeks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121755/new/ https:

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. But please fix the format. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121370/new/ https://reviews.llvm.org/D121370 ___

[PATCH] D121450: [clang-format] Handle attributes before case label.

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1826 + if (Style.isJavaScript() && Line->MustBeDeclaration) +// 'case: string' field declaration. +break; Here's the loop. In the switch before tha

[PATCH] D121370: [clang-format] SortIncludes should support "@import" lines in Objective-C

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/Format.cpp:2694-2697 +if (!Matches[i].empty()) { + res = Matches[i]; + break; +} Comment at: clang/lib/Format/F

[PATCH] D121756: [clang-format] Clean up code looking for if statements

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. Just a formality. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121756/new/ https://reviews.llvm.org/D121756 ___

[PATCH] D121754: [clang-format] Refactor determineStarAmpUsage

HazardyKnusperkeks added a comment. Just a side note, I often get this on your changes: Unhandled Exception ("Exception") Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file . Comment at: clang/unittests/For

[PATCH] D122064: [clang-format][docs] Fix incorrect 'clang-format 11' option markers

HazardyKnusperkeks added a comment. In D122064#3430644 , @kuzkry wrote: > Kind reminder, please deliver this revision. I don't have write access. It's not forgotten, at least by me, but I currently have no time to update my LLVM, so I could push anythin

[PATCH] D123450: [clang-format] Parse Verilog if statements

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/FormatToken.h:374 + /// Verilog we want to treat the backtick like a hash. + tok::TokenKind AliasToken = tok::unknown; + Can't we do that with a type? I'm not very happy about the alias, be

  1   2   3   4   5   6   7   8   9   10   >