[PATCH] D98214: [clang-format] Fix aligning with linebreaks

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added a comment.

In D98214#2901304 <https://reviews.llvm.org/D98214#2901304>, @baramin wrote:

> This is true.
>  .clang-format:
>
>   Language:        Cpp
>   AlignConsecutiveAssignments: Consecutive
>   BinPackArguments: false
>   BinPackParameters: false
>   ColumnLimit:     120
>   ConstructorInitializerIndentWidth: 4
>   ContinuationIndentWidth: 4
>   IndentWidth:     4
>   TabWidth:        4
>   UseCRLF:         false
>   UseTab:          Never
>
> Format, that looks like a regression for me:
> Now:
>
>   void SomeFunc() {
>       newWatcher.maxAgeUsec = ToLegacyTimestamp(GetMaxAge(
>           FromLegacyTimestamp<milliseconds>(monitorFrequencyUsec), 
> seconds(std::uint64_t(maxSampleAge)), maxKeepSamples));
>       newWatcher.maxAge     = ToLegacyTimestamp(GetMaxAge(
>               FromLegacyTimestamp<milliseconds>(monitorFrequencyUsec), 
> seconds(std::uint64_t(maxSampleAge)), maxKeepSamples));
>       newWatcher.max        = ToLegacyTimestamp(GetMaxAge(
>                  FromLegacyTimestamp<milliseconds>(monitorFrequencyUsec), 
> seconds(std::uint64_t(maxSampleAge)), maxKeepSamples));
>   }
>
> Before:
>
>   void SomeFunc() {
>       newWatcher.maxAgeUsec = ToLegacyTimestamp(GetMaxAge(
>           FromLegacyTimestamp<milliseconds>(monitorFrequencyUsec), 
> seconds(std::uint64_t(maxSampleAge)), maxKeepSamples));
>       newWatcher.maxAge     = ToLegacyTimestamp(GetMaxAge(
>           FromLegacyTimestamp<milliseconds>(monitorFrequencyUsec), 
> seconds(std::uint64_t(maxSampleAge)), maxKeepSamples));
>       newWatcher.max        = ToLegacyTimestamp(GetMaxAge(
>           FromLegacyTimestamp<milliseconds>(monitorFrequencyUsec), 
> seconds(std::uint64_t(maxSampleAge)), maxKeepSamples));
>   }

The fix is in D106773 <https://reviews.llvm.org/D106773>, please have a look at 
it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98214/new/

https://reviews.llvm.org/D98214

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits