HazardyKnusperkeks added inline comments.

================
Comment at: clang/unittests/Format/FormatTest.cpp:3800
+  FormatStyle Style = getLLVMStyle();
+  Style.BreakBeforeInlineASMColon = true;
   verifyFormat(
----------------
I already gave my go in the past, but now I have to wonder, why are you setting 
this to `true` here? Does this mean before your change clang-format did behave 
as if the option is `true`? If that's the case please set the default also to 
`true`. If the old behavior is neither `true` nor `false` we have to find 
something different.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91950/new/

https://reviews.llvm.org/D91950

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to