[PATCH] D105960: [clang][driver][darwin] Add driver support for Mac Catalyst

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. This patch is the last patch in the series of patches for the Mac Catalyst support in clang. It adds dri

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Looks good to me. Can you post the patch with the full context next time so that it's easier to review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D109402: Make 'align-mismatch' warning work without an associated function declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa43d1aa85256: [clang] Make 'align-mismatch' warning work without an associated function… (authored by arphaman). Herald added a project: clang. Repo

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

arphaman created this revision. arphaman added reviewers: ravikandhadai, ahatanak, mbenfield. Herald added a subscriber: ributzka. arphaman requested review of this revision. Herald added a project: clang. The `__block` Objective-C pointers can be set but not used due to a commonly used lifetime

[PATCH] D112850: [clang] 'unused-but-set-variable' warning should not apply to __block objective-c pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGa00944ebeab1: [clang] 'unused-but-set-variable' warning should not apply to __block objective… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman created this revision. arphaman added reviewers: steven_wu, MForster. Herald added subscribers: ributzka, jkorous. Herald added a reviewer: aaron.ballman. arphaman requested review of this revision. The attribute with declref is incompatible with Apple's SDKs, as the declref at the point

[PATCH] D98450: [clang] store an identifer instead of declref for ns_error_domain attribute

arphaman added a comment. The original implementation of the attribute on GitHub.com/apple/llvm-project also used the identifier instead of the declref, so we would like to go back to that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98450/new/ https://reviews.llvm.org/D98450 _

[PATCH] D98458: Revert "[CodeGenModule] Set dso_local for Mach-O GlobalValue"

arphaman created this revision. arphaman added reviewers: davide, MaskRay. Herald added subscribers: ributzka, jkorous. arphaman requested review of this revision. Herald added a project: clang. This reverts commit 809a1e0ffd7af40ee27270ff8ba2ffc927330e71

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

arphaman added a comment. I will commit this on behalf of @beccadax as she doesn't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112773/new/ https://reviews.llvm.org/D112773 ___ c

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax, committed by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Sorry for delay, this LGTM. Thanks for doing this cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114163/new/ https://reviews.llvm.or

[PATCH] D114968: [clang][deps] Avoid reading file for stat calls

arphaman added a comment. In D114968#3168123 , @dexonsmith wrote: > In D114968#3167519 , @jansvoboda11 > wrote: > >> Assuming the filesystem doesn't change during dependency scanning, this >> change keeps the c

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, this looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729 ___

[PATCH] D127442: [Sema] Fix a bug where clang doesn't detect uses of unavailable decls in C++ base or member initializers

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127442/new/ https://reviews.llvm.org/D127442 ___

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman created this revision. arphaman added reviewers: bnbarham, ravikandhadai. Herald added a subscriber: ributzka. Herald added a reviewer: aaron.ballman. Herald added a project: All. arphaman requested review of this revision. Allow the user to specify a concrete USR in the `external_source_

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 487944. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. Updated to address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. In D141324#4039629 , @erichkeane wrote: > I'm disturbed that the string-literal diagnostic you changed never shows up > in the tests. I suspect this attribute needs significantly better test > coverage. Please elaborate. All

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

arphaman accepted this revision. arphaman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

arphaman added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:69 + if (PA.isGNUAttribute()) +Diag(PA.getLoc(), diag::err_objc_unexpected_attr); + } I think it might be better to still report this error at the location of the `@` token (

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks, this LGTM. You might want to get another reviewers approval as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 __

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 491865. arphaman added a comment. updated patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clang/Ba

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") =

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. @erichkeane ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 495165. arphaman added a comment. - Updated version to be the date. - Updated release notes. - Fixed a bug in my changed tablegen code in previous patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Fi

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 495202. arphaman added a comment. updated test file with correct version check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Attr.td c

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. I posted the Swift patch here: https://github.com/apple/swift/pull/63002 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 490214. arphaman added a comment. add more test coverage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. @erichkeane I've added more test coverage with different USR values, C++ decls and some dependent C++ decls too. How does it look now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 _

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > I don't think we can do

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > arphaman wrote: > > > a

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 490547. arphaman added a comment. Updated `__has_attribute(attribute_external_source_symbol)` to return a version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files: clang/include/clang/Basic/Attr.t

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:962 + let Spellings = [Clang<"external_source_symbol", /*allowInC=*/1, + /*version=*/2>]; let Args = [StringArgument<"language", 1>, erichkeane wrote: > For standa

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:3318 +for (const auto &Spelling : Attr->getValueAsListOfDefs("Spellings")) { + if (Spelling->getValueAsString("Variety") == Variety || + Spelling->getValueAsString("Variety") =

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Sure, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. @Jake-Egan Do you happen to have suggestions for how to try to reproduce this? Looking at the failure it looks like this CI job somehow was unable to be affected by this change, for instance the CI output of `index-concept-kind.cpp` does not have any concepts output:

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. @Jake-Egan I'm going to disable these tests for `aix` for now to unblock the bot as they're still failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://reviews.llvm.org/D126031 _

[PATCH] D126031: [libclang] add supporting for indexing/visiting C++ concepts

arphaman added a comment. Marked them as unsupported on AIX in 1b34f1e996565bc5e4f2be14b89f881f8fe0f3b9 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126031/new/ https://review

[PATCH] D126332: [clang] Fix the begin location of concepts specialization expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79e09af1d6e1: [clang] Fix the begin location of concepts specialization expression (authored by arphaman). Herald added a project: clang. Herald adde

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

arphaman added a comment. I will revert this for now, as this change broke Darwin CI: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/37169/ Clang.Tooling.clang-check-mac-libcxx-abspath.cpp Clang.Tooling.clang-check-mac-libcxx-relpath.cpp @ldionne has a patch for these te

[PATCH] D131858: [clang] Track the templated entity in type substitution.

arphaman added a comment. Herald added a reviewer: njames93. Hi @mizvekov. This change has caused a failure in Clang's stage 2 CI on the green dragon Darwin CI: https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. Assertion failed: (lvaluePath->getType() == elemTy && "Une

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

arphaman accepted this revision. arphaman added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:43 + +class ModuleDepCollectorPP final : public PPCallbacks { +public: --

[PATCH] D69643: [clang][ScanDeps] Fix issue with multiple commands with the same input.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69643/new/ https://reviews.llvm.org/D69643 ___

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

arphaman added a comment. +1, Apple's clang has an `#ifdef 0` around this code. Comment at: clang/lib/Basic/Version.cpp:143 llvm::raw_string_ostream OS(buf); #ifdef CLANG_VENDOR OS << CLANG_VENDOR; This use of `CLANG_VENDOR` should be removed as well pre

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

arphaman added inline comments. Comment at: clang/lib/Basic/Version.cpp:143 llvm::raw_string_ostream OS(buf); #ifdef CLANG_VENDOR OS << CLANG_VENDOR; arphaman wrote: > This use of `CLANG_VENDOR` should be removed as well presumably. Please ignore my commen

[PATCH] D69544: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply method

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1b07aac3d1c: [clangd] NFC, reuse the source manager variable in the RawStringLiteral apply… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman updated this revision to Diff 228548. arphaman marked 2 inline comments as done. arphaman retitled this revision from "[WIP][clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros" to "[clangd] Add a tweak refactoring to wrap Objective-C string

[PATCH] D69841: Target Ivy bridge on macOS Mojave and later

arphaman added reviewers: Gerolf, dexonsmith. arphaman added a comment. @bob.wilson no longer works on llvm-project. I added Gerolf and Duncan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69841/new/ https://reviews.llvm.org/D69841

[PATCH] D69564: Include the mangled name in -ast-dump=json

arphaman added a comment. @arichardson The modified test is failing on Darwin. Here's the log output: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/5694/consoleFull Can you please address the test failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69564: Include the mangled name in -ast-dump=json

arphaman added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:31 + /// Modules that the input directly imports. + std::vector DirectModuleDependencies; + /// The Clang modules this input transitively depends on that have n

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added a comment. Adding experimental APIs is something that we haven't done before, but it be useful for this case. I have a couple of questions about the API: - Should types be prefixed / suffixed with experimental / v0 in case we need to extend the information passed to the client? -

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); What if `Opts.Targets` is empty? Repository:

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); Bigcheese wrote: > arphaman wrote: > > What if

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added a comment. I think this patch is missing tests for the C api that use c-index-test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___ cfe-commi

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added inline comments. Comment at: clang/include/clang-c/Dependencies.h:205 + */ +CINDEX_LINKAGE void clang_experimental_DependencyScannerWorker_dispose_v0( +CXDependencyScannerWorker); Looks like you have a duplicate declaration of this function, an

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

arphaman added a comment. @sammccall Sam, it looks like the tests are failing on the darwin bots: http://lab.llvm.org:8080/green/job/clang-stage1-RA/4243/consoleFull Value of: CDB.getFallbackCommand(testPath("bar.cc")).CommandLine Expected: has 6 elements where element #0 ends with "clang"

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman updated this revision to Diff 231799. arphaman marked 6 inline comments as done. arphaman added a comment. Fixed nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69543/new/ https://reviews.llvm.org/D69543 Files: clang-tools-extra/cla

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions &getLangOpts() const { +return getASTContext().getLangOpts(); kadircet wrote: > can we introduce this helper in a new patch, while changing other occurr

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

arphaman created this revision. arphaman added reviewers: Bigcheese, dexonsmith, kousikk. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. This patch makes the minimizer more conservative to avoid missing dependency files that are brought in by `__has_include`

[PATCH] D70936: [clang-scan-deps] do not skip empty #if/#elif in the minimize to avoid missing `__has_include` dependencies

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rG389530524be1: [clang-scan-deps] do not skip empty #if/#elif in the minimizer to avoid missing… (authored by arphaman). Changed prior to commit: https://reviews

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

arphaman added a comment. @aganea Please disable the new behavior for the Darwin platform. We rely on the fact that Clang `-cc1` processes crash to report crashes using system's crash reporting infrastructure. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.ll

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arphaman added a comment. Is the `Tooling/Transformer` library used by clang-format? The problem might be solved if the `Tooling/Transformer` library was its own module (just like Clang_ToolingInclusions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang-tools-extra/clangd/ParsedAST.h:80 + const LangOptions &getLangOpts() const { +return getASTContext().getLangOpts(); kadircet wrote: > arphaman wrote: > > kadircet

[PATCH] D69543: [clangd] Add a tweak refactoring to wrap Objective-C string literals in `NSLocalizedString` macros

This revision was automatically updated to reflect the committed changes. arphaman marked an inline comment as done. Closed by commit rG27f124445755: [clangd] Add a tweak refactoring to wrap Objective-C string literals in… (authored by arphaman). Changed prior to commit: https://reviews.llvm.o

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

arphaman added a comment. I guess Duncan's comments on https://reviews.llvm.org/D70568 were for this patch. I think it would be good to have: - A cmake option that controls the default behavior. It should still fork for Darwin by default, the detection should be done through CMake when it's bu

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

arphaman added a comment. The environment variable should be enough IMHO CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman added a comment. @MadCoder Indexing by names doesn't seem like the right solution. You should be able to get the canonical declaration (`getCanonicalDecl`) from the declaration that represents the method in @implementation, which should avoid the problem you're describing. CHANGES SI

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, after fixing JF's comments. Please upload patches with full context as JF mentioned, as it helps with the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ h

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman requested changes to this revision. arphaman added a comment. This revision now requires changes to proceed. @MadCoder unfortunately this change causes several test failures when `check-clang` runs: Clang :: Analysis/analyzeOneFunction.m Clang :: Index/c-index-api-loadTU-test.m Cl

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:674 } Record.push_back(D->isInstanceMethod()); Record.push_back(D->isVariadic()); @MadCoder Given the fact that you're now setting SelfDecl and CmdDecl for declaration

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman added a comment. In D71091#1773494 , @MadCoder wrote: > @liuliu I wouldn't be surprised this addresses your issues if snapchat is > using PCH This also impacts modules, so builds that use could've been affected. CHANGES SINCE LAST ACTION ht

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 ___ cfe-commits mailing list c

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3efd6957474: [ObjC] Make sure that the implicit arguments for direct methods have been setup (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:29 + + Ret.push_back("-fno-implicit-modules"); + Ret.push_back("-fno-implicit-module-maps"); @Bigcheese It looks like there's some duplication in argument lo

[PATCH] D71226: Also synthesize _cmd and self for properties

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71226/new/ https://reviews.llvm.org/D71226 ___

[PATCH] D71226: Also synthesize _cmd and self for properties

This revision was automatically updated to reflect the committed changes. Closed by commit rG1646bb866433: Also synthesize _cmd and self for properties (authored by MadCoder, committed by arphaman). Changed prior to commit: https://reviews.llvm.org/D71226?vs=232928&id=232944#toc Repository:

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268 ___

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: llvm-commits, ributzka, jkorous. Herald added projects: clang, LLVM. In Xcode 11, ld added a new flag called `-platform_version` that can be used instead of the old `-_version_min` flags. Th

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked 2 inline comments as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) +MachOTC.addPlatformVersion

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman marked an inline comment as done. arphaman added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; +// FIXME: Add macCatalyst support here ("\"mac catalyst\""). +llvm_unreachable("macCatalyst isn't yet supported");

[PATCH] D71586: [clangd] Add a test case that verifies -fimplicit-modules work in Clangd when building the AST

arphaman created this revision. arphaman added reviewers: sammccall, jkorous. Herald added subscribers: usaxena95, ributzka, kadircet, dexonsmith, MaskRay, ilya-biryukov. Herald added a project: clang. This patch adds a test case that verifies that `-fmodules -fimplicit-modules` work in Clangd w

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, But we should also have a test in Sema that verifies it works, and also covers class properties in addition to the instance ones. I can add one when committing (@MadCoder still doesn

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

This revision was automatically updated to reflect the committed changes. Closed by commit rG25ce33a6e4f3: [driver][darwin] Pass -platform_version flag to the linker instead of the… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

arphaman added a comment. I couldn't come up with a reasonable Sema-based test, so I'm going to commit this as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71588/new/ https://reviews.llvm.org/D71588 _

[PATCH] D71588: [objc_direct] fix uniquing when re-declaring a readwrite-direct property

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4e1819c1683: [objc_direct] fix uniquing when re-declaring a readwrite-direct property (authored by MadCoder, committed by arphaman). Changed prior to commit: https://reviews.llvm.org/D71588?vs=234215&i

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek Thanks, I think it reproduces on our macOS bots. I'll start fixing it right now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. Looks like `HOST_LINK_VERSION` is influencing the decision. I should specify the version manually in the tests then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579

[PATCH] D71579: [driver][darwin] Pass -platform_version flag to the linker instead of the -_version_min flag

arphaman added a comment. @phosek I fixed the tests in be88a20c900463c4919433109e4c17cd001da580 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

arphaman added a comment. @jyknight @rjmccall I'm not sure this change is 100% fine. For example, the following code no longer compiles with ARC: @protocol Delegate @end @interface X @end @interface Y @property id d; @end @implementation X + (void)foo:(Y *)y wit

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

arphaman added a comment. In D67983#1863981 , @jyknight wrote: > In D67983#1863019 , @arphaman wrote: > > > @jyknight @rjmccall I'm not sure this change is 100% fine. For example, the > > following code no longer c

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 ___ cfe-commits mailing list cfe-commi

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

arphaman added a comment. Please add a test that exercises path without ARC enabled. Comment at: clang/lib/Sema/SemaExprObjC.cpp:3019 +if (ReceiverType->isObjCClassType() && !isImplicit && +(!Receiver->isObjCSelfExpr() || !getLangOpts().ObjCAutoRefCount)) { D

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 ___ cfe-commits mailing list cfe-commi

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

arphaman added a comment. This also breaks the macOS SDK. @rsmith could you please disable this change for Darwin when you're recommitting this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman created this revision. arphaman added a reviewer: dexonsmith. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Some projects use -nostdinc, but need to access some intrinsics files when building specific files. The new `-builtininc` flag lets them use this flag

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman updated this revision to Diff 241029. arphaman marked 2 inline comments as done. arphaman added a comment. Add suggested changes. The `-ibuiltininc` flag now interacts with `-nobuiltininc` as well, i.e. it's cancelled out if `-nobuiltininc` comes after it, and vice-versa. Repository:

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

This revision was automatically updated to reflect the committed changes. Closed by commit rGf96f64d0f279: [driver][Darwin] Add an -ibuiltininc flag that lets Darwin driver include Clang… (authored by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman added a comment. In D73500#1846003 , @MaskRay wrote: > Should they use -nostdlibinc instead? Unfortunately they can't control the flag in this specific case, only add flags for specific files. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D44844: [PR36880] Avoid -Wunused-lambda-capture false positive for explicit this capture used in an unresolved member in a generic lambda

arphaman created this revision. arphaman added reviewers: malcolm.parsons, ahatanak, vsapsai. Herald added a subscriber: jkorous-apple. Clang emits an incorrect -Wunused-lambda-capture for 'this' capture in a generic lambda in a template where 'this' is used implicitly in an unresolved member ex

[PATCH] D44844: [PR36880] Avoid -Wunused-lambda-capture false positive for explicit this capture used in an unresolved member in a generic lambda

arphaman added inline comments. Comment at: lib/Sema/TreeTransform.h:11269 +// 'this' capture is marked as 'used'. +if (Old->isImplicitCXXThisAccess()) + getSema().CheckCXXThisCapture(Old->getMemberNameInfo().getLoc(), efriedma wrote: > This doesn't

<    5   6   7   8   9   10   11   12   13   14   >