arphaman added inline comments.
================ Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:31 + /// Modules that the input directly imports. + std::vector<std::string> DirectModuleDependencies; + /// The Clang modules this input transitively depends on that have not already ---------------- Are the strings supposed to represent the module names here? For C++20 modules, will a single string be enough to represent both the module's name and its partition name? ================ Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:63 + llvm::Expected<FullDependencies> + getFullDependencies(const tooling::CompilationDatabase &Compilations, + StringRef CWD, const llvm::StringSet<> &AlreadySeen); ---------------- Can you add a comment on how `AlreadySeen` is supposed to be used. Are clients expected to update it once they get more dependencies? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70268/new/ https://reviews.llvm.org/D70268 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
