arphaman accepted this revision.
arphaman added inline comments.
This revision is now accepted and ready to land.
================
Comment at:
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:43
+
+class ModuleDepCollectorPP final : public PPCallbacks {
+public:
----------------
It would be nice if the dependency collector could be reused outside of
`clang-scan-deps`, like for a new `-cc1` flag that computes the modular
dependencies in the same fashion. However, its something that can be done as a
follow-up, so for now this seems fine.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69420/new/
https://reviews.llvm.org/D69420
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
