arphaman marked an inline comment as done.
arphaman added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530
+ return "ios";
+ // FIXME: Add macCatalyst support here ("\"mac catalyst\"").
+ llvm_unreachable("macCatalyst isn't yet supported");
----------------
steven_wu wrote:
> arphaman wrote:
> > steven_wu wrote:
> > > Why not support that in this commit? I don't see problem returning a
> > > string with space inside.
> > The rest of macCatalyst support is not yet upstreamed (specifically the new
> > `Environment` value)
> Doesn't this mean you hit llvm_unreachable when you link catalyst? And this
> is the default behavior?
You can't link for macCatalyst with the current `master` Clang. I will modify
the downstream Clang to pass in the right flag though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71579/new/
https://reviews.llvm.org/D71579
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
