[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added subscribers: serge-sans-paille, Meinersbur. Meinersbur added a comment. Did you consider just removing the `-NEXT` suffix? Polly might not be the only case, other statically linked pass-plugins may also insert themselves at extension points. @serge-sans-paille might have some i

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Meinersbur updated this revision to Diff 304011. Meinersbur added a comment. Missed reference of Create in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91109/new/ https://reviews.llvm.org/D91109 Files: llvm/include/llvm/Frontend/Op

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added a comment. In D89158#2384156 , @aeubanks wrote: > Are there passes that should be running at -O0 that aren't target specific? > Otherwise the callbacks should only add passes if the optimization level > isn't -O0. At least for the legac

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur added a comment. My point is that it is possible for a pass plugin (such as `llvm/examples/Bye`) that can add themselves to the -O0 pipeline. If those plugins are linked statically, it will break tests that assume that no passes are added at those extension points. I don't quite und

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Meinersbur updated this revision to Diff 304013. Meinersbur added a comment. Last update pushed only the change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91109/new/ https://reviews.llvm.org/D91109 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

Meinersbur created this revision. Meinersbur added a reviewer: jdoerfert. Meinersbur added a project: OpenMP. Herald added subscribers: cfe-commits, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, r

[PATCH] D91109: [OMPIRBuilder] Start 'Create' methods with lower case. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5dba2d7e5a6: [OMPIRBuilder] Start 'Create' methods with lower case. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Could you try configuring LLVM with `-DLLVM_BYE_LINK_INTO_TOOLS=ON`? I assume the test will break because it unconditionally adds a FunctionPass. Repository: rG LLVM Githu

[PATCH] D89158: [NewPM] Provide method to run all pipeline callbacks, used for -O0

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. In D89158#2389520 , @aeubanks wrote: > Thanks, I wasn't aware of this. Looks like other `opt -passes='default'` > tests also look at if it pres

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, RaviNarayanaswamy, ye-luo, jhuber6, phosek, grokos, tambre, rnk, sylvestre.ledru, gtbercea, tra, yaxunl, Hahnfeld, jdenny. Meinersbur added a project: clang. Herald added subscribers: openmp-commits, dang, ormris, mgorny. He

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur updated this revision to Diff 300046. Meinersbur edited the summary of this revision. Meinersbur added a comment. Re-add accidentally removed space Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89974/new/ https://reviews.llvm.org/D89974

[PATCH] D89974: [driver][CUDA] Use CMake's FindCUDA as default --cuda-path.

Meinersbur added a comment. The host's build environment already influences the compiler's defaults, e.g. D88929 . Especially libomptarget heavily uses it, and I would argue that these should be consistent, unless explicitly overwritten. However, I see that Ope

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345029. Meinersbur added a comment. - Preserve relative order between OriginalInits and interleaved transformation's PreInits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.o

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur added a comment. Removed [WIP] flag; ready to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99459/new/ https://reviews.llvm.org/D99459 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D101595: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83ff0ff46337: [Clang][OpenMP] Allow unified_shared_memory for Pascal-generation GPUs. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 345562. Meinersbur marked 2 inline comments as done. Meinersbur added a comment. - Rebase - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files:

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:12579 Stmt *Body = nullptr; - SmallVector OriginalInits; + SmallVector>, 4> OriginalInits(1); if (!OMPLoopBasedDirective::doForAllLoops( ABataev wrote: > Why still `std::vector`?

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur updated this revision to Diff 347508. Meinersbur added a comment. - Merge branch 'arcpatch-D102180' into HEAD - Use SmallVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180 Files: clang/in

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

This revision was automatically updated to reflect the committed changes. Closed by commit rG07a6beb40215: [Clang][OpenMP] Emit dependent PreInits before directive. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/

[PATCH] D102180: [Clang][OpenMP] Emit dependent PreInits before directive.

Meinersbur added a comment. Instead of reverting, I fixed the test in rG64e5a3bbdde2 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102180/new/ https://reviews.llvm.org/D102180

[PATCH] D95496: [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonicial loop.

Meinersbur created this revision. Meinersbur added reviewers: jdoerfert, AMDChirag, anchu-rajendran, kiranchandramohan, SouraVX, ftynse, kiranktp, fghanim, ABataev, craig.topper, dblaikie, rsmith, aaron.ballman. Herald added subscribers: dexonsmith, martong, guansong, hiraditya, yaxunl. Herald ad

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. Thank you for the update. From comparing the diffs, here is the list of main changes I found: 1. Create `OMPLoopBasedDirective` as a new base class for OMPLoopDirective (and OMPTileDirective) for CollapsedNum and some utility methods for analyzing the CapturedStmt/F

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:448 + /// Number of collapsed loops as specified by 'collapse' clause. + unsigned CollapsedNum = 0; + ABataev wrote: > Meinersbur wrote: > > Inaccurate for the tile directive. >

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17274 + if (IsTopScope && Kind != Sema::TryCapture_Implicit) { +ByRef = (Kind == Sema::TryCapture_ExplicitByRef); + } else if (S.getLangOpts().OpenMP && RSI->CapRegionKind == CR_OpenMP) {

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/AST/Stmt.cpp:1275 -->isScalarType())) && -"captures by copy are expected to have a scalar type!"); break; jdoerfert wrote: > Why does this have to

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:41 +/// purposes: +/// * Loop variable: The user-accessible variable with different value for each +/// iteration. jdenny wrote: > I suggest the terms "loop user variable" and "l

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. This patch seem to have broken `GCC-C-execute-pr44575` from the llvm-test-suite. See http://meinersbur.de:8011/#/builders/76/builds/761 (this builder compiles with Polly, but it also crashes without Polly) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3008290 , @pengfei wrote: > By the way, does this bot send notification to authors when it fails? I > didn't receive this fail, so I'm not aware of it at the first time. This is my personal staging buildbot server

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. In D110037#3008292 , @pengfei wrote: > What do you think? The test-suite is an end-to-end/integration test while tests monorepository are unit/regression tests. They have different purposes. (Personally, I would prefer to red

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3009377 , @pengfei wrote: > In D109607#3008486 , @Meinersbur > wrote: > >> However, my other one that is connected to lab.llvm.org has failed as well >> and should have sen

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. This fixed the builder: http://meinersbur.de:8011/#/builders/76/builds/803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___ cfe-c

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdenny. Meinersbur added projects: OpenMP, clang. Herald added subscribers: dexonsmith, arphaman, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sst

[PATCH] D111119: [Clang][OpenMP] Infix OMPLoopTransformationDirective abstract class. NFC.

Meinersbur updated this revision to Diff 377099. Meinersbur added a comment. Re-sync Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D19/new/ https://reviews.llvm.org/D19 Files: clang/include/clang/AST/StmtOpenMP.h clang/include/clang/Bas

[PATCH] D111124: [Clang][OpenMP] Allow loop-transformations with template parameters.

Meinersbur created this revision. Meinersbur added reviewers: ABataev, jdenny. Meinersbur added projects: OpenMP, clang. Herald added subscribers: zzheng, guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Clang

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:97 +/// `std::vector::iterator::difference_type` aka `ptrdiff_t`). +/// Therefore, the distance function will be +/// [&](size_t &Result) { Result = __end - __begin; } jdenny wr

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. In D94779#2556274 , @dmgreen wrote: > This makes sense to me. If the user specifies the pragma then we send that > through to the vectorizer, whatever it is. As much as `vectorize_width(1) > interleave_count(4) vectorize_predi

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. To illustrate how complicated interpreting the vectorize pragma has become in the mid-end: TransformationMode llvm::hasVectorizeTransformation(Loop *L) { Optional Enable = getOptionalBoolLoopAttribute(L, "llvm.loop.vectorize.enable"); if (Enable =

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur accepted this revision. Meinersbur added a comment. Thank you for the clarification. It would be great if that could be communicated in the summary/commit message. It's sounds like emitting `llvm.loop.vectorize.predicate.enable` when vectorization is disabled is the motivation behind

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

This revision was automatically updated to reflect the committed changes. Closed by commit rG74ddacd30de5: [Clang] Ensure vector predication loop metadata is always emitted when pragma… (authored by malharJ, committed by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D94779: [Clang] Ensure vector predication loop metadata is always emitted when pragma is specified.

Meinersbur added a comment. I just pushed the patch with an slight addition to the summary motivitating why always emitting the predicate metadata: https://github.com/llvm/llvm-project/commit/74ddacd30de54e19b28218bc8563bd0f34f32cad Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur marked 6 inline comments as done. Meinersbur added a subscriber: rsmith. Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:94 // been "emitted" to the outside, thus, modifications are still sensible. - if (CGM.getLangOpts().OpenMPI

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Who is going to commit? Comment at: clang/include/clang/AST/StmtOpenMP.h:651-677 + static bool + doForAllLoops(Stmt *CurStmt, bool TryImperfectlyNestedLoops, +

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5215 + Expr *NegIncAmount = + AssertSuccess(Actions.BuildUnaryOp(nullptr, {}, UO_Minus, NewStep)); + Expr *BackwardDist = AssertSuccess( Meinersbur wrote: > jdenny wrot

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. In D76342#2565686 , @ABataev wrote: > I can commit it as soon as you accepted it if you don't mind of course. I do not mind Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/ne

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:292 + /// nest would extend. + SmallVector OMPLoopNestStack; + jdenny wrote: > Unless I missed something, the only accesses to `OMPLoopNestStack` are > `push_back`, `clear`, `bac

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur marked an inline comment as done. Meinersbur added a comment. In D94973#2575395 , @jdenny wrote: > This patch has no effect if the OpenMP IR builder is not enabled, and it's > disabled by default. Is that right? Yes, this is how it is intende

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::TransformOMPCanonicalLoop(OMPCanonicalLoop *L) { + // The OMPCanonicalLoop will be recreated when transforming the loop-associted + // directive. jdenny wrote: >

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause NFC.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a p

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause NFC.

Meinersbur updated this revision to Diff 349762. Meinersbur edited the summary of this revision. Meinersbur added a comment. Add context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103665/new/ https://reviews.llvm.org/D103665 Files: clang/incl

[PATCH] D103666: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

Meinersbur created this revision. Meinersbur added a reviewer: ABataev. Meinersbur added a project: OpenMP. Herald added subscribers: guansong, yaxunl. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clan

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur marked 8 inline comments as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:463-478 + static const SpecificClause *getSingleClause(ArrayRef Clauses) { +auto ClausesOfKind = getClausesOfKind(Clauses); -if (Clauses.begi

[PATCH] D103665: [Clang][OpenMP] Add static version of getSingleClause. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd466ca087aae: [Clang][OpenMP] Add static version of getSingleClause. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10

[PATCH] D103666: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc41a8fbfbb09: [Clang][OpenMP] Refactor checking for mutually exclusive clauses. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo

[PATCH] D99459: [OpenMP] Implement '#pragma omp unroll'.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2600-2604 + RValue FactorRVal = EmitAnyExpr(FactorExpr, AggValueSlot::ignored(), + /*ignoreResult=*/true); +

[PATCH] D95496: [clang][OpenMP] Augment ForStmt/CXXForRangeStmt for OpenMP canonical loops.

Meinersbur abandoned this revision. Meinersbur added a comment. Obsolete since D94973 was committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95496/new/ https://reviews.llvm.org/D95496 ___

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur created this revision. Herald added subscribers: dang, jvesely. Meinersbur requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: openmp-commits, libcxx-commits, cfe-commits, sstefan1. Herald added projects: clang, libc++, OpenMP. Herald added a

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 353220. Meinersbur edited the summary of this revision. Meinersbur added a comment. - Undo "typechange" changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 Fil

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2831746 , @dblaikie wrote: > This is probably more @aaron.ballman 's wheelhouse, but for my money this > seems pretty problematic - will make quoted text in compiler diagnostics > weird/difficult to read, etc. It

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. Some bikeshedding: Calls to `AvoidConcat` could be avoided by always inserting a space between tokens at the cost of making the output larger. In the current form, the flag could also be named `-fminimize-whitespace`. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. I am working on a fix, but I wouldn't mind reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list c

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. @romanovvlad This is due to -fms-extensions. It Expands `__Pragma` to `#pragma` instead of keeping it a `__Pragma`. This is a one-line fix. @alexfh This was fixed by D106924 I would suggest to not revert. Will upload a patch for `-f

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2916897 , @aaron.ballman wrote: > In D104601#2916887 , @Meinersbur > wrote: > >> I am working on a fix, but I wouldn't mind reverting. > > I would be comfortable reverting

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur created this revision. Meinersbur added reviewers: aaron.ballman, dblaikie, mstorsjo, romanovvlad, alexfh. Meinersbur added a project: clang. Meinersbur requested review of this revision. The -fms-extensions converts __pragma (and _Pragma) into a #pragma that has to occur at the begin

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. Patch uploaded here: D107183 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mail

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur updated this revision to Diff 363146. Meinersbur added a comment. Refine test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107183/new/ https://reviews.llvm.org/D107183 Files: clang/lib/Frontend/PrintPreprocessedOutput.cpp clan

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. > Correct -- that would be unfortunate as I believe you were hoping for this to > be in Clang 13 for ccache support. Yes, that would have been the ideal outcome. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

Meinersbur updated this revision to Diff 363334. Meinersbur added a comment. - Use %clang_cc1 because %clang adds options according to it triple, i.e. -fms-extensions is added implicitly for Windows targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D107183: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0e2586779ca6: [Preprocessor] Ensure newline after #pragma introduced by -fms-extensions. (authored by Meinersbur). Reposi

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. @mstorsjo I've taken all steps required for the resolution suggested @aaron.ballman. llvm.org/PR51300 suberseedes llvm.org/PR51261 (release-13.x branch is under @tstellard's control). D107183 has been pushed to main to fix the outs

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#2919775 , @tstellar wrote: > Do we have all the issues fixed in trunk yet or do we need to revert in the > release/13.x branch. All known issues have been fixed on trunk. However, @alexfh said they are going to do

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

Meinersbur added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:708 /// - /// \returns The insertion position *after* the master. + /// \returns The insertion position *after* the masked. InsertPointTy createMasked(const LocationDescription

[PATCH] D107540: [OMPBuilder] Clarify CanonicalLoopInfo. NFC.

Meinersbur created this revision. Herald added subscribers: wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, hiraditya. Herald

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

Meinersbur updated this revision to Diff 366161. Meinersbur marked 7 inline comments as done. Meinersbur added a comment. - Address @ftynse's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107540/new/ https://reviews.llvm.org/D107540 Files:

[PATCH] D107540: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1de32d6ddd9: [OMPIRBuilder] Clarify CanonicalLoopInfo. NFC. (authored by Meinersbur). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107540/new/ https://rev

[PATCH] D107430: [OMPIRBuilder] Add ordered without depend and simd clause to OMPBuilder

Meinersbur added a comment. While manually editing `ordered_codegen.cpp` gives nicer results, re-running `update_cc_test_checks.py` would be less work. Your manual changes would be also be dropped the next time somebody runs update_cc_test_checks.py and commits. The code seems derived from @fg

[PATCH] D107430: [OMPIRBuilder] Add ordered directive to OMPIRBuilder

Meinersbur added a comment. Note that the `OpenMPIRBuilderTest.OrderedDirective` test is still crashing. Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2156-2157 + + Value *EntryBBTI = EntryBB->getTerminator(); + EXPECT_EQ(EntryBBTI, nullptr); +

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. During a trial phase while compiling everything twice with ccache I got the following results. Only unify_mode:: $ ccache -d . -s cache directory . primary config ./ccache.conf secondary config (readonly) /hom

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2842686 , @dblaikie wrote: > One other thing: This wouldn't be usable when using debug info, presumably, > because it'd refer to the wrong lines, etc. This is considered in the ccache patch

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur updated this revision to Diff 355350. Meinersbur marked 6 inline comments as done. Meinersbur added a comment. - Address review by @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. In D104601#2847400 , @aaron.ballman wrote: > ... would add that it's very common for implementers to ask developers to run > their code through `-E` mode to submit preprocessed output in order to > reproduce a customer issue

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104601/new/ https://reviews.llvm.org/D104601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. ping It would be nice if we could get this into clang 13 since the ccache part detects support for `-fnormalize-whitespace` when detecting clang 13+. Probing the compiler for whether it supports `-fnormalize-whitespace` on every run would be prohibitively expensive.

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

Meinersbur added a comment. In D104601#3105044 , @manmanren wrote: > It will fail the compilation on the preprocessed output with > error: expected unqualified-id > int test();#pragma clang assume_nonnull end The handler for assume_nonull passes an inval

[PATCH] D113210: [NewPM] Use the default AA pipeline by default

Meinersbur added a comment. This change caused the Polly build to fail: https://lab.llvm.org/buildbot/#/builders/10/builds/7501 opt: /home/worker/buildbot-workers/polly-x86_64-gce1/rundir/llvm.src/llvm/include/llvm/IR/PassManager.h:784: typename PassT::Result& llvm::AnalysisManager::getResul

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8321 +TreeTransform::TransformOMPCanonicalLoop(OMPCanonicalLoop *L) { + // The OMPCanonicalLoop will be recreated when transforming the loop-associted + // directive. jdenny wrote: >

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. In D94973#2590867 , @jdenny wrote: > One property of this patch that has bothered me is that OMPCanonicalLoop is > not a loop. Instead, it's an AST node that is sandwiched between a directive > and a loop to contain extra inf

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

Meinersbur added a comment. As a contributor to Polly, this makes me happy to see ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97819/new/ https://reviews.llvm.org/D97819 ___ cfe-commits mailing list

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. In D94973#2591493 , @jdenny wrote: >> I even think that representing semantic information alongside of syntax is >> one of the principles of Clang's AST. > > Interesting. Is that documented somewhere? https://clang.llvm.org/d

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. Is is that same problem that D98265 addresses? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ c

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur requested changes to this revision. Meinersbur added a comment. This revision now requires changes to proceed. Thanks for helping to complete the OpenMPIRBuilder implementation! Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSi

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

Meinersbur added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. jhenderson wrote: > RKSimon wrote: > > aaron.ballman wrote: > > > jhenderson wrote: >

[PATCH] D114143: [OpenMP][IRBuilder] Fix createSections

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. AllocaIP could be handled better, but as a fix LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114143/new/ https://reviews.llvm.org/

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. In D114413#3154936 , @peixin wrote: > @Meinersbur Please rebase on main. The function "getPreheader()" was moved > into OMPIRBuilder.h. I rebased, but I am not sure what you are referring to. `getPreheader()` always was in `

[PATCH] D114379: [OMPIRBuilder] Add support for simd (loop) directive.

Meinersbur added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:2586-2587 void CodeGenFunction::EmitOMPSimdDirective(const OMPSimdDirective &S) { + + bool UseOMPIRBuilder = CGM.getLangOpts().OpenMPIRBuilder; + if (UseOMPIRBuilder) { arnamoy10

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

Meinersbur added a comment. In D114413#3160044 , @peixin wrote: > In D114413#3159095 , @Meinersbur > wrote: > >> In D114413#3154936 , @peixin wrote: >> >>> > > `getPrehe

[PATCH] D136784: [Clang] Improve diagnostic message for loop hint pragma

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Parse/ParsePragma.cpp:1306 StringRef Str = PragmaName.getIdentifierInfo()->getName(); std::string ClangLoopStr = (llvm::Twine("clang

[PATCH] D131526: [OMPIRBuilder] Add support for safelen clause

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:3042 + + if (!(Simdlen == nullptr && Safelen == nullptr)) { +// If both simdlen and safelen clauses ar

<    1   2   3   4   5   >