Meinersbur added inline comments.
================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:708 /// - /// \returns The insertion position *after* the master. + /// \returns The insertion position *after* the masked. InsertPointTy createMasked(const LocationDescription &Loc, ---------------- Could you commit these typo fixes separately? That is, just push it to main, no Phabricator review required. ================ Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:721 /// - /// \returns The insertion position *after* the master. + /// \returns The insertion position *after* the critical. InsertPointTy createCritical(const LocationDescription &Loc, ---------------- Could you commit these typo fixes separately? That is, just push it to main, no Phabricator review required. ================ Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2125 + + AllocaInst *PrivAI = Builder.CreateAlloca(F->arg_begin()->getType()); + ---------------- Could you give this alloca register a name? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
