Meinersbur added a comment. Note that the `OpenMPIRBuilderTest.OrderedDirective` test is still crashing.
================ Comment at: llvm/unittests/Frontend/OpenMPIRBuilderTest.cpp:2156-2157 + + Value *EntryBBTI = EntryBB->getTerminator(); + EXPECT_EQ(EntryBBTI, nullptr); + ---------------- peixin wrote: > Meinersbur wrote: > > Consider emitting a terminator, call `finalize()` and `verifyModule`. > Why do you want me to emit the terminator? If it is because you think the > outlined captured function is not generated due to finalize call, there is no > need. Discussed above. Sorry about the misguide. Without terminator, `verifyModule` will complain about it being missing. `verifyModule` should be called to ensure that the emitted IR is well-formed. Anyway, you seem to have added it in the last diff update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107430/new/ https://reviews.llvm.org/D107430 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
