Meinersbur added a comment. In D110037#3008292 <https://reviews.llvm.org/D110037#3008292>, @pengfei wrote:
> What do you think? The test-suite is an end-to-end/integration test while tests monorepository are unit/regression tests. They have different purposes. (Personally, I would prefer to reduce the amount of unit/regression testing that can already be covered by the test-suite, but that would be a bigger story) ================ Comment at: clang/test/CodeGen/X86/va-arg-sse.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // RUN: %clang_cc1 %s -O2 -emit-llvm -o - -triple x86_64-unknown-unknown | FileCheck %s ---------------- lebedev.ri wrote: > Please don't use `-O*` in clang irgen tests. > This should *only* test what IR is produced by clang itself. I agree here, testing `-O*` output will break easily with any unrelated change in LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
