[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

hans added a comment. In D75093#1891067 , @thakis wrote: > This is what -MD passes (which is why the -sys flag already exists), and more > orthogonal flags instead of fewer, tangled ones is what we usually go for at > the cc1 layer. So I like it more as

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

hans created this revision. hans added reviewers: rnk, thakis. This puts the warning behind a separate -Wmicrosoft-template-shadow flag as suggested on the bug. https://reviews.llvm.org/D75121 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

hans added a comment. Thanks for writing notes! Go ahead and push directly to the branch when you're ready. Comment at: clang/docs/ReleaseNotes.rst:288 +OpenCL Kernel Language Changes in Clang -- For the formatting to work, I

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

hans added a comment. Thanks! Cherry-picked to 10.x as 6f4f4f2c8ce1ad17bdec9fe2071d3fe439eca9eb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

hans added a comment. In D75121#1891879 , @rnk wrote: > code lgtm > > Should we have a standalone test for this? Something that compiles with > `clang -cc1 -Wno-microsoft -Wmicrosoft-template-shadow` and looks for the > shadowing warnings? Adding one b

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6612ea8af: Put microsoft template parameter shadow warning behind separate flag (PR44794) (authored by hans). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D75121?v

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

hans added a comment. In D75125#1895060 , @Anastasia wrote: > @hans, what is the current process for committing to the release branch? > Would you be able to commit this or would you prefer that I commit myself? > > Thank you! You can just push it to th

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

hans added a comment. In D74784#1894484 , @dmajor wrote: > Thanks! I'm still working on getting commit access, would one of you be able > to submit for me? I've committed as 5122e828701c88f8d53ee881bc68f3904454d154

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

hans added a comment. I've reverted cbc9d22e49b434b6ceb2eb94b67079d02e0a7b74 on master in 7ea9a6e0220da36ff2fd1fbc29c2755be23e5166 until it can be resolve

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

hans added a comment. In D74846#1895319 , @aganea wrote: > Thanks @hans! Nevertheless I think this is a good change and we should push > it for 11.0. I was indeed seeing better timings on our end with what @llunak > was proposing, we are heavy users of P

[PATCH] D74784: [driver][darwin] Don't use -platform_version flag by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG5122e828701c: [driver][darwin] Don't use -platform_version flag by default (PR44813) (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74784/

[PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

hans accepted this revision. hans added a comment. Nice, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75279/new/ https://reviews.llvm.org/D75279 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

hans added a comment. Probably worth a mention in clang/docs/ReleaseNotes.rst, and maybe we should call it out in the user manual too, similarly to what we do for /Zc:dllexportInlines- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75093/new/ http

[PATCH] D75310: [CUDA, clang-cl] Filter out unsupported arguments for device-side compilation.

hans accepted this revision. hans added a comment. It seems a little bit unfortunate to have to sprinkle !isNVPTX everywhere, but I don't have any better ideas, so lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75310/new/ https://reviews.llvm

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

hans added a comment. In D73462#1900364 , @omjavaid wrote: > This change breaks lldb buildbots here: > > http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/2123 > http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/5911 > > Please revisi

[PATCH] D75373: [Clang] Fix Hurd toolchain class hierarchy

hans added a comment. In D75373#1898620 , @aganea wrote: > @hans, do you think this could be included in 10.0? I think it's too late in the process for this, maybe it can be merged for 10.0.1. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7537

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

hans added a comment. I also just noticed that this broke the Chromium build, see the attached reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=1057559#c1 clang++: /work/llvm.monorepo/clang/lib/AST/ExprConstant.cpp:14013: llvm::APSInt clang::Expr::EvaluateKnownConstInt(const

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

hans added a comment. In D72911#1900091 , @sylvestre.ledru wrote: > @krasimir @MyDeveloperDay @hans Looks like it is a regression from > https://reviews.llvm.org/D72911 > and the fix isn't in 10.0rc2. > Should we take it? Seems pretty safe. I've push

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

hans added a comment. In D69573#1900089 , @sylvestre.ledru wrote: > @MyDeveloperDay @hans what about adding this to the release notes? > I was trying clang-format 10 on Firefox code base and I noticed this change > which isn't documented in > > https:

[PATCH] D75469: Add C standard upgrade in clang-11 release note

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with comment Comment at: clang/docs/ReleaseNotes.rst:551 + +- The following release of clang (clang-11) will upgrade the default C language + standard used if not specified

[PATCH] D70764: build: reduce CMake handling for zlib

hans added a comment. There were some concerns raised on this patch, and also in PR44780. I think at this point it's safer to revert these changes and start over. I've pushed the revert in 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e

[PATCH] D68824: Fix __builtin_assume_aligned with too large values.

hans added a comment. We hit this in V8 which is annotating some pointers as being 4GB-aligned. Does anyone know what it would take to raise Clang's limit here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68824/new/ https://reviews.llvm.org/D68824 _

[PATCH] D65511: Delay emitting dllexport explicitly defaulted members until the class is fully parsed (PR40006)

hans added a comment. Sorry, seems I forgot to submit this comment.. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11545 +for (CXXMethodDecl *M : WorkList) { + DefineImplicitSpecialMember(*this, M, M->getLocation()); + ActOnFinishInlineFunctionDef(M); ---

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

hans added a comment. In D69760#1734534 , @thakis wrote: > In D69760#1734524 , @thakis wrote: > > > We currently do cross builds of chrome/win on linux, and this breaks that. > > > > As far as I know, no linker othe

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

hans added a comment. I've reverted in b1ac1f00716 until it can be fixed properly. We noticed this in Chromium where we started seeing build spam like: '+soft-float-abi' is not a recognized feature for this target (ignoring

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

hans added a comment. Thanks for sharing this! I still need to take a proper look, but my first thought is this: Instead of invoking main() (or a similar function like ClangDriverMain) as an alternative to spinning up the cc1 process, would it be possible to call ExecuteCC1Tool() directly? I g

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

hans added a comment. Thanks for the update! I think calling ExecuteCC1Tool instead of main is an improvement (there's no need to think about "re-entering" the process, it's really just a function call). I still don't see why it needs to go through a function pointer. I was hoping the code coul

[PATCH] D69825: [Clang][Driver] Bypass cc1 process and re-enter driver main

hans added a comment. In D69825#1747539 , @aganea wrote: > @hans : Simply because `ExecuteCC1Tool()` lives in the clang tool > (`clang/tools/driver/driver.cpp`) and we're calling it from the > clangDriver.lib (`clang/lib/Driver/Job.cpp`). The clangDriver

[PATCH] D70340: Add a key method to Sema to optimize debug info size

hans added a comment. Nice! Silly questions, but for my own education: I thought the key function concept only existed in the Itanium ABI, but from your numbers it sounds like it's a concept, at least for debug info, also on Windows? Comment at: clang/include/clang/Sema/Sema

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added inline comments. Comment at: clang/lib/Driver/Job.cpp:347 +StringRef DriverExe = llvm::sys::path::stem(D.ClangExecutable); +if (CommandExe.equals_lower(DriverExe)) +CC1Main = Driver::CC1Main; aganea wrote: > hans wrote: > > Now that we'

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

hans added a comment. Thanks! I'm not that familiar with the coverage counters, but this seems good as far as I can tell. Maybe add the test case from PR44011? I didn't see any test cases with that kind of gaps between cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70571/new/ ht

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

hans added a reviewer: klimek. hans added a comment. klimek, What do you think? empty2fill: Do you have an example input that I could use to hit the "Specified argument was out of the range of valid values." error? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D70632: clang-format-vs : Fix typo NUGET_EXE_DIR on README

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access, or if not would you like me to commit on your behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70632/new/ h

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

hans added a comment. We're now getting a ton of warnings about this in Chromium. (https://crbug.com/1028110) And I'm not really sure what the warning wants us to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.o

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

hans added a comment. In D70342#1758832 , @xbolva00 wrote: > Add copy ctor/op= manually. Does the warning mean that the implicitly defined copy ctor is not going to work in some later version of the language? I'm just trying to understand what it's war

[PATCH] D70632: clang-format-vs : Fix typo NUGET_EXE_DIR on README

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2601a4116f6: clang-format-vs : Fix typo NUGET_EXE_DIR on README (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70632/new/ https://review

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. Thanks! This is starting to look really good now. Comment at: clang/lib/Driver/Job.cpp:318 -int Command::Execute(ArrayRef> Redirects, - std::string *ErrMsg, bool *ExecutionFailed) const { +int Command::PrepareExecution(SmallVectorImpl

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. > This is a support patch for D69825 . Thanks for breaking this out! > It handles an exception in the same way as the global exception handler (same > side-effect, print call stack & cleanup), and can return the exception code. I'm not fam

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. >> empty2fill: Do you have an example input that I could use to hit the >> "Specified argument was out of the range of valid values." error? > > F10867463: Main.cpp

[PATCH] D70633: clang-format-vs : Fix Unicode formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rGe20a1e486e14: clang-format-vs : Fix Unicode formatting (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70633/new/ https://reviews.llvm.org

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. Sorry for the slow response. This is a pretty complicated patch, so I needed some time to wrap my head around it. I'm still not entirely sure I got it right, but here are some high-level comments. - About making CrashRecoveryContext::Enable() the default, that seems somewh

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. In D70568#1763824 , @aganea wrote: > Thanks for analyzing this! > > In D70568#1763769 , @hans wrote: > > > - About making CrashRecoveryContext::Enable() the default, that seems > > somewhat or

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

hans created this revision. hans added reviewers: rnk, rsmith. This was already the intention of DelayedDllExportClasses, but this test case would break it: template struct Tmpl {}; struct Outer { struct Inner { __declspec(dllexport) Inner() = default; unsigned int

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks fine to me. Comment at: clang/docs/SourceBasedCodeCoverage.rst:330 +last case ends). This gap region has a zero count: this causes "gap" areas in +between case statements,

[PATCH] D70931: [MS] Emit exported complete/vbase destructors

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Nice, thanks! Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1349 + // the base dtor is emitted. + // FIXME: To match MSVC, this should only be done when the class was + //

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. I'm also supported, even though the gains are smaller than first thought. It depends on D70568 though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 ___

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

hans added a subscriber: tstellar. hans added a comment. In D67463#1767919 , @rnk wrote: > @hans, are we still accepting 9.0.1 patches? I thought we'd already made a > release candidate. +Tom: ^ Repository: rL LLVM CHANGES SINCE LAST ACTION https

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

hans marked 2 inline comments as done. hans added a comment. Thanks for the review! Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2232 + if (ParsingClassDepth == 0) +ActOnFinishCXXNonNestedClass(Instantiation); rnk wrote: > This function doesn't

[PATCH] D70905: Actually delay processing DelayedDllExportClasses until the outermost class is finished (PR40006)

This revision was automatically updated to reflect the committed changes. hans marked an inline comment as done. Closed by commit rG92ce2aff680e: Actually delay processing DelayedDllExportClasses until the outermost class is… (authored by hans). Herald added a project: clang. Changed prior to com

[PATCH] D71012: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

hans created this revision. hans added a reviewer: rnk. See bug. https://reviews.llvm.org/D71012 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/clang_f_opts.c Index: clang/test/Driver/clang_f_opts.c === --- cl

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. Seems fine to me. I'm not sure how to test the actual "don't write to temp file" functionality, but at least there could be a test to check that the flag gets forwarded to cc1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70

[PATCH] D71012: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208)

This revision was automatically updated to reflect the committed changes. Closed by commit rG18b72d337ef3: Also check /Fo when deciding on the .gcna / .gcda filename (PR44208) (authored by hans). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. > Our build system does not handle randomly named files created during the > build well. Can you share more details about why this is a problem? At least the build systems I work with would not even see the temporary files, as they're written to /tmp or similar, and inste

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. I see. For some reason I thought the temporary files would be written elsewhere, like in /tmp, but I see that's not the case, and I guess it also makes sense to avoid having to copy it between fil

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1108 DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecoveryContext::GetCurrent(); This was added in http://llvm.org/r1

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans marked an inline comment as done. hans added a comment. I'm basically happy with this, just some minor comments. Comment at: clang/lib/Driver/Job.cpp:376 + CrashReportInfo *CrashInfo) const { + OS << " Running the following in ExecuteCC1Tool():\n"; +

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. I looked over this again, and also studied CrashRecoveryContext some more. I don't really understand why this patch needs to modify the code for how the CRC is enabled and installed, etc. I thought all we need for in-process-cc1 is to add the DumpStackAndCleanupOnFailure

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. In D70615#1789142 , @zahen wrote: > Any additional changes required? If not could someone please submit on my > behalf? @rnk, @hans, @thakis ? Sorry, this got lost in my email. I've committed it as d129aa1d5369781deff6c6b854cb61

[PATCH] D70615: Add an -fno-temp-file flag for compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rGd129aa1d5369 (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 Files: clang/include/clang/Drive

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. > The way `Enable()/Disable()` is currently implemented will not work when the > tool executes jobs in parallel (ie. llvm-buildozer > I presented at LLVM conference; > or our re-implementation of /MP >

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. Sorry for the breakage, and thanks for reverting! I'll try to follow up and fix this tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://reviews.llvm.org/D70615 __

[PATCH] D70615: Add an -fno-temp-file flag for compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rGdde7b6bcda9d: Re-land "Add an -fno-temp-file flag for compilation" (authored by hans). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70615/new/ https://revi

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

hans added a comment. Very nice, thanks! Comment at: clang/lib/Format/TokenAnnotator.cpp:502 Left->Type = TT_ObjCMethodExpr; + } else if (Style.isCpp() && InsideInlineASM) { +Left->Type = TT_InlineASMSymbolicNameLSquare; Is the Style.isCpp

[PATCH] D75675: [clang-format] do not insert spaces around inline asm symbolic names

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, thanks for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75675/new/ https://reviews.llvm.org/D75675

[PATCH] D75406: Avoid including FileManager.h from SourceManager.h

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ cfe

[PATCH] D76099: [Clang][Driver] In -fintegrated-cc1 mode, avoid crashing on exit after a compiler crash

hans added a comment. In D76099#1921571 , @aganea wrote: > Looks like there's a memory corruption detected by ASAN, but I'm not sure > it's related to my change. Maybe someone with a more expert eye could tell? > > http://lab.llvm.org:8011/builders/saniti

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

hans added a comment. In D76030#1925445 , @tra wrote: > @hans -- this should be cherry-picked into 10 if it's not too late yet. It's probably too late for 10.0.0, but sounds like a good candidate for 10.0.1. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

hans added a comment. This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=45218 Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66332/new/ https://reviews.llvm.org/D66332

[PATCH] D76444: Use FinishThunk to finish musttail thunks

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76444/new/ https://reviews.llvm.org/D76444 ___ cfe

[PATCH] D73834: Update for Clang 10 release notes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me, go a head and commit it to the branch. > Can you cherry-pick c03349e40f21 > for > D73434

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans added a comment. > Evidently I can cut the patch in smaller pieces, let me know. Yes, I think this would be good. There's a lot going on in this patch, and it would be good to separate the simple stuff from the tricky parts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans added a comment. I think so, but I need to look closer at the CrashRecoveryContext changes, and it would help to do that separately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73742/new/ https://reviews.llvm.org/D73742 _

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thank for noticing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73937/new/ https://reviews.llvm.org/D73937

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. In D7#1849326 , @hans wrote: > > I created D73680 to place the patch label > > after BTI. > > > > @hans Is there still time to cherry pick the patch to release/10.x? See > > above, Linux develo

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

hans added a comment. lgtm, but if you want it wouldn't hurt to include even more details from the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74031/new/ https://reviews.llvm.org/D74031

[PATCH] D74031: Update for Clang 10 release notes in order to have reference to D66404.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks great, thanks! Do you have commit access? If so, go ahead and push directly to the 10.x branch, otherwise let me know and I'll do it for you. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. > D73760 will be nice to be cherry picked if > there is not much trouble, so we won't have a major release with > unsatisfactory label placement if Linux x86 developers ever want to adopt > -fpatchable-function-entry=. Cherry-picked as 4c

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

hans added a comment. In D68923#1857307 , @aaronpuchert wrote: > @hans, could you cherry-pick this on the version 10 branch? As I wrote in > D68923#1857046 , this is a > regression from Clang 8. Sounds good to

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/Pragma.cpp:1108 - DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecove

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

hans accepted this revision. hans added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Lex/Pragma.cpp:42 #include "llvm/ADT/StringRef.h" #include "llvm/Support/CrashRecoveryContext.h" #include "llvm/Support/Compiler.h"

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1108 - DebugOverflowStack(); -} else if (II->isStr("handle_crash")) { - llvm::CrashRecoveryContext *CRC =llvm::CrashRecoveryContext::GetCurrent(); hans wrote: > Maybe also add to the

[PATCH] D68720: Support -fstack-clash-protection for x86

hans added a comment. This seems to be breaking the buildbots, e.g. http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/33475/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Astack-clash-protection.c http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. It looks like the current code goes way back, to https://llvm.org/r39093 Do you know why it's started failing now? Consistency is nice though, so I don't see any downside to this. Repository:

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Herald added a subscriber: steakhal. Looks good to me. Thanks for writing release notes! If you have commit access, go ahead and push directly to the branch, otherwise let me know and I'll be happ

[PATCH] D73966: [analyzer] Add 10.0.0 release notes.

hans added a comment. Pushed to 10.x in 64515b35844b925bdb76821d03ad4d7ddebe06e7 . Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73966/new/ https://reviews.llvm.org/D73966 __

[PATCH] D74063: [Clang] Remove #pragma clang __debug handle_crash

hans added a comment. Cherry-picked to 10.x in 793d643f6d69e6908a6ece4aacb07b6573e33e18 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74063/new/ https://reviews.llvm.org/D74063

[PATCH] D74070: [Clang] Don't let gen crash diagnostics fail when '#pragma clang __debug crash' is used

hans added a comment. In D74070#1863989 , @aganea wrote: > Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 > . Pushed that to 10.x as 0e1c734fa5b88ec7efc2bcf8d45ed58f6ba48b91 <

[PATCH] D74076: [Clang][Driver] Remove -M group options before generating crash diagnostics

hans added a comment. In D74076#1863987 , @aganea wrote: > Relanded as rG75f09b54429bee17a96e2ba7a2ac0f0a8a7f7e74 > Pushed that to 10.x as 0e1c734fa5b88ec7efc2bcf8d45ed58f6ba48b91

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

hans added a comment. > @erichkeane Thanks for filing the bugzilla bug. I was having some problems > with my bugzilla login myself and wasn't able to do so. I'll track progress > if this bug and decide shortly if my feature should imply no-integraed-cc1. > Thanks Guys. I think that bug was for

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me, just a nit about one of the comments. Thanks for making this easier to review by splitting it up! Comment at: llvm/include/llvm/Support/Process.h:205 + + ///

[PATCH] D74129: Prefer __vector over vector keyword for altivec use

hans added a comment. In D74129#1861777 , @serge-sans-paille wrote: > @hans : clang 10.0.0rc1 doesn't build on ppc64le in Fedora without that > patch. Cherry-picked to 10.x as 699e2a6c5551eacf10be7e64f579120954f55b10

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

hans added a comment. I don't have the context here. Was I added as a subscriber because it's related to the clang 10 release? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org/D72872

[PATCH] D73742: [Clang][Driver] After default -fintegrated-cc1, fix report_fatal_error no longer generates preprocessed source + reproducer.sh

hans added a comment. In D73742#1871037 , @smeenai wrote: > In D73742#1871012 , @aganea wrote: > > > In D73742#1870961 , @smeenai wrote: > > > > > I'm assuming this needs to

[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

hans added inline comments. Comment at: clang/include/clang/Driver/Job.h:90 + /// Whether the command will be executed in this process or not. + bool InProcess : 1; + I think Reid just meant put the bool fields after each other to minimize padding. Using bitfi

[PATCH] D73852: [clang] detect switch fallthrough marked by a comment (PR43465)

hans added a comment. I also jumped when I saw that this now makes certain comments "load bearing". That doesn't seem like a great idea to me. The warning may be all right for C++ code, which has an attribute to suppress it, but C code does not normally use such attributes, and has no standard

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

hans added a comment. In D72872#1870256 , @vsapsai wrote: > In D72872#1868989 , @hans wrote: > > > I don't have the context here. Was I added as a subscriber because it's > > related to the clang 10 release? > > >

[PATCH] D72242: Fix crash on value dependent bitfields in if conditions in templates

hans added a comment. In D72242#1872827 , @smeenai wrote: > CC @hans for the 10.0 branch. Cherry-picked to 10.x as 808f8a632f8bc12830157c57461ae8f848c566a3 . Please let me know if the

[PATCH] D74464: Fix integration of pass plugins with llvm dylib

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74464/new/ https://reviews.llvm.org/D74464

[PATCH] D74490: [Clang] Limit -fintegrated-cc1 to only one TU

hans added a comment. Cherry-picked to 10.x as 9c9e46d786d0581079e5018e550cbe187a1ec219 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74490/new/ https://reviews.llvm.org/D74490

[PATCH] D74634: Remove "ELF Only" restriction from section flags

hans accepted this revision. hans added a comment. In the commit message, which is currently "Remove "ELF Only" restriction from section flags" maybe add "help text" or something to make it obvious this only changes the help text -- i.e. it's not removing any actual "elf only" restriction. R

<    3   4   5   6   7   8   9   10   11   >