hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
Nice, thanks! ================ Comment at: clang/lib/CodeGen/MicrosoftCXXABI.cpp:1349 + // the base dtor is emitted. + // FIXME: To match MSVC, this should only be done when the class was + // dllexported inlines are being exported. ---------------- The grammar looks funny here: "when the class was dllexported inlines are being exported". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70931/new/ https://reviews.llvm.org/D70931 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
