hans added a comment.

I also jumped when I saw that this now makes certain comments "load bearing". 
That doesn't seem like a great idea to me.
The warning may be all right for C++ code, which has an attribute to suppress 
it, but C code does not normally use such attributes, and has no standard 
syntax for them. I think it would be better if the warning was off by default 
for C code. Those C projects that wish could opt-in to it and jump through the 
hoops of applying attributes to silence the warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73852/new/

https://reviews.llvm.org/D73852



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to